Page MenuHomePhabricator
Create Task
Maniphest T333662

Remove legacy EntitySchema Datatype in WikibaseRepo
Closed, ResolvedPublic
Actions

Description

Based on ADR 0003, we want EntitySchema to make use of Wikibase's hooks for adding a new Datatype.
Hence, legacy implementation of an EntitySchema Datatype (which is currently disabled on Wikidata) can be removed.

The legacy datatype was added in Add EntitySchema data type (I9d0ddb82) and we should make sure that we're not leaving dead code (services, formatters, etc.) around when removing it.

Things to remove:

  • …
  • WikiLinkExistsValidator

Things to move to EntitySchema:

  • i18n messages wikibase-listdatatypes-entity-schema-head, wikibase-listdatatypes-entity-schema-body
  • …?

Open Questions:

  • Is removing that legacy Datatype defacto required for us to be able to create a new one, or could this be a standalone cleanup task?

Details

SubjectRepoBranchLines +/-
Remove PHP code for entity-schema data typemediawiki/extensions/Wikibasemaster+14 -472
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Mar 31 2023, 9:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2023, 9:31 AM
Michael updated the task description. (Show Details)Mar 31 2023, 9:32 AM
Lucas_Werkmeister_WMDE subscribed.Mar 31 2023, 3:58 PM

Given that we made the datatype available by default in multiple Wikibase releases (😦), could this be considered a breaking change?

Do we know of any third-party Wikibases actually using this datatype? Or do we have any way to find them?

• oleksandr_tsyba_WMDE subscribed.Mar 31 2023, 4:07 PM
Michael added subscribers: darthmon_wmde, Tarrow.EditedMar 31 2023, 4:08 PM

I guess if it is possible to figure out, then that would be a question that the Suite Team could answer (cc @darthmon_wmde). Do we ship EntitySchema with Wikibase Suite? Is such information maybe contained in that pingback information from WikibaseManifest?

Also, what is the state of this on wikibase.cloud? (cc @Tarrow )

My hope is that we can just turn this "unannounced" "internal" feature off again, without anyone noticing. 🤞

Lucas_Werkmeister_WMDE added a comment.Mar 31 2023, 4:20 PM

The data type is enabled on this random Wikibase Cloud wiki I pulled out of my browser history: https://coffeebase.wikibase.cloud/wiki/Special:ListDatatypes

Michael added a comment.Mar 31 2023, 4:42 PM
In T333662#8746260, @Lucas_Werkmeister_WMDE wrote:

The data type is enabled on this random Wikibase Cloud wiki I pulled out of my browser history: https://coffeebase.wikibase.cloud/wiki/Special:ListDatatypes

😬

At least that project does not actually have a property with that Datatype. I guess on cloud we should be in principle able to run some sql against every Wikibase to figure out if there is one that has created a Property with the EntitySchema datatype?

Lucas_Werkmeister_WMDE added a comment.Apr 3 2023, 9:58 AM

I guess we can check their Special:ListProperties/entity-schema if we have a list of Wikibases… (I don’t think there’s an API equivalent of that, actually)

Michael mentioned this in T333810: Create EntitySchema Datatype skeleton .Apr 3 2023, 10:28 AM
Michael added a comment.Apr 3 2023, 12:37 PM

We seem to get "lucky" insofar as using the OnWikibaseRepoDataTypes hook, we can just "override" the existing legacy Wikibase Datatype. So they are not conflicting and this task does not seem to be a blocker for us yet.

Though we should be wary of unexpected interactions, because the value of the setting that disables this Wikibase Legacy Datatype in production will also disable the new EntitySchema Datatype...

Arian_Bozorg moved this task from incoming to ready to go on the Wikidata board.Apr 5 2023, 10:27 AM
Sarai-WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Apr 18 2023, 8:39 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 18 2023, 11:12 AM
Lucas_Werkmeister_WMDE claimed this task.Apr 20 2023, 10:23 AM
Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Apr 20 2023, 10:47 AM

Change 910446 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove PHP code for entity-schema data type

https://gerrit.wikimedia.org/r/910446

gerritbot added a project: Patch-For-Review.Apr 20 2023, 10:47 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Apr 20 2023, 10:48 AM
gerritbot added a comment.Apr 24 2023, 7:58 AM

Change 910446 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove PHP code for entity-schema data type

https://gerrit.wikimedia.org/r/910446

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2023, 8:11 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Apr 24 2023, 8:56 AM
Lucas_Werkmeister_WMDE closed subtask T335122: Move EntitySchema data type messages from Wikibase.git to EntitySchema.git as Resolved.Apr 24 2023, 3:36 PM
ItamarWMDE closed this task as Resolved.Apr 25 2023, 10:18 AM
ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
ItamarWMDE subscribed.

This seems to be a clean cut, code search does not produce any results for the entity-schema data type apart from within the entity schema and some exceptions such as changelogs or test fixtures in MediaInfo. Thank you! \o/

karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.May 12 2023, 11:42 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL