| Lucas_Werkmeister_WMDE | |
| Apr 3 2023, 3:04 PM |
| F36938016: Screenshot from 2023-04-03 17-03-01.png | |
| Apr 3 2023, 3:04 PM |
| F36938012: image.png | |
| Apr 3 2023, 3:04 PM |
Compare https://query.wikidata.org/querybuilder/?uselang=ar (slightly outdated production deployment)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Arian_Bozorg | T328764 Implement custom LanguageSelector component | |||
| Resolved | HasanAkgun_WMDE | T329490 Query Builder: implement RTL functionality in LanguageSelector component | |||
| Resolved | Lucas_Werkmeister_WMDE | T333844 RTL layout broken in latest query builder code |
Change 905242 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Downgrade postcss-dir-pseudo-class + postcss-logical
It’s probably due to this part of the postcss-logical changelog, I’m guessing (emphasis added):
Updated: The plugin now requires block and inline direction to be configured (uses top-to-bottom and left-to-right respectively) and no longer introduces :dir (major).
Though this part also doesn’t sound great (we’re using the preserve option):
Removed support for preserve option. Changes are no longer preserved (major).
Change 905242 merged by jenkins-bot:
[wikidata/query-builder@master] Downgrade postcss-logical 6→5
Moving to tech verification for decision whether we want to do anything else here (ask postcss-logical to reintroduce :dir? switch to a different solution? idk) or not (close task).
At some point, we can hopefully use CSS logical properties natively, but that’s still a few years away I think.
First off, thanks for the fix, seems to me like we need to ensure not to accidentally update this again in the near future. As for the long run, I'd close this task now in favor of a new task to investigate and explore how we can migrate from 5 to 6 in Query builder (asking them to re-add it might be an option, but I think it could be a long shot). The new investigation ticket is: T334466.
Change 937065 had a related patch set uploaded (by Michael Große; author: Michael Große):
[wikidata/query-builder@master] Revert "Bump postcss-logical from 5.0.4 to 6.2.0"
Change 937066 had a related patch set uploaded (by Michael Große; author: Michael Große):
[wikidata/query-builder@master] Prevent automatic major updates of postcss-logical
Change 937065 merged by jenkins-bot:
[wikidata/query-builder@master] Revert "Bump postcss-logical from 5.0.4 to 6.2.0"
Change 937066 merged by jenkins-bot:
[wikidata/query-builder@master] Prevent automatic major updates of postcss-logical
Change 937070 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):
[wikidata/query-builder/deploy@production] Merging from 8d27b4ae9ac7d9d47b00e898c717e676b0e26e86
Change 937070 merged by Michael Große:
[wikidata/query-builder/deploy@production] Merging from 8d27b4ae9ac7d9d47b00e898c717e676b0e26e86