Page MenuHomePhabricator

Deploy Extension:SyntaxHighlight and related Shellbox container supporting Pygments 2.15.0 to Wikimedia production
Closed, ResolvedPublic

Description

Version 2.15.0 release of Pygments includes the new MediaWiki wikitext lexer from T29828: Add "wikitext" as language in Pygments. For Wikimedia wikis to benefit from this new functionality we need to update both SyntaxHighlight and the related Shellbox container that is used to run pygments in the Wikimedia production environment.

If we take this opportunity to also implement T320848: Install pygments in Shellbox container with pip, not a Debian package it should be easier to keep up with future MediaWiki lexer improvements which are likely to be requested once folks can start to use the new support for highlighting wikitext code snippets on the movement wikis.

Rollout plan

Next: T335460: New upstream release for Pygments (2.16.1)

Event Timeline

bd808 changed the task status from Open to In Progress.Apr 10 2023, 9:30 PM
bd808 claimed this task.
bd808 triaged this task as Medium priority.

Change 906127 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update Pygments to 2.15.0

https://gerrit.wikimedia.org/r/906127

Change 906127 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update Pygments to 2.15.0

https://gerrit.wikimedia.org/r/906127

Pygments 2.15.0 is now installed on the beta cluster wikis. It does look like the lang=json lexer is dealing with comments in this version: https://meta.wikimedia.beta.wmflabs.org/wiki/User:Bd808/Pygments2.15.0#JSON_+_comments

bd808 added a subscriber: Legoktm.

Change 914014 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/deployment-charts@master] shellbox: Bump to 2023-05-01-213815

https://gerrit.wikimedia.org/r/914014

Change 914014 merged by jenkins-bot:

[operations/deployment-charts@master] shellbox: Bump to 2023-05-01-213815

https://gerrit.wikimedia.org/r/914014

It's deployed now, but it's going to take an hour or two to work its way through all the caching layers, things might be a bit inconsistent until then.

https://www.mediawiki.org/wiki/Special:Version and others are now showing Pygments 2.15.1 in the "installed software" table.