Page MenuHomePhabricator
Create Task
Maniphest T334508

Fix subtitle wrap in mobile Preferences
Closed, ResolvedPublic
Actions

Description

Text has stopped wrapping for subtitles in the main menu of the new mobile Preferences design. It should wrap onto lower lines, as it did in an earlier implementation.

image.png (1×723 px, 84 KB)

Details

SubjectRepoBranchLines +/-
Fix preference description wrappingmediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF triaged this task as High priority.Apr 11 2023, 6:19 PM
Samwalton9-WMF created this task.
Samwalton9-WMF mentioned this in T308651: Make Special:Preferences available to mobile web users.
Scardenasmolinar changed the task status from Open to In Progress.Apr 11 2023, 6:24 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Apr 12 2023, 12:54 AM

Change 908006 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/core@master] Fix preference description wrapping

https://gerrit.wikimedia.org/r/908006

gerritbot added a project: Patch-For-Review.Apr 12 2023, 12:54 AM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Apr 12 2023, 12:59 AM

I have uploaded a fix:

Screen Shot 2023-04-11 at 18.55.42.png (899×420 px, 81 KB)

PatchDemoBot added a comment.Apr 12 2023, 1:18 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3f1694c35e/w

Samwalton9-WMF added a comment.Apr 12 2023, 11:12 AM

Tested the patchdemo with a few languages and it looks good!

jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Apr 13 2023, 3:10 PM
jsn.sherman subscribed.

Also looked good to me in testing and did not appear to impact vector at all.
+2ed

gerritbot added a comment.Apr 13 2023, 3:29 PM

Change 908006 merged by jenkins-bot:

[mediawiki/core@master] Fix preference description wrapping

https://gerrit.wikimedia.org/r/908006

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2023, 3:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 13 2023, 4:00 PM
Quiddity removed a project: User-notice.Apr 13 2023, 6:37 PM
Samwalton9-WMF added a comment.Apr 24 2023, 1:16 PM

Tested with a few languages and this is looking good to me now - text is now wrapping as intended again.

Samwalton9-WMF closed this task as Resolved.Apr 24 2023, 1:17 PM
PatchDemoBot added a comment.May 16 2023, 4:10 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3f1694c35e/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL