| • AGueyte | |
| Apr 12 2023, 1:53 PM |
| F36954865: T334597_SecurePoll_LoggedOutVoting.png | |
| Apr 17 2023, 10:03 PM |
| F36954863: T334597_SecurePoll_TempVoting.png | |
| Apr 17 2023, 10:03 PM |
Following the introduction of temporary users T326816, the following checks need to be updated to consider the case of temp accounts.
LocalAuth::autoLogin()
$user->isAnon becomes !$user->isNamed()
Prevents Anon and Temp users to vote
APIStrikeVote::execute()
!$user->isRegistered() becomes !$user->isNamed()
Prevents Anon and Temp user to vote
Acceptance criteria:
Temporary users cannot vote
Documentation:
https://office.wikimedia.org/wiki/Product/IP_Masking#How_should_I_update_my_code?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update User access to polls | mediawiki/extensions/SecurePoll | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In Progress | • Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 Update features for IP Masking | |||
| Open | Tchanders | T326869 Update TSP-owned products that may be affected by IP Masking | |||
| Resolved | • AGueyte | T331750 Investigate: Update SecurePoll for IP Masking | |||
| Resolved | • AGueyte | T334597 Update User access to polls on SecurePoll |
Change 908596 had a related patch set uploaded (by AGueyte; author: AGueyte):
[mediawiki/extensions/SecurePoll@master] Update User checks
Change 908596 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Update User access to polls
@AGueyte In the AC, you meant it's currently "You must log in to vote in this election" as seen in the screenshots below or was it supposed to say something else?
I have edited the description, and we have decided to keep the same error message for now!
So this is correct.
Ok sounds good, I'll move this to Done as stated from https://phabricator.wikimedia.org/T334597#8787720. Thanks for the work!
OS: macOS 13.3
Browser: Chrome 112, Firefox 111, Safari 16.4
Test site: http://localhost:8080/wiki/Special:SecurePoll