Noticing the display of IPs in http://localhost:8080/w/index.php?title=Special:SecurePollLog
I gave rights to all of my users to create Polls. An anon user was able to create a poll.
Nonetheless, the user wasn't able to vote in the poll as it's required to log in.

Therefore, the poll creation was logged and shown on Special:Log even to my unregistered user.

LocalAuth::autoLogin()
Uses $user->isAnon to prevent logged out users to vote.
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

APIStrikeVote::execute()
Uses !$user->isRegistered() to prevent logged out users to vote
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

Election::isAdmin()
Uses $user->getName() and returns true if the user is an admin of the current election.

SecurePollLogPager::formatRow()
Uses $user->getName() to create a link to the user's username

MakeMailingList::execute()
Uses $user->getName() for debug log lines

MakeMailingList::writeUser()
Uses $user->getName() to write a mailing list entry for the given user.

VotePage::logVote()
Uses IPutils to store the IP into table 'securepoll_votes' and column 'vote_ip'
'vote_ip' => IPUtils::toHex( $request->getIP() )
Concerns about keeping the voter's IP in DB

ListPager::formatValue()
Uses IPUtils to format the 'vote_ip' value from table 'securepoll_votes'
case 'vote_ip':

if ( $this->election->endDate < wfTimestamp( TS_MW, time() - ( $securePollKeepPrivateInfoDays * 24 * 60 * 60 ) ) ) {
	return '';
} else {
      return IPUtils::formatHex( $value );
}

DetailsPage::execute()
Uses IPUtils to format an IP
$vote_ip = IPUtils::formatHex( $row->vote_ip );

SecurePollLogPager::formatRow()
Uses ::userLink from class Linker to create a user link

StrikePager::formatValue()
Uses ::userLink from class Linker to create a user link

The voter's IP appears on the Details Page Special:SecurePoll/details/267
Visible to any "admins"
$this->election->isAdmin

@Niharika Do we know if Legal is happy with these?

VotePage::logVote()
Uses IPutils to store the IP into table 'securepoll_votes' and column 'vote_ip'
'vote_ip' => IPUtils::toHex( $request->getIP() )
Concerns about keeping the voter's IP in DB

(This is configured to be kept for 90 days by default - SecurePollKeepPrivateInfoDays)

In T331750#8771982, @AGueyte wrote:

The voter's IP appears on the Details Page Special:SecurePoll/details/267
Visible to any "admins"
$this->election->isAdmin

LocalAuth::autoLogin()
Uses $user->isAnon to prevent logged out users to vote.
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

APIStrikeVote::execute()
Uses !$user->isRegistered() to prevent logged out users to vote
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

These make sense to me, since @Niharika is following the principle of parity between anon and temp users to begin with. @AGueyte Would you be happy to file a task for this?

Absolutely, T334597 created and point estimated.

In T331750#8775991, @Tchanders wrote:

@Niharika Do we know if Legal is happy with these?

VotePage::logVote()
Uses IPutils to store the IP into table 'securepoll_votes' and column 'vote_ip'
'vote_ip' => IPUtils::toHex( $request->getIP() )
Concerns about keeping the voter's IP in DB

(This is configured to be kept for 90 days by default - SecurePollKeepPrivateInfoDays)

I haven't checked with them yet but if the data stays for 90 days only then I don't think it would be an issue. I can double check with Madi.
I think it is also worth thinking about whether there is a user case for storing the user's temp username in the table alongside the IP address. Typically the purpose for storing IPs is to weed out sockpuppets. So it may not be necessary to store temporary usernames. I will suggest we stick to this assumption unless @drochford or someone else suggests otherwise.

In T331750#8771982, @AGueyte wrote:

The voter's IP appears on the Details Page Special:SecurePoll/details/267
Visible to any "admins"
$this->election->isAdmin

This should be okay. Admins have the ability to view IPs under the new system. We can keep this as is.

In T331750#8776002, @Tchanders wrote:

LocalAuth::autoLogin()
Uses $user->isAnon to prevent logged out users to vote.
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

APIStrikeVote::execute()
Uses !$user->isRegistered() to prevent logged out users to vote
As for now, a temp account user can vote.
Suggestion: change to $user->isNamed

These make sense to me, since @Niharika is following the principle of parity between anon and temp users to begin with. @AGueyte Would you be happy to file a task for this?

+1 to what @Tchanders said.