Page MenuHomePhabricator
Create Task
Maniphest T334799

Editor doesn't load when editing CSS/JS/Lua on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Login to Wikipedia from a mobile device
  • Try to edit a css, js or module page

What happens?:
This message comes - ‘The editor will now load. If you still see this message after a few seconds, please reload the page.’ But no text editor comes along. Even if you go to edit through hotcat gadget from mobile, you have the same problem.

Screenshot_20230415-044314_1.png (1×720 px, 116 KB)

What should have happened instead?:
The mobile editor or the default editor should load.

Other information (browser name/version, screenshots, etc.):
Desktop Minerva does not have this problem.

Details

SubjectRepoBranchLines +/-
Mobile editor: Don't try to take over on non-wikitext contentmediawiki/extensions/MobileFrontendwmf/1.41.0-wmf.4+1 -1
Mobile editor: Don't try to take over on non-wikitext contentmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Yahya created this task.Apr 15 2023, 8:15 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 15 2023, 8:15 PM
Yahya added a project: Mobile.Apr 15 2023, 8:17 PM
Izno subscribed.Apr 15 2023, 8:35 PM

Same symptom as T334797: Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)

Nardog subscribed.Apr 16 2023, 1:46 AM
This comment was removed by Nardog.
Nardog added a comment.Apr 16 2023, 1:52 AM
In T334799#8783825, @Izno wrote:

Same symptom as T334797: Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)

Is it? In T334797, the problem isn't just that the mobile editor doesn't load but that submitting the edit form doesn't do anything, even with JavaScript off.

Izno added a comment.Apr 16 2023, 2:04 AM
In T334799#8783896, @Nardog wrote:
In T334799#8783825, @Izno wrote:

Same symptom as T334797: Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)

Is it? In T334797, the problem isn't just that the mobile editor doesn't load but that submitting the edit form doesn't do anything, even with JavaScript off.

The comment was based on

The editor will now load. If you still see this message after a few seconds, please reload the page.

Which is why it's framed as the same symptom. Could be entirely different causes.

Nardog renamed this task from The default MediaWiki editor is not loading on mobile to Editor doesn't load when editing CSS/JS/Lua on mobile.Apr 16 2023, 2:33 AM
Nardog updated the task description. (Show Details)
Nardog mentioned this in T334263: MobileFrontend editor loads on top of WikiEditor when following a link to action=edit.Apr 16 2023, 2:37 AM
Nardog updated the task description. (Show Details)Apr 16 2023, 3:15 AM
Nardog updated the task description. (Show Details)
MdsShakil subscribed.Apr 16 2023, 12:47 PM
matmarex added a project: Editing-team.Apr 17 2023, 2:28 AM
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.
Izno merged a task: T334789: unable to edit JavaScript/CSS in mobile version .Apr 17 2023, 5:32 AM
Izno added a subscriber: Edu.
matmarex claimed this task.Apr 17 2023, 5:18 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
gerritbot added a comment.Apr 17 2023, 5:18 PM

Change 909319 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over on non-wikitext content

https://gerrit.wikimedia.org/r/909319

gerritbot added a project: Patch-For-Review.Apr 17 2023, 5:18 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 17 2023, 5:24 PM
gerritbot added a comment.Apr 17 2023, 7:02 PM

Change 909319 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over on non-wikitext content

https://gerrit.wikimedia.org/r/909319

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 7:10 PM
gerritbot added a comment.Apr 17 2023, 7:11 PM

Change 909275 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over on non-wikitext content

https://gerrit.wikimedia.org/r/909275

gerritbot added a project: Patch-For-Review.Apr 17 2023, 7:11 PM
gerritbot added a comment.Apr 17 2023, 8:18 PM

Change 909275 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over on non-wikitext content

https://gerrit.wikimedia.org/r/909275

Stashbot mentioned this in T334794: Section=new (commentbox inputbox) is broken in MobileFrontEnd.Apr 17 2023, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:26:37Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]]

Stashbot mentioned this in T334877: Unable to publish changes to fr.m.wikipedia.org.Apr 17 2023, 8:26 PM
Stashbot mentioned this in T334797: Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long).

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:27:49Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 8:30 PM
Stashbot added a comment.Apr 17 2023, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:35:52Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] (duration: 09m 14s)

matmarex closed this task as Resolved.Apr 17 2023, 8:51 PM
matmarex added a project: Skipped QA.
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.

The mobile editor should be functional in this scenario again. Sorry about that.

Yahya added a comment.Apr 17 2023, 8:53 PM

It works. Thank you.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits