Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Apr 15 2023, 7:19 PM

Description

Steps to replicate the issue (include links if applicable):

Enable "Advanced mode" in Special:MobileOptions
Open the history of any page on a mobile site, e.g. testwiki:Wikipedia:Sandbox
Click the first "undo"
Click "Publish changes" (or "Show preview" or "Show changes" with the live preview off)

Alternatively:

Start editing a page on a mobile site with JavaScript off
Click "Publish changes", "Show preview", or "Show changes"

What happens?:
You are led to https://test.m.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=submit, which says "The editor will now load. If you still see this message after a few seconds, please reload the page." The "reload the page" part is linked to a URL like this:

https://test.wikipedia.org/w/index.php?mw-twocolconflict-js=1&wpUnicodeCheck=%E2%84%B3%F0%9D%92%B2%E2%99%A5%F0%9D%93%8A%F0%9D%93%83%F0%9D%92%BE%F0%9D%92%B8%E2%84%B4%F0%9D%92%B9%E2%84%AF&wpAntispam=&wikieditorUsed=yes&editingStatsId=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx&wpSection=&wpStarttime=20230415xxxxxx&wpEdittime=20230414210125&editRevId=564569&wpScrolltop=0&wpAutoSummary=d41d8cd98f00b204e9800998ecf8427e&oldid=0&parentRevId=564569&format=text%2Fx-wiki&model=wikitext&wpTextbox1=%3Cnoinclude%3E%7B%7BSandbox%7D%7D%3C%2Fnoinclude%3E%0D%0A%3D%3D+Please+start+your+testing+below+this+line+%3D%3D%0D%0A&wpSummary=&wpSave=Publish+changes&wpTemplateSandboxTemplate=Wikipedia%3ASandbox&wpTemplateSandboxPage=&wpEditToken=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx%2B%5C&mode=text&wpUltimateParam=1&action=submit&title=Wikipedia%3ASandbox&mfnoscript=1

If you click it, it goes back to the edit form (the desktop version if your UA is not mobile), or an error page saying "Request-URI Too Long" (or "The connection was reset" on Firefox) if the wikitext is large.

What should have happened instead?:
The buttons work as on the desktop site.

Other information (browser name/version, screenshots, etc.):
Reported here and here.

Details

	Subject	Repo	Branch	Lines +/-
	Mobile editor: Don't try to take over if the form has already been submitted	mediawiki/extensions/MobileFrontend	wmf/1.41.0-wmf.4	+4 -0
	Mobile editor: Don't try to take over if the form has already been submitted	mediawiki/extensions/MobileFrontend	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T334877: Unable to publish changes to fr.m.wikipedia.org
T334794: Section=new (commentbox inputbox) is broken in MobileFrontEnd
T334263: MobileFrontend editor loads on top of WikiEditor when following a link to action=edit
T334799: Editor doesn't load when editing CSS/JS/Lua on mobile
Mentioned Here: T334794: Section=new (commentbox inputbox) is broken in MobileFrontEnd
T334799: Editor doesn't load when editing CSS/JS/Lua on mobile
T334877: Unable to publish changes to fr.m.wikipedia.org

Event Timeline

Nardog created this task.Apr 15 2023, 7:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2023, 7:19 PM

Nardog added a project: Mobile.Apr 15 2023, 7:22 PM

Nardog updated the task description. (Show Details)

Izno mentioned this in T334799: Editor doesn't load when editing CSS/JS/Lua on mobile.Apr 15 2023, 8:35 PM

Yahya subscribed.Apr 15 2023, 8:37 PM

Nardog mentioned this in T334263: MobileFrontend editor loads on top of WikiEditor when following a link to action=edit.Apr 16 2023, 2:37 AM

Nardog updated the task description. (Show Details)Apr 16 2023, 2:49 AM

Nardog renamed this task from Impossible to undo any edit on mobile site (414 URI Too Long) to Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long).Apr 16 2023, 3:13 AM

jhsoby subscribed.Apr 16 2023, 4:10 AM

matmarex added a project: Editing-team.Apr 17 2023, 2:28 AM

matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.

Reported here on itwiki.

TheDJ subscribed.Apr 17 2023, 8:51 AM

Reported here on frwiki.

matmarex claimed this task.Apr 17 2023, 5:18 PM

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.

Change 909318 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909318

gerritbot added a project: Patch-For-Review.Apr 17 2023, 5:18 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 17 2023, 5:24 PM

Change 909318 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909318

Change 909274 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909274

Change 909274 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909274

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:26:37Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:27:49Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:35:52Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] (duration: 09m 14s)

The mobile editor should be functional in this scenario again. Sorry about that.

Thanks for the fix. Shouldn't this be in User-notice?

If it's a slow news week, sure. I'm not sure how to briefly describe the problem though. Some important editing workflows were unavailable on mobile because of this bug, but they are all kind of technical or niche (editing JS/CSS pages, editing with preloaded content, undoing edits) and difficult to describe in the Tech News style.

Some users may have already concluded that the ability to edit in the ways that were affected was simply removed, so I think we should tell them it's been fixed. We don't have to go into what those ways were and we can just say something along the lines of "From April xx to yy, you could not save certain kinds of edits on the mobile version of a wiki. This has been fixed."

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Apr 20 2023, 11:06 PM

Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Apr 27 2023, 11:23 PM

Maintenance_bot edited projects, added User-notice-archive; removed User-notice.May 7 2023, 11:30 PM

Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long)
Closed, ResolvedPublicBUG REPORT
Actions