"Visual" and "Wikitext" buttons in diffs in the Translate UI
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	jhsoby
	May 9 2023, 1:19 PM

Description

Similarly to T335915, diffs for changed messages in the Translate user interface now show a "Visual" and "Wikitext" button which should be unnecessary in that context.

Steps to replicate the issue (include links if applicable):

Navigate to Special:Translate in Translatewiki
Find a message in your language that has been updated in English (it will have "Outdated" icon next to the unexpanded message)
Expand such a message and click "Show differences" above the edit box.

Second case:

Edit a translatable page unit, or view a translatable page with pending changes in units.
Click on "Mark for translation" page link to get Special:PageTranslation?do=mark

What happens?:
The diff shown will have buttons for "Visual" and "Wikitext" diffs, even though the "Visual" one is unclickable.

Screenshot_20230509_151720.png (512×1 px, 53 KB)

What should have happened instead?:
No buttons should be shown.

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.41.0-alpha
Translate version 2023-04-26

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned In: T324759: Inline Diff: Add legend and tooltips
Mentioned Here: rEVED1810eca01b58: Localisation updates from https://translatewiki.net.
T324759: Inline Diff: Add legend and tooltips
T335915: Special:ManageMessageGroups shows Visuell/Wikitext buttons

Event Timeline

jhsoby created this task.May 9 2023, 1:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2023, 1:19 PM

Note: I have just added a temporary fix for this in Translatewiki's MediaWiki:Common.css, so in order to view this bug on that wiki without that fix, you'll need to append &safemode=1 to the Special:Translate URL.

NguoiDungKhongDinhDanh subscribed.May 9 2023, 9:20 PM

I think this issue might be fixed by this patch for T324759.

@Samwilson Testing the "canary" version of https://translatewiki.net (docs):

Switcher appears in multiple places on https://translatewiki.net/wiki/Special:ManageMessageGroups/non-mediawiki

Switcher appears in "plain text" on https://translatewiki.net/w/i.php?title=Special:Translate&group=mediawiki&language=fi&filter=fuzzy&action=translate&safemode=1

translatewiki_plain.png (993×1 px, 184 KB)

The version of VisualEditor on the "canary" is 0.1.2 (1810eca) 07:21, 11 May 2023.

dom_walden mentioned this in T324759: Inline Diff: Add legend and tooltips.May 11 2023, 10:40 AM

TheresNoTime added a project: Community-Tech (CommTech-Kanban).May 16 2023, 10:28 AM

Added Special:PageTranslation?do=mark venue, where buttons are displayed but not actionable.

Nikerabbit moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.May 22 2023, 11:10 AM

New implementation will cover the issue described in this task. Please see https://phabricator.wikimedia.org/T324759#8874993

Pols12 changed the task status from Invalid to Resolved.May 31 2023, 8:03 PM

MusikAnimal moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Apr 10 2024, 4:33 PM

	F36989805: Screenshot_20230509_151720.png
	May 9 2023, 1:19 PM

	F36992012: translatewiki.png
	May 11 2023, 8:58 AM

"Visual" and "Wikitext" buttons in diffs in the Translate UIClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

"Visual" and "Wikitext" buttons in diffs in the Translate UI
Closed, ResolvedPublicBUG REPORT
Actions