Page MenuHomePhabricator
Create Task
Maniphest T337710

Minerva should not hide TOC in no-JS mode
Closed, DuplicatePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What should have happened instead?:
Minerva should not hide TOC from its users if they do not have JavaScript enabled. Without collapsible sections on small resolutions, it is a pain to scroll through the page, and making it hidden by default is making the experience worse on big articles for people that for whatever reason do not have JS on mobile. TOC-hiding rule should be scoped to .client-js.

Details

SubjectRepoBranchLines +/-
Do not hide TOC from users without JavaScriptmediawiki/skins/MinervaNeuemaster+3 -1
Customize query in gerrit

Event Timeline

stjn created this task.May 30 2023, 5:32 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 30 2023, 5:32 AM
gerritbot added a comment.May 30 2023, 5:37 AM

Change 924162 had a related patch set uploaded (by Saint Johann; author: Saint Johann):

[mediawiki/skins/MinervaNeue@master] Do not hide TOC from users without JavaScript

https://gerrit.wikimedia.org/r/924162

gerritbot added a project: Patch-For-Review.May 30 2023, 5:37 AM
KSarabia-WMF added a project: Web-Team-Backlog.Jun 5 2023, 3:15 PM
LGoto triaged this task as Low priority.Jun 8 2023, 5:26 PM
LGoto edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Web-Team-Backlog.
LGoto moved this task from Incoming to Code Review on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 10 2023, 12:12 AM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5).Jun 12 2023, 5:18 PM
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.
Izno subscribed.Jun 28 2023, 2:42 AM
Jdlrobson assigned this task to ovasileva.Jul 13 2023, 5:22 PM
Jdlrobson subscribed.

Any guidance here on what to do about https://gerrit.wikimedia.org/r/924162 ?

Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.Jul 19 2023, 4:58 PM
Jdlrobson moved this task from Not ready to estimate to Incoming on the Web-Team-Backlog board.Mar 20 2024, 8:21 PM
Restricted Application added a subscriber: Base. · View Herald TranscriptMar 20 2024, 8:21 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 30 2024, 4:10 AM
Jdlrobson edited projects, added patch-welcome; removed good first task.May 4 2024, 6:16 PM
Jdlrobson reassigned this task from ovasileva to JScherer-WMF.May 23 2024, 11:30 PM
Jdlrobson added a subscriber: ovasileva.

This needs design input.

Jdlrobson closed this task as a duplicate of T147026: [Design, needs analysis] Provide control to change current section heading (Table of contents does not appear in Minerva at mobile resolution).Thu, May 30, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits