| GMikesell-WMF | |
| Jun 5 2023, 3:25 PM |
| F37120381: T338154_IPMasking_ShowIP_StarURL.png | |
| Jun 26 2023, 9:33 PM |
| F37120379: T338154_IPMasking_ShowIP_StarFreeText.png | |
| Jun 26 2023, 9:33 PM |
| F37111263: Screenshot 2023-06-21 at 12.41.46 PM.png | |
| Jun 21 2023, 3:12 PM |
| F37094321: T333367_IPMasking_ShowIP_Star_Newticket.png | |
| Jun 5 2023, 3:25 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
ShowIP appears
What should have happened instead?:
ShowIP should not appear
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Check temp user exists before adding IP lookup button to Special:Block | mediawiki/extensions/CheckUser | master | +51 -38 |
From what I'm seeing, in /temporaryaccount/SpecialBlock.js, the "mw.util.isTemporaryUser" returns true with blockTarget being: *, *Un, *Unr etc.
Therefore the script proceeds with the function onTargetChange( blockTarget ), revealing the ShowIP button in its div container.
But returning lastRequest null because of the unknown blockTarget...
Ideally, mw.util.isTemporaryUser shouldn't be returning true for usernames that aren't existing users.
In onTargetChange( blockTarget ) we could be verifying that the "mw.util.isTemporaryUser" is also an existing user.
I have tried a few things without success.
I am now wondering if it's really a bug or if we wanted this behavior in the first place.
As for now, the ShowIP button shows when the username is typed in just because the beginning of the username matches with the Temp user names pattern.
The issue is the Javascript function only checks if the username matches the pattern but not if the user exists, and "*Unregister" matches the pattern but isn't an actual temp user.
At the moment the ShowIP button shows but will return an error if clicked.
Leaving it as is for now.
Change 931942 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/CheckUser@master] Check temp user exists before adding IP lookup button to Special:Block
I think it's fine to do another lookup from the CheckUser script, in addition to the widget's lookup. It doubles the number of API requests, but I don't think this is a problem (it's equivalent to typing a name twice as long). If it becomes a problem for some reason, we can add debouncing.
The attached patch should solve the issue!
Thanks for this, I'm finding a funny bug: when I type in a temp user name, the ShowIP button shows correctly, but if I change the username, a second ShowIP button shows and etc.
Looking into how to prevent this from happening.
Change 931942 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Check temp user exists before adding IP lookup button to Special:Block
@AGueyte Looks like I'm not getting any Show IP anymore when I enter "*" as seen in the screenshots. The only thing is that in the URL when entering "*", I get a "There is no user by the name "*". Check your Spelling." warning. When entering it in the free text username, Show IP does not display but I also don't get a warning too. I'll move this to Done if that's fine. Thanks again!
Free Text in Username "*"
URL "*"
