| Esanders | |
| Jun 14 2023, 4:34 PM |
| F37134298: Screenshot 2023-07-10 at 03.48.24.png | |
| Jul 10 2023, 7:24 PM |
| F37134300: Screenshot 2023-07-10 at 03.48.56.png | |
| Jul 10 2023, 7:24 PM |
| F37103641: image.png | |
| Jun 14 2023, 4:38 PM |
| F37103639: image.png | |
| Jun 14 2023, 4:34 PM |
In the VE toolbar, the help popup contains 3 "tools", but they are implemented as buttons, even though one already exists as a tool in core.
By not using tools, we miss out on accessibility features, such as showing the keyboard shortcut, and the tools appearing in the toolbar search.
As the help tool also contains a header and footer we will need to extend ListToolGroup to support this.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Convert MWPopupTool into MWHelpListToolGroup | mediawiki/extensions/VisualEditor | master | +273 -214 |
Change 928073 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Convert MWPopupTool into MWHelpListToolGroup
Separately, I'm not sure if we need the header message anymore ("If you encounter any technical issues..."). It was probably created when VE was in beta to encourage bug reporting.
Change 928073 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Convert MWPopupTool into MWHelpListToolGroup
