Create a backend for adding questions to an event
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jun 22 2023, 3:22 PM

Description

Acceptance criteria

As an organizer
- When I enable an event registration
- All the available participant questions should be added to my event, for participants to answer
- And this list of enabled questions should be persisted
As a participant
- When I register for an event (via the dialog OR the special page)
- I am shown the list of questions enabled for the event

Details

	Subject	Repo	Branch	Lines +/-
	SpecialRegisterForEvent: only show questions enabled for that event	mediawiki/extensions/CampaignEvents	master	+17 -7
	Create a backend for adding questions to an event	mediawiki/extensions/CampaignEvents	master	+380 -20

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T341392 Mark the CampaignEvents extension as stable
Resolved	cmelo	T321822 [EPIC] Participant Questions - MVP
Resolved	Daimona	T340125 Create a backend for adding questions to an event

Event Timeline

Daimona created this task.Jun 22 2023, 3:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2023, 3:22 PM

Daimona moved this task from Needs Input / Design in progress to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jun 22 2023, 3:22 PM

Daimona mentioned this in T336857: [IMPLEMENTATION] Back end: create the database layers for the tables: ce_question_answers, ce_question_aggregation,ce_event_questions.

Daimona claimed this task.Jun 22 2023, 4:45 PM

Daimona moved this task from Ready for development to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Change 932331 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Create a backend for adding questions to an event

https://gerrit.wikimedia.org/r/932331

gerritbot added a project: Patch-For-Review.Jun 22 2023, 8:51 PM

Change 932335 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialRegisterForEvent: only show questions enabled for that event

https://gerrit.wikimedia.org/r/932335

Daimona moved this task from In Progress 💻 to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jun 22 2023, 9:11 PM

Change 932331 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create a backend for adding questions to an event

https://gerrit.wikimedia.org/r/932331

Change 932335 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialRegisterForEvent: only show questions enabled for that event

https://gerrit.wikimedia.org/r/932335

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2023, 6:10 PM

For this AC:

When I register for an event (via the dialog OR the special page)

noting that the dialog version is still in review, so it cannot be tested until T335809 is resolved.

Daimona added a parent task: T321822: [EPIC] Participant Questions - MVP.Jul 12 2023, 2:37 PM

In T340125#8982692, @Daimona wrote:

For this AC:

When I register for an event (via the dialog OR the special page)

noting that the dialog version is still in review, so it cannot be tested until T335809 is resolved.

The relevant parts of T335809 were implemented, so this is ready for QA now.

Daimona updated the task description. (Show Details)Jul 12 2023, 9:22 PM

As an organizer
When I enable or edit an event registration
All the available participant questions should be added to my event, for participants to answer
✅ And this list of enabled questions should be persisted

✅ Enabling event registration adds participant questions to the event:

Screen Recording 2023-07-13 at 3.26.23 PM.gif (1×3 px, 1 MB)

✅ participant questions persist when editing an event:

Screen Recording 2023-07-13 at 3.34.51 PM.gif (1×3 px, 2 MB)

As a participant
When I register for an event (via the dialog OR the special page)
✅ I am shown the list of questions enabled for the event

✅ Event dialog:

Screenshot 2023-07-13 at 3.37.45 PM.png (1×1 px, 421 KB)

✅ Special:RegisterForEvent:

Screenshot 2023-07-13 at 3.38.36 PM.png (1×1 px, 385 KB)

@Daimona For this AC:
As an organizer
When I enable or edit an event registration
All the available participant questions should be added to my event, for participants to answer

If I edit an event that previously did not have participant questions on it, when editing an event, the participant questions are not added to the event:

edit event registration.gif (1×3 px, 3 MB)

Should the AC be When I enable an event registration or edit an event registration that has already had participant questions added instead of When I enable or edit an event registration or should actually be as is written that if any event is edited, then participant questions should be added to the event?

In T340125#9014156, @vaughnwalters wrote:

@Daimona For this AC:
As an organizer
When I enable or edit an event registration
All the available participant questions should be added to my event, for participants to answer

If I edit an event that previously did not have participant questions on it, when editing an event, the participant questions are not added to the event:

Should the AC be When I enable an event registration or edit an event registration that has already had participant questions added instead of When I enable or edit an event registration or should actually be as is written that if any event is edited, then participant questions should be added to the event?

Good point. We really only add questions to new events. We might do that when editing, but that might potentially be confusing. I think this isn't something for which we had precise requirements. In practice, the current code results in no questions being added to events created before the participant questions feature was enabled, which I think is less surprising. I will update the AC.

Daimona updated the task description. (Show Details)Jul 14 2023, 12:49 AM

In T340125#9014433, @Daimona wrote:

In T340125#9014156, @vaughnwalters wrote:

@Daimona For this AC:
As an organizer
When I enable or edit an event registration
All the available participant questions should be added to my event, for participants to answer

If I edit an event that previously did not have participant questions on it, when editing an event, the participant questions are not added to the event:

Should the AC be When I enable an event registration or edit an event registration that has already had participant questions added instead of When I enable or edit an event registration or should actually be as is written that if any event is edited, then participant questions should be added to the event?

Good point. We really only add questions to new events. We might do that when editing, but that might potentially be confusing. I think this isn't something for which we had precise requirements. In practice, the current code results in no questions being added to events created before the participant questions feature was enabled, which I think is less surprising. I will update the AC.

Okay sounds good. With that update, all AC is met and sending this to product sign off.

This has been implemented, as per the QA notes, so I'm marking this as Done.

	F37138323: Screenshot 2023-07-13 at 3.38.36 PM.png
	Jul 13 2023, 8:44 PM

	F37138321: Screenshot 2023-07-13 at 3.37.45 PM.png
	Jul 13 2023, 8:44 PM

	F37138319: Screen Recording 2023-07-13 at 3.34.51 PM.gif
	Jul 13 2023, 8:44 PM

	F37138312: Screen Recording 2023-07-13 at 3.26.23 PM.gif
	Jul 13 2023, 8:44 PM

Create a backend for adding questions to an eventClosed, ResolvedPublicActions