| Dreamy_Jazz | |
| Jul 3 2023, 2:33 PM |
| F37818039: 2023-09-27_12-24-25.png | |
| Sep 27 2023, 7:36 PM |
| F37657179: Log-line.png | |
| Sep 15 2023, 11:52 AM |
| F37127004: image.png | |
| Jul 3 2023, 2:49 PM |
| F37095593: image.png | |
| Jul 3 2023, 2:33 PM |
Client hint data should be displayed in Special:CheckUser's 'Get edits' mode. An example of the results from this mode is shown below.
Following T345764: Design UI for displaying client hint data, the design decisions were made to use the following for the 'Get edits' lines:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | https://phabricator.wikimedia.org/T340993 here |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| clienthints: Display data in Special:CheckUser 'get edits' | mediawiki/extensions/CheckUser | master | +491 -27 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kostajh | T257893 [EPIC] Support User-Agent Client Hints header in CheckUser | |||
| Resolved | Dreamy_Jazz | T337942 Display client hint data | |||
| Resolved | Dreamy_Jazz | T340993 Display client hint data in Special:CheckUser's 'Get edits' mode result lines | |||
| Resolved | Dreamy_Jazz | T340996 Implement system to convert client hint data to a string representation | |||
| Resolved | Dreamy_Jazz | T341932 Create service to return Client Hints data from the database | |||
| Resolved | Dreamy_Jazz | T328995 Enable read new support in Special:CheckUser's 'Get edits' mode | |||
| Resolved | BUG REPORT | Dreamy_Jazz | T347773 Log action text shown when reading new does not respect the deleted status of the log |
To display client hints data appropriately, the new query builder needs to be used. This is so that the client hints data can be selected for log events. Without the use of the query builder, the client hint data will only be displayable for edits.
Change 956457 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] clienthints: Display data in Special:CheckUser 'get edits'
Change 956457 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] clienthints: Display data in Special:CheckUser 'get edits'
Suggested QA steps:
Expected behaviour to verify the acceptance criteria: Ensure that the edit you made using Google Chrome, which should be shown at the top of the results list, has Client Hints data displayed. The displayed Client Hints data should be below the "User-Agent string" and IP address, in a similar way to the first design in F37657179.
@Dreamy_Jazz Client Hints data are displayed in results and are similar to the first design mentioned in the screenshots below. The only difference is the prefix names that changed "Browsers" to "Brand" which has been discussed and is fine since it aligns with how it's described in the client hint spec. Also, the order is fine. I will move this to Done. Thanks for all your work!
Status: ✅PASS
Environment: Local: 1.41.0-alpha (62bb717) 18:16, 27 September 2023. Checkuser: 2.5 (d121f43) 16:23, 27 September 2023
OS: macOS Ventura 13.5.2
Browser: Chrome 117
Device: MBA M2
Emulated Device:: N/A
Test Links:
http://localhost:8080/wiki/Beer
http://localhost:8080/wiki/Special:CheckUser
✅AC1: https://phabricator.wikimedia.org/T340993#9197595
| Design Compare | Latest Patch |
|  |