Page MenuHomePhabricator

Create service to return Client Hints data from the database
Closed, ResolvedPublic

Description

A service needs to be created that can return associated client hints data from the database for given reference IDs over multiple tables. This service will be used to collect the data from the DBs to display in the CheckUser interfaces for privileged users.

Acceptance criteria:
  • Create a service that collects and returns this data
  • Create a result class to hold this data (similar to ClientHintReferenceIds)
  • Test that the service works with phpunit tests as it won't be used until later patches are written
  • Make patches to test that the service fulfils the need of the interfaces by getting them to display client hint data

Event Timeline

Change 938383 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] clienthints: Add UserAgentClientHintsLookup service

https://gerrit.wikimedia.org/r/938383

Change 938383 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Add UserAgentClientHintsLookup service

https://gerrit.wikimedia.org/r/938383

I would suggest that no QA would be needed for this patch as this service is currently unused. If this method is followed, this service would be indirectly tested by QA through the tasks that display this data (such as T340991, T340993 etc.).