Page MenuHomePhabricator

Creation of a new user right:Validator on Punjabi Wikisource
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Punjabi community would like a new user right on Punjabi Wikisource to grant the right to change the status of a page from Proofread to Validated to only these individuals along with the admins. Admins should be able to give this right to other users after they demonstrate a good level of understanding of proofreading.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Many users are incorrectly marking pages as Validated and that gives a wrong impression that so many pages have been validated but actually it is a misrepresentation.

Benefits (why should this be implemented?):
This will help the community to streamline the process of proofreading and validating on the project.

Community endorsement
Scriptorium on Punjabi Wikisource

Event Timeline

@satdeep_gill Setting project to Wikimedia-Site-requests, as this request is about settings / configuration of a Wikimedia website. In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such site configuration changes. Thanks!

Hi @satdeep_gill! I'm sorry, but the request is not very clear for me :( First of all, I suppose that with "Validator" you mean "autopatroller", but I need to be sure before doing a change, so I need the name of the group. Then, which user rights does this usergroup need (only autopatrol?)? Sysop can add users to this group, but who can remove user from this group? Also, I don't understand what the following means: "Many users are incorrectly marking pages as Validated and that gives a wrong impression that so many pages have been validated but actually it is a misrepresentation". Thanks for the understanding and for your patience!

Hi @satdeep_gill! I'm sorry, but the request is not very clear for me :( First of all, I suppose that with "Validator" you mean "autopatroller", but I need to be sure before doing a change, so I need the name of the group. Then, which user rights does this usergroup need (only autopatrol?)? Sysop can add users to this group, but who can remove user from this group? Also, I don't understand what the following means: "Many users are incorrectly marking pages as Validated and that gives a wrong impression that so many pages have been validated but actually it is a misrepresentation". Thanks for the understanding and for your patience!

@Superpes15 they meant on Wikisource you have option to validate the proofread page.

Which i assume is not possible, @Samwilson can you confirm if it is possible to restrict page validation to certain usergroup.

Adding back All-and-every-Wikisource for this feature request to visible for Wikisource related tasks

@Anoop Thank you adding the context. I see that validating a page is restricted unless someone has already proofread it. Similarly, there should be a way to restrict it for regular contributors.

The existing rights in ProofreadPage are pagequality (for making any change to the quality level of a page) and pagequality-admin (for making a change even if you're not normally allowed, e.g. moving to validated from proofread if you were also the user to move it to proofread).

It sounds like we need to add pagequality-validate and set it as enabled by default for the user group, so that it can then be removed from that group for pawikisource. The code in question is in PageLevel::isChangeAllowed().

The existing rights in ProofreadPage are pagequality (for making any change to the quality level of a page) and pagequality-admin (for making a change even if you're not normally allowed, e.g. moving to validated from proofread if you were also the user to move it to proofread).

It sounds like we need to add pagequality-validate and set it as enabled by default for the user group, so that it can then be removed from that group for pawikisource. The code in question is in PageLevel::isChangeAllowed().

@Samwilson Is there any scenario where a user does not/should not have the pagequality right ? In that case, we might be able to repurpose that to restrict the validation of a page ?

That's a good point, but it looks like it's used to give anon users permission to change page quality on dewikisource (T29516) and plwikisource (T212478). I think those are Wikisources that protect pages once they're validated.

@Anoop: I don't understand T341428#9017205. How does this affect every Wikisource when this ticket is about Punjabi only?

@Anoop: I don't understand T341428#9017205. How does this affect every Wikisource when this ticket is about Punjabi only?

@Aklapper The implementation of the task will affect ProofreadPage and potentially introduce a new right across All-and-every-Wikisource

Change 938451 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/ProofreadPage@master] Require `pagequality-validate` userright to validate pages

https://gerrit.wikimedia.org/r/938451

Change 938451 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Require `pagequality-validate` userright to validate pages

https://gerrit.wikimedia.org/r/938451

@Soda Thank you so much for your work on this. Would admins (sysops) be able to be give this right to people?

@Soda Thank you so much for your work on this. Would admins (sysops) be able to be give this right to people?

There is still some work left wrt to configuration changes before the right can be given by admins/sysops on-wiki, however, those need to be done next week (say Thursday) since MediaWiki 1.41.0-wmf.19 (the version of Mediawiki containing this change) will be deployed then.

@satdeep_gill Are admins expected to have this right be default ?

Change 941928 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[operations/mediawiki-config@master] Add validator userright for pawikisource

https://gerrit.wikimedia.org/r/941928

This comment was removed by SGill.

@Soda Yes, admins should have this right by default and have the ability to make other people validators.

Change 941928 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[operations/mediawiki-config@master] Add validator userright for pawikisource

https://gerrit.wikimedia.org/r/941928

Change 941928 merged by jenkins-bot:

[operations/mediawiki-config@master] Add validator userright for pawikisource

https://gerrit.wikimedia.org/r/941928

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:08:42Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:941928|Add validator userright for pawikisource (T341428)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:10:20Z] <dancy@deploy1002> dancy and soda: Backport for [[gerrit:941928|Add validator userright for pawikisource (T341428)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:29:31Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:941928|Add validator userright for pawikisource (T341428)]] (duration: 20m 49s)

Soda claimed this task.