Page MenuHomePhabricator
Create Task
Maniphest T341840

CentralAuthExtensionJsonTest fails if SecurePoll is not installed
Closed, ResolvedPublic
Actions

Description

If you enable CentralAuth but don't have SecurePoll installed and run CentralAuthExtensionJsonTest, it will fail:

1) CentralAuthExtensionJsonTest::testHookHandler with data set #11 ('securepoll')
Error: Interface "MediaWiki\Extension\SecurePoll\Hooks\SecurePoll_GetUserParamsHook" not found

/var/www/html/w/extensions/CentralAuth/includes/Hooks/Handlers/SecurePollHookHandler.php:30
/var/www/html/w/includes/AutoLoader.php:222
/var/www/html/w/vendor/wikimedia/object-factory/src/ObjectFactory.php:240
/var/www/html/w/vendor/wikimedia/object-factory/src/ObjectFactory.php:149
/var/www/html/w/tests/phpunit/integration/includes/ExtensionJsonTestBase.php:97
/var/www/html/w/tests/phpunit/MediaWikiIntegrationTestCase.php:518

This is blocking merges to the integration/quibble repository.

Details

SubjectRepoBranchLines +/-
tests: Skip SecurePoll hook handler when extension is not loadedmediawiki/extensions/CentralAuthmaster+13 -5
jjb: Update quibble jobs to images with Quibble 1.5.5integration/configmaster+25 -25
Docker [quibble] Upgrade Quibble to 1.5.5integration/configmaster+63 -1
release: Quibble 1.5.5integration/quibblemaster+23 -2
utils: fullrun-extensions: Clone SecurePollintegration/quibblemaster+1 -1
Disable CentralAuthExtensionJsonTestmediawiki/extensions/CentralAuthmaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Jul 14 2023, 1:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2023, 1:24 AM
Daimona added a comment.Jul 14 2023, 1:30 AM

And it looks like this can be reproduced with pretty much any extension that handles hooks from another extension using the "new" hook system. For instance, AbuseFilterExtensionJsonTest fails the same way if CheckUser is not installed.

ihurbain subscribed.Jul 14 2023, 9:38 AM
Daimona mentioned this in T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.Jul 14 2023, 1:19 PM
Daimona added a project: MediaWiki-Core-Tests.

This is actually caused by a core test class, ExtensionJsonTestBase. I'm not sure how it should handle this case. Maybe the test could skip validation of hook handlers, I don't know...

• Lucas_Werkmeister_WMDE subscribed.Jul 14 2023, 1:25 PM

This is blocking merges to the integration/quibble repository.

Is Quibble installing CentralAuth without SecurePoll? At least in the usual CI config, CentralAuth is supposed to pull in SecurePoll (see also T341556, especially T341556#9004491 and the next comment).

Daimona added a comment.Jul 14 2023, 2:05 PM
In T341840#9015436, @Lucas_Werkmeister_WMDE wrote:

This is blocking merges to the integration/quibble repository.

Is Quibble installing CentralAuth without SecurePoll? At least in the usual CI config, CentralAuth is supposed to pull in SecurePoll (see also T341556, especially T341556#9004491 and the next comment).

I think this is the case, yes... I'm going to temporarily disable the test to unblock CI (T90875#9015487), but I'll leave this task open.

gerritbot added a comment.Jul 14 2023, 2:07 PM

Change 938245 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CentralAuth@master] Disable CentralAuthExtensionJsonTest

https://gerrit.wikimedia.org/r/938245

gerritbot added a project: Patch-For-Review.Jul 14 2023, 2:07 PM
gerritbot added a comment.Jul 14 2023, 2:46 PM

Change 938254 had a related patch set uploaded (by Majavah; author: Majavah):

[integration/quibble@master] utils: fullrun-extensions: Clone SecurePoll

https://gerrit.wikimedia.org/r/938254

taavi subscribed.Jul 14 2023, 2:47 PM

Apparently Quibble has its own list of repeos to clone that doesn't follow the normal dependencies system. The above patch adds SecurePoll to that list.

gerritbot added a comment.Jul 14 2023, 3:11 PM

Change 938245 abandoned by Daimona Eaytoy:

[mediawiki/extensions/CentralAuth@master] Disable CentralAuthExtensionJsonTest

Reason:

Fixing quibble instead

https://gerrit.wikimedia.org/r/938245

gerritbot added a comment.Jul 14 2023, 3:41 PM

Change 938254 merged by Majavah:

[integration/quibble@master] utils: fullrun-extensions: Clone SecurePoll

https://gerrit.wikimedia.org/r/938254

Daimona removed a project: Patch-For-Review.Jul 14 2023, 3:50 PM

Quibble is fixed now, but leaving this open because the bug remains.

Jdforrester-WMF subscribed.Jul 14 2023, 5:05 PM
In T341840#9016135, @Daimona wrote:

Quibble is fixed now, but leaving this open because the bug remains.

Quibble won't be fixed in practice until someone does the release, builds the new images, and switches all of CI over to them. I can help out a bit; normally this is a @hashar-only activity, but given it's a holiday…

Daimona added a comment.Jul 14 2023, 5:06 PM
In T341840#9016430, @Jdforrester-WMF wrote:
In T341840#9016135, @Daimona wrote:

Quibble is fixed now, but leaving this open because the bug remains.

Quibble won't be fixed in practice until someone does the release, builds the new images, and switches all of CI over to them. I can help out a bit; normally this is a @hashar-only activity, but given it's a holiday…

It's just quibble's own CI that was failing, not quibble itself, AIUI. That said, there are two quibble patches (r938010, r938012) that could definitely use some love :)

Jdforrester-WMF added a comment.Jul 14 2023, 5:13 PM
In T341840#9016438, @Daimona wrote:
In T341840#9016430, @Jdforrester-WMF wrote:
In T341840#9016135, @Daimona wrote:

Quibble is fixed now, but leaving this open because the bug remains.

Quibble won't be fixed in practice until someone does the release, builds the new images, and switches all of CI over to them. I can help out a bit; normally this is a @hashar-only activity, but given it's a holiday…

It's just quibble's own CI that was failing, not quibble itself, AIUI. That said, there are two quibble patches (r938010, r938012) that could definitely use some love :)

Ah, sorry, got lost between tasks and thought this was that one. :-(

gerritbot added a comment.Jul 14 2023, 6:03 PM

Change 938289 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/quibble@master] release: Quibble 1.5.5

https://gerrit.wikimedia.org/r/938289

gerritbot added a project: Patch-For-Review.Jul 14 2023, 6:03 PM
gerritbot added a comment.Jul 14 2023, 6:33 PM

Change 938289 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.5.5

https://gerrit.wikimedia.org/r/938289

Stashbot added a comment.Jul 14 2023, 6:45 PM

Mentioned in SAL (#wikimedia-releng) [2023-07-14T18:45:00Z] <James_F> Tag Quibble 1.5.5 @ 85009d62de # T90875 T227900 T341840

Stashbot mentioned this in T227900: Phase out usage of tests/phpunit/suite.xml.Jul 14 2023, 6:45 PM
gerritbot added a comment.Jul 14 2023, 6:49 PM

Change 938296 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Docker [quibble] Upgrade Quibble to 1.5.5

https://gerrit.wikimedia.org/r/938296

gerritbot added a comment.Jul 14 2023, 6:55 PM

Change 938296 merged by jenkins-bot:

[integration/config@master] Docker [quibble] Upgrade Quibble to 1.5.5

https://gerrit.wikimedia.org/r/938296

Stashbot added a comment.Jul 14 2023, 6:56 PM

Mentioned in SAL (#wikimedia-releng) [2023-07-14T18:56:23Z] <James_F> Docker: Building and publishing quibble images # T90875 T227900 T341840

gerritbot added a comment.Jul 14 2023, 7:04 PM

Change 938298 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Update quibble jobs to images with Quibble 1.5.5

https://gerrit.wikimedia.org/r/938298

gerritbot added a comment.Sep 28 2023, 10:06 PM

Change 961903 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] tests: Skip SecurePoll hook handler when extension is not loaded

https://gerrit.wikimedia.org/r/961903

Umherirrender added a parent task: T347639: Research a way for the ExtensionJsonTestBase tests to autodetect missing extension and skip the HookHandlers validation in this case.Sep 28 2023, 10:20 PM
gerritbot added a comment.Sep 30 2023, 9:20 AM

Change 961903 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Skip SecurePoll hook handler when extension is not loaded

https://gerrit.wikimedia.org/r/961903

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 30 2023, 10:00 AM
Pppery removed a project: Patch-For-Review.Dec 10 2023, 8:23 PM
Pppery subscribed.

Anything left to do here?

• Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 12 2023, 10:23 AM

I don’t think so. Boldly resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL