Page MenuHomePhabricator

Filter menu items have too much padding
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Jul 17 2023, 9:08 PM
Referenced Files
F37160539: image.png
Aug 2 2023, 4:41 PM
F37160541: image.png
Aug 2 2023, 4:41 PM
F37141737: image.png
Jul 17 2023, 9:08 PM
F37141739: image.png
Jul 17 2023, 9:08 PM


Steps to replicate the issue (include links if applicable):

What happens?:

image.png (907×1 px, 129 KB)

What should have happened instead?:

image.png (541×1 px, 97 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • advantage of lots of padding: tablet/smartphone users can more easily touch icons
  • advantage of little padding: doesn't waste screen real estate for desktop users
  • I think most NPPs use desktop, so it makes sense to cater to desktop users here, in my opinion

Event Timeline

Change 944958 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] New Pages Feed: reduce filter menu padding

jsn.sherman moved this task from Vue migration bugs to Code Review on the PageTriage board.
jsn.sherman subscribed.

Okay, I've taken a swing a this, and I think I've done the best I can do with reasonable effort at this time.


image.png (1×2 px, 358 KB)

image.png (1×2 px, 372 KB)

Change 944958 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] New Pages Feed: increase filter menu density

jsn.sherman changed the task status from Open to In Progress.Aug 3 2023, 3:54 AM

Big improvement. I'm super happy with that. Thanks for taking the time.

jsn.sherman moved this task from Waiting for enwiki deploy to Done on the PageTriage board.

No problem!