Page MenuHomePhabricator
Create Task
Maniphest T342434

Special:NewPagesFeed and Page Curation toolbar must share and persist state
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @Hey_man_im_josh on Discord

Steps to replicate the issue (include links if applicable):

What happens?:

  • no redirects are shown

What should have happened instead?:

  • redirects should be shown

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • should investigate how the old Special:NewPagesFeed saves this (LocalStorage?) and use the exact same technique, because both Special:NewPagesFeed and the Page Curation toolbar have code that depends on this
  • please note comment below about the "Next" button in the page curation toolbar loading the wrong articles

Acceptance criteria

  • Special:NewPagesFeed remembers filters on page refresh
  • Page Curation toolbar "next" button works as expected (e.g. if you filter by redirects only, then visit an unpatrolled redirect, hitting "next" on the toolbar should load a redirect and not an article)

Details

SubjectRepoBranchLines +/-
Vue.js Curation Toolbar containermediawiki/extensions/PageTriagemaster+818 -21
new ui stores settings the same way as old uimediawiki/extensions/PageTriagemaster+230 -99
revert "mv settings store to ext.pageTriage.util"mediawiki/extensions/PageTriagemaster+15 -14
Persistent state followupmediawiki/extensions/PageTriagemaster+28 -12
Settings store should persist statemediawiki/extensions/PageTriagemaster+18 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedSamwalton9-WMFT343329 Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience
 ResolvedBUG REPORTjsn.shermanT342434 Special:NewPagesFeed and Page Curation toolbar must share and persist state
 ResolvedSpikejsn.shermanT324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo
 DuplicateNoneT339386 Make sure recent patches make it into the Vue Special:NewPagesFeed rewrite
 ResolvedBUG REPORTScardenasmolinarT342048 Icons have no color in vector 2010 or monobook
 ResolvedBUG REPORTScardenasmolinarT342053 Progress bar needs more top and bottom padding
 ResolvedBUG REPORTScardenasmolinarT342054 mw.msg( 'lastAfcActionLabel' ) displays msg name instead of msg value
 ResolvedBUG REPORTScardenasmolinarT342055 Articles for Creation filter doesn't look good at high zooms (right column too wide)
 ResolvedBUG REPORTScardenasmolinarT342056 "More" button that displays during infinite scroll appears to be unused/unneeded
 ResolvedSpikejsn.shermanT342057 SPIKE: Check if Vue Special:NewPagesFeed has feature parity with existing Special:NewPagesFeed [4hrs]
 ResolvedMPGuy2824T342323 Improve PageTriage module folder names
 ResolvedBUG REPORTScardenasmolinarT342423 Special:NewPagesFeed footer flashes "-1" until the API query completes
 ResolvedBUG REPORTjsn.shermanT342435 mwe-vue-pt-info-pane has too much padding
 ResolvedBUG REPORTScardenasmolinarT343126 Space missing between "Oldest" and "X pages in your filtered list"
 ResolvedBUG REPORTScardenasmolinarT343128 Footer should not have top shadow if it is not floating
 ResolvedBUG REPORTjsn.shermanT343259 Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in
 ResolvedBUG REPORTjsn.shermanT342050 Filter menu items have too much padding
 ResolvedBUG REPORTjsn.shermanT342049 Filter menu radio buttons are too big
 ResolvedBUG REPORTjsn.shermanT342440 Special:NewPagesFeed is missing pagetriage-welcome message at the top
 ResolvedBUG REPORTjsn.shermanT342051 New iconset does not match Page Curation toolbar and is (arguably) less aesthetic
 ResolvedScardenasmolinarT344992 pagetriage-js-required message is missing when Javascript is not enabled
 ResolvedSpikeScardenasmolinarT345153 Fix Date range alignment issues in filter menu in some browsers

Event Timeline

Novem_Linguae created this task.Jul 21 2023, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2023, 1:55 PM
Novem_Linguae added a parent task: T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.Jul 21 2023, 1:55 PM
Novem_Linguae moved this task from Backlog to Vue migration bugs on the PageTriage board.
MPGuy2824 subscribed.Jul 22 2023, 5:38 AM

This also causes the next button in the toolbar to not work as one would expect.

Novem_Linguae renamed this task from Special:NewPagesFeed forgets filter settings on page refresh to Special:NewPagesFeed forgets filter settings on page refresh, and Page Curation toolbar "next" button loads wrong articles.Jul 23 2023, 7:47 AM
Novem_Linguae updated the task description. (Show Details)
jsn.sherman subscribed.EditedJul 31 2023, 4:35 PM

Yeah, this is connected to the new toolbar implementation. To fully resolve this, I need to:

  • move the state store to the utility module
  • make it persist to local storage
  • replace the toolbar itself with Vue and populate existing tools from the state store in T340130: Implement Curation Toolbar container in Vue.js (I'll need to slightly change what ui_version=1 does there)
jsn.sherman renamed this task from Special:NewPagesFeed forgets filter settings on page refresh, and Page Curation toolbar "next" button loads wrong articles to Special:NewPagesFeed and Page Curation toolbar must share and persist state.Jul 31 2023, 4:37 PM
jsn.sherman claimed this task.
jsn.sherman removed a parent task: T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.
jsn.sherman added subtasks: T340117: PageTriage: Implement Curation Toolbar in Vue.js, T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.
jsn.sherman added a subscriber: Moderator-Tools-Team (Kanban).
jsn.sherman changed the task status from Open to In Progress.Jul 31 2023, 4:40 PM
jsn.sherman added a project: Moderator-Tools-Team (Kanban).
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
jsn.sherman removed a subscriber: Moderator-Tools-Team (Kanban).
gerritbot added a comment.Jul 31 2023, 8:30 PM

Change 943635 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Settings store should persist state

https://gerrit.wikimedia.org/r/943635

gerritbot added a project: Patch-For-Review.Jul 31 2023, 8:30 PM
jsn.sherman added a comment.Jul 31 2023, 8:39 PM

Okay, I now have separate patches out for persisting state and moving it to the util module. I'll rebase my toolbar patch against those tomorrow and do the necessary cleanup.

gerritbot added a comment.Aug 1 2023, 2:22 PM

Change 938956 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Vue.js Curation Toolbar container

https://gerrit.wikimedia.org/r/938956

jsn.sherman moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Aug 1 2023, 4:04 PM
jsn.sherman moved this task from Vue migration bugs to Code Review on the PageTriage board.
gerritbot added a comment.Aug 1 2023, 4:32 PM

Change 943635 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Settings store should persist state

https://gerrit.wikimedia.org/r/943635

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 1 2023, 5:00 PM
jsn.sherman added a parent task: T343329: Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience.Aug 2 2023, 1:31 PM
gerritbot added a comment.Aug 3 2023, 6:18 PM

Change 945631 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Persistent state followup

https://gerrit.wikimedia.org/r/945631

gerritbot added a comment.Aug 4 2023, 2:21 AM

Change 945631 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Persistent state followup

https://gerrit.wikimedia.org/r/945631

jsn.sherman updated the task description. (Show Details)Aug 15 2023, 4:13 PM
jsn.sherman moved this task from Code review to In Progress on the Moderator-Tools-Team (Kanban) board.Aug 24 2023, 7:40 PM
gerritbot added a comment.Aug 24 2023, 9:18 PM

Change 952279 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Save state with mw.Api instead of LocalStorage

https://gerrit.wikimedia.org/r/952279

jsn.sherman mentioned this in T340130: Implement Curation Toolbar container in Vue.js.Aug 25 2023, 6:48 PM
jsn.sherman moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Aug 29 2023, 3:16 PM
PatchDemoBot added a comment.Aug 29 2023, 7:45 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/de5974d4d8/w

PatchDemoBot added a comment.Aug 31 2023, 3:15 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bda3f73aef/w

PatchDemoBot added a comment.Aug 31 2023, 7:15 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bda3f73aef/w/

PatchDemoBot added a comment.Aug 31 2023, 7:16 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/de5974d4d8/w/

PatchDemoBot added a comment.Aug 31 2023, 7:19 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fa53b46016/w

gerritbot added a comment.Sep 5 2023, 3:01 PM

Change 954958 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] revert "mv settings store to ext.pageTriage.util"

https://gerrit.wikimedia.org/r/954958

gerritbot added a comment.Sep 6 2023, 4:16 PM

Change 954958 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] revert "mv settings store to ext.pageTriage.util"

https://gerrit.wikimedia.org/r/954958

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Sep 6 2023, 5:00 PM
PatchDemoBot added a comment.Sep 15 2023, 12:20 AM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fa53b46016/w/

gerritbot added a comment.Sep 15 2023, 2:06 AM

Change 952279 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] new ui stores settings the same way as old ui

https://gerrit.wikimedia.org/r/952279

Scardenasmolinar moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Sep 15 2023, 2:11 AM
Scardenasmolinar subscribed.

I will move this to Done because the curation toolbar patch is also linked to T340130.

Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Sep 15 2023, 2:12 AM
jsn.sherman closed this task as Resolved.Oct 6 2023, 12:45 AM
jsn.sherman updated the task description. (Show Details)

This has been resolved for some time now.

jsn.sherman removed a subtask: T340117: PageTriage: Implement Curation Toolbar in Vue.js.Oct 6 2023, 12:53 AM
gerritbot added a comment.Oct 11 2023, 7:01 PM

Change 938956 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Vue.js Curation Toolbar container

https://gerrit.wikimedia.org/r/938956

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2023, 7:10 PM
Samwalton9-WMF closed subtask T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo as Resolved.Oct 20 2023, 9:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL