| Novem_Linguae | |
| Jul 17 2023, 9:29 PM |
| F37152757: Screenshot 2023-07-27 at 19.29.33.png | |
| Jul 28 2023, 2:09 AM |
| F37152758: Screenshot 2023-07-27 at 19.29.40.png | |
| Jul 28 2023, 2:09 AM |
| F37152759: Screenshot 2023-07-27 at 19.30.16.png | |
| Jul 28 2023, 2:09 AM |
| F37152760: Screenshot 2023-07-27 at 19.30.38.png | |
| Jul 28 2023, 2:09 AM |
| F37141775: image.png | |
| Jul 17 2023, 9:29 PM |
| F37141773: image.png | |
| Jul 17 2023, 9:29 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix Review button in bottom corner | mediawiki/extensions/PageTriage | master | +10 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T335074 Rewrite PageTriage front-end in Vue.js | |||
| Resolved | Samwalton9-WMF | T334506 Improve Javascript testing coverage in PageTriage | |||
| Resolved | Samwalton9-WMF | T343329 Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience | |||
| Resolved | BUG REPORT | jsn.sherman | T342434 Special:NewPagesFeed and Page Curation toolbar must share and persist state | ||
| Resolved | Spike | jsn.sherman | T324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo | ||
| Resolved | BUG REPORT | Scardenasmolinar | T342055 Articles for Creation filter doesn't look good at high zooms (right column too wide) |
I think this might be mainly solved with the solution I made in T342054. Can you test it in your local environment or in a Patch Demo @Novem_Linguae?
I think the original problem got solved after the changes made in T342054. However, I see that the review button is not fixed like in the original version of the feed. I can fix this bug in this ticket.
Screencaps:
AfC article with a lot of text in Vue version
AfC article with a lot of text in original version
NPP article with a lot of text in original version
NPP article with a lot of text in Vue version
Should I fix this, or should I just mark this as done? @Novem_Linguae @jsn.sherman @Samwalton9 comments and thoughts are appreciated.
I have a slight preference for having this behave as it did before, being fixed in the bottom-right.
Change 943650 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/PageTriage@master] Fix Review button in bottom corner
Change 943650 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Fix Review button in bottom corner
This may need a follow up patch. I don't see the "Review" button at all in beta cluster right now.
https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed?ui_version=1