Page MenuHomePhabricator
Create Task
Maniphest T324914

Add [[User:DannyS712/VueNPP.js]] to PageTriage repo
Closed, ResolvedPublicSpike
Actions

Assigned To
jsn.sherman
Authored By
Novem_Linguae
Dec 11 2022, 9:18 AM
Tags
Referenced Files
F37104661: Screenshot 2023-06-15 at 11.41.05.png
Jun 15 2023, 10:52 AM
F37104659: Screenshot 2023-06-15 at 11.40.57.png
Jun 15 2023, 10:52 AM
F37104649: Screenshot 2023-06-15 at 11.10.24.png
Jun 15 2023, 10:12 AM
F37104647: Screenshot 2023-06-15 at 11.09.39.png
Jun 15 2023, 10:12 AM
F37103462: Screenshot 2023-06-14 at 13.40.18.png
Jun 14 2023, 12:43 PM
F37103460: Screenshot 2023-06-14 at 13.40.09.png
Jun 14 2023, 12:43 PM
F36988716: Screenshot 2023-05-08 at 13.39.48.png
May 8 2023, 12:49 PM
F36988718: Screenshot 2023-05-08 at 13.41.07.png
May 8 2023, 12:49 PM
View All 12 Files
Subscribers
Aklapper
CCiufo-WMF
DannyS712
Jdlrobson
jsn.sherman
kostajh
MPGuy2824
View All 10 Subscribers
Tokens
"Party Time" token, awarded by CCiufo-WMF.

Description

  • set up whatever scaffolding is needed to get .vue files working in this repo
  • convert https://en.wikipedia.org/wiki/User:DannyS712/VueNPP.js to files in this repo.
    • It probably needs to be broken into multiple files, e.g. ListItemComponent.vue, ControlSectionComponent.vue, DateControlSectionComponent.vue, LabeledInputComponent.vue, FeedControlMenuComponent.vue, StatsBarComponent.vue, LoadMoreBarComponent.vue, FeedContentsComponent.vue, etc.
    • Don't replace the old Special:NewPagesFeed yet. We should keep the Vue Special:NewPagesFeed on a hidden page and do some testing and updating first.

This ticket will potentially kick off our rewrite of the front end of PageTriage in Vue.js

If someone experienced like @DannyS712 can do the initial scaffolding and conversion, then perhaps other devs can use that as a model and rewrite the rest of the repo (i.e. the Page Curation toolbar)

Details

Other Assignee
jsn.sherman
SubjectRepoBranchLines +/-
Add [[User:DannyS712/VueNPP.js]] to PageTriagemediawiki/extensions/PageTriagemaster+13 K -6 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT335074 Rewrite PageTriage front-end in Vue.js
 Resolved• Samwalton9-WMFT334506 Improve Javascript testing coverage in PageTriage
 Resolved• Samwalton9-WMFT343329 Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience
 ResolvedBUG REPORTjsn.shermanT342434 Special:NewPagesFeed and Page Curation toolbar must share and persist state
 ResolvedSpikejsn.shermanT324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo
 DuplicateNoneT339386 Make sure recent patches make it into the Vue Special:NewPagesFeed rewrite
 ResolvedBUG REPORTScardenasmolinarT342048 Icons have no color in vector 2010 or monobook
 ResolvedBUG REPORTScardenasmolinarT342053 Progress bar needs more top and bottom padding
 ResolvedBUG REPORTScardenasmolinarT342054 mw.msg( 'lastAfcActionLabel' ) displays msg name instead of msg value
 ResolvedBUG REPORTScardenasmolinarT342055 Articles for Creation filter doesn't look good at high zooms (right column too wide)
 ResolvedBUG REPORTScardenasmolinarT342056 "More" button that displays during infinite scroll appears to be unused/unneeded
 ResolvedSpikejsn.shermanT342057 SPIKE: Check if Vue Special:NewPagesFeed has feature parity with existing Special:NewPagesFeed [4hrs]
 ResolvedMPGuy2824T342323 Improve PageTriage module folder names
 ResolvedBUG REPORTScardenasmolinarT342423 Special:NewPagesFeed footer flashes "-1" until the API query completes
 ResolvedBUG REPORTjsn.shermanT342435 mwe-vue-pt-info-pane has too much padding
 ResolvedBUG REPORTScardenasmolinarT343126 Space missing between "Oldest" and "X pages in your filtered list"
 ResolvedBUG REPORTScardenasmolinarT343128 Footer should not have top shadow if it is not floating
 ResolvedBUG REPORTjsn.shermanT343259 Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in
 ResolvedBUG REPORTjsn.shermanT342050 Filter menu items have too much padding
 ResolvedBUG REPORTjsn.shermanT342049 Filter menu radio buttons are too big
 ResolvedBUG REPORTjsn.shermanT342440 Special:NewPagesFeed is missing pagetriage-welcome message at the top
 ResolvedBUG REPORTjsn.shermanT342051 New iconset does not match Page Curation toolbar and is (arguably) less aesthetic
 ResolvedScardenasmolinarT344992 pagetriage-js-required message is missing when Javascript is not enabled
 ResolvedSpikeScardenasmolinarT345153 Fix Date range alignment issues in filter menu in some browsers

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Novem_Linguae added a comment.Jun 15 2023, 11:00 AM

Consider changing the shade of purple in the new autopatrol icon (to dark purple or pink). Looks blue to me (same shade as blue icon) reading it on my phone.

jsn.sherman added a comment.Jun 15 2023, 11:34 AM

Besides this, everything that's available looks good to me! Do we want to test currently-missing features like AfC and ORES in Patch Demo too?

I've done a fair bit of work on those features locally, but they aren't visible here. I think I have a few more AfC things I can check with what I have in my local environment. I realize that my patchdemo doesn't even have ores installed, so I'll try adding that into the next one and see if we can expose those features.

Article state icons changed. May want to use the old icons so that we aren't drastically changing the UI.
...
Consider changing the shade of purple in the new autopatrol icon (to dark purple or pink). Looks blue to me (same shade as blue icon) reading it on my phone.

On the icons: I agree that I haven't quite hit the nail on the head.

This was my first pass at shopping this icon set:
https://doc.wikimedia.org/codex/latest/icons/all-icons.html
and these color tokens:
https://doc.wikimedia.org/codex/latest/design-tokens/color.html

to get green and purple checkboxes. I just picked some to avoid analysis paralysis, but I think I'm abusing the color tokens. I'm going to ask the design systems folks to have a look at the patch and hopefully give me some guidance.

We do have the option of merging the work so far and testing this in production, since it's hidden behind a URL parameter.

I think we should have another round of code review after I do some housekeeping on the patch today.

Novem_Linguae mentioned this in T339386: Make sure recent patches make it into the Vue Special:NewPagesFeed rewrite.Jun 16 2023, 7:24 PM
Novem_Linguae added a subtask: T339386: Make sure recent patches make it into the Vue Special:NewPagesFeed rewrite.
jsn.sherman moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Jun 16 2023, 7:45 PM
jsn.sherman renamed this task from Investigate/Explore adding [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs] to Add [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs].Jun 21 2023, 8:14 PM
jsn.sherman removed a project: Spike.
jsn.sherman added a parent task: T334506: Improve Javascript testing coverage in PageTriage.Jun 22 2023, 1:25 PM
• Samwalton9-WMF mentioned this in T323672: Remove unnecessary parameters (nppDir, afcDir) added during API calls.Jun 22 2023, 2:58 PM
• Samwalton9-WMF mentioned this in T340063: [REQUEST] Design systems code review for Vue3 new page patrol.Jun 23 2023, 2:47 PM
• Samwalton9-WMF renamed this task from Add [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs] to Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.Jun 26 2023, 11:50 AM
PatchDemoBot added a comment.Jun 30 2023, 1:57 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/77f9921a5d/wiki/Special:NewPagesFeed?ui_version=1

PatchDemoBot added a comment.Jun 30 2023, 2:13 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/71229c585d/w/

PatchDemoBot added a comment.Jun 30 2023, 2:14 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/de342df89e/w/

PatchDemoBot added a comment.Jun 30 2023, 2:14 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/59f8fcf2ed/w/

PatchDemoBot added a comment.Jun 30 2023, 2:14 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/25f8800126/w/

PatchDemoBot added a comment.Jun 30 2023, 2:14 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5d46410e00/w/

PatchDemoBot added a comment.Jun 30 2023, 2:15 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/37a6b4906a/w/

PatchDemoBot added a comment.Jun 30 2023, 2:15 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0a17327c10/w/

PatchDemoBot added a comment.Jun 30 2023, 2:15 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5e4faee07d/w/

PatchDemoBot added a comment.Jun 30 2023, 2:16 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1ffd09e98d/w/

gerritbot added a comment.Jul 14 2023, 7:16 PM

Change 910519 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add [[User:DannyS712/VueNPP.js]] to PageTriage

https://gerrit.wikimedia.org/r/910519

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2023, 7:30 PM
jsn.sherman updated the task description. (Show Details)Jul 14 2023, 7:40 PM
jsn.sherman moved this task from Code review to QA on the Moderator-Tools-Team (Kanban) board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 14 2023, 8:00 PM
• Samwalton9-WMF added a subtask: T342048: Icons have no color in vector 2010 or monobook.Jul 18 2023, 9:20 AM
• Samwalton9-WMF added a subtask: T342053: Progress bar needs more top and bottom padding.
• Samwalton9-WMF added a subtask: T342054: mw.msg( 'lastAfcActionLabel' ) displays msg name instead of msg value.
• Samwalton9-WMF added a subtask: T342055: Articles for Creation filter doesn't look good at high zooms (right column too wide).Jul 18 2023, 9:23 AM
• Samwalton9-WMF added a subtask: T342056: "More" button that displays during infinite scroll appears to be unused/unneeded.
• Samwalton9-WMF added a subtask: T342057: SPIKE: Check if Vue Special:NewPagesFeed has feature parity with existing Special:NewPagesFeed [4hrs].
• Samwalton9-WMF added a subtask: T342323: Improve PageTriage module folder names.Jul 20 2023, 2:41 PM
Scardenasmolinar changed the status of subtask T342053: Progress bar needs more top and bottom padding from Open to In Progress.Jul 21 2023, 12:29 AM
Novem_Linguae added a subtask: T342423: Special:NewPagesFeed footer flashes "-1" until the API query completes.Jul 21 2023, 11:35 AM
Novem_Linguae added a subtask: T342434: Special:NewPagesFeed and Page Curation toolbar must share and persist state.Jul 21 2023, 1:55 PM
Scardenasmolinar changed the status of subtask T342056: "More" button that displays during infinite scroll appears to be unused/unneeded from Open to In Progress.Jul 24 2023, 7:37 PM
• Samwalton9-WMF added a subtask: T342435: mwe-vue-pt-info-pane has too much padding.Jul 25 2023, 4:22 PM
Scardenasmolinar changed the status of subtask T342054: mw.msg( 'lastAfcActionLabel' ) displays msg name instead of msg value from Open to In Progress.Jul 25 2023, 8:13 PM
Scardenasmolinar changed the status of subtask T342055: Articles for Creation filter doesn't look good at high zooms (right column too wide) from Open to In Progress.Jul 26 2023, 3:15 AM
Novem_Linguae added a subtask: T343126: Space missing between "Oldest" and "X pages in your filtered list".Jul 31 2023, 1:09 PM
Novem_Linguae added a subtask: T343128: Footer should not have top shadow if it is not floating.Jul 31 2023, 1:17 PM
jsn.sherman removed a subtask: T342434: Special:NewPagesFeed and Page Curation toolbar must share and persist state.Jul 31 2023, 4:38 PM
jsn.sherman added a parent task: T342434: Special:NewPagesFeed and Page Curation toolbar must share and persist state.
Scardenasmolinar changed the status of subtask T342048: Icons have no color in vector 2010 or monobook from Open to In Progress.Aug 1 2023, 1:15 AM
• Samwalton9-WMF closed subtask T342053: Progress bar needs more top and bottom padding as Resolved.Aug 1 2023, 4:05 PM
• Samwalton9-WMF added a subtask: T343259: Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in.Aug 1 2023, 6:27 PM
• Samwalton9-WMF mentioned this in T331598: Fix Special:NewPages Feed "Review" button word wrapping in Chinese.Aug 2 2023, 12:56 PM
jsn.sherman changed the status of subtask T343259: Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in from Open to In Progress.Aug 2 2023, 11:30 PM
Scardenasmolinar changed the status of subtask T342423: Special:NewPagesFeed footer flashes "-1" until the API query completes from Open to In Progress.Aug 3 2023, 12:25 AM
Novem_Linguae mentioned this in T343329: Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience.Aug 3 2023, 4:49 AM
jsn.sherman added subtasks: T342050: Filter menu items have too much padding, T342049: Filter menu radio buttons are too big, T342440: Special:NewPagesFeed is missing pagetriage-welcome message at the top, T342051: New iconset does not match Page Curation toolbar and is (arguably) less aesthetic.Aug 4 2023, 6:31 PM
jsn.sherman added a parent task: T343329: Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience.
Novem_Linguae added a comment.Aug 5 2023, 2:46 PM

Is this ready to close as resolved? I think we have some other tracking tickets we could use for tracking when we've finished the Vue Special:NewPagesFeed conversion. The scope of this ticket, "Add [[User:DannyS712/VueNPP.js]] to PageTriage repo", is completed.

jsn.sherman added a comment.Aug 5 2023, 4:18 PM
In T324914#9071390, @Novem_Linguae wrote:

I think we have some other tracking tickets we could use for tracking when we've finished the Vue Special:NewPagesFeed conversion.

We'd like to track the feed specific tasks to get to that point. Those other tracker tasks are subtasks that aren't directly scoped to the new pages feed module. Moderator tools needs a tracking ticket for feed specific tasks given the number of separate projects we work on.

We need to track

  • new pages feed module tasks (which I parked here, though probably the rename task doesn't belong)
  • the minimal curation toolbar container tasks scoped to the toolbar module
  • the cross cutting tasks between those two modules
  • the actual deployment steps to take after all of the above are completed

I know the page triage vue migration column is where you are tracking this work, but that doesn't provide us with a graph for the relationship between the tasks, which is a feature I depend on to understand how we're doing on various projects.

In the process, I sort of hijacked this task. I probably should have either updated the description or simply created another task.

Scardenasmolinar changed the status of subtask T343126: Space missing between "Oldest" and "X pages in your filtered list" from Open to In Progress.Aug 10 2023, 2:03 AM
Scardenasmolinar changed the status of subtask T342435: mwe-vue-pt-info-pane has too much padding from Open to In Progress.Aug 11 2023, 3:22 AM
Scardenasmolinar changed the status of subtask T343128: Footer should not have top shadow if it is not floating from Open to In Progress.Aug 11 2023, 11:59 PM
Scardenasmolinar closed subtask T342054: mw.msg( 'lastAfcActionLabel' ) displays msg name instead of msg value as Resolved.Aug 15 2023, 4:06 PM
Scardenasmolinar closed subtask T342056: "More" button that displays during infinite scroll appears to be unused/unneeded as Resolved.
• Samwalton9-WMF closed subtask T342048: Icons have no color in vector 2010 or monobook as Resolved.Aug 22 2023, 4:08 PM
jsn.sherman closed subtask T342055: Articles for Creation filter doesn't look good at high zooms (right column too wide) as Resolved.Aug 22 2023, 5:26 PM
jsn.sherman closed subtask T342440: Special:NewPagesFeed is missing pagetriage-welcome message at the top as Resolved.
jsn.sherman closed subtask T342050: Filter menu items have too much padding as Resolved.Aug 22 2023, 5:49 PM
jsn.sherman closed subtask T342049: Filter menu radio buttons are too big as Resolved.
jsn.sherman closed subtask T343126: Space missing between "Oldest" and "X pages in your filtered list" as Resolved.Aug 22 2023, 5:54 PM
• Samwalton9-WMF added a subtask: T344992: pagetriage-js-required message is missing when Javascript is not enabled.Aug 25 2023, 1:27 PM
Scardenasmolinar changed the status of subtask T344992: pagetriage-js-required message is missing when Javascript is not enabled from Open to In Progress.Aug 26 2023, 3:06 AM
Novem_Linguae reopened subtask T343126: Space missing between "Oldest" and "X pages in your filtered list" as Open.Aug 29 2023, 12:58 PM
Novem_Linguae reopened subtask T342048: Icons have no color in vector 2010 or monobook as Open.Aug 29 2023, 1:03 PM
Novem_Linguae closed subtask T342423: Special:NewPagesFeed footer flashes "-1" until the API query completes as Resolved.Aug 29 2023, 2:50 PM
Novem_Linguae closed subtask T342051: New iconset does not match Page Curation toolbar and is (arguably) less aesthetic as Resolved.Aug 29 2023, 2:56 PM
Novem_Linguae closed subtask T343259: Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in as Resolved.Aug 29 2023, 3:09 PM
Scardenasmolinar changed the status of subtask T342048: Icons have no color in vector 2010 or monobook from Open to In Progress.Aug 29 2023, 7:17 PM
Scardenasmolinar changed the status of subtask T343126: Space missing between "Oldest" and "X pages in your filtered list" from Open to In Progress.Aug 29 2023, 10:51 PM
Scardenasmolinar changed the status of subtask T345153: Fix Date range alignment issues in filter menu in some browsers from Open to In Progress.Aug 30 2023, 11:50 PM
• Samwalton9-WMF closed subtask T344992: pagetriage-js-required message is missing when Javascript is not enabled as Resolved.Sep 12 2023, 4:07 PM
• Samwalton9-WMF closed subtask T342048: Icons have no color in vector 2010 or monobook as Resolved.Sep 15 2023, 9:23 AM
• Samwalton9-WMF closed subtask T345153: Fix Date range alignment issues in filter menu in some browsers as Resolved.
• Samwalton9-WMF closed subtask T343128: Footer should not have top shadow if it is not floating as Resolved.
MPGuy2824 closed subtask T343126: Space missing between "Oldest" and "X pages in your filtered list" as Resolved.Sep 22 2023, 8:26 AM
PatchDemoBot added a comment.Sep 28 2023, 6:33 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/77f9921a5d/w/

DMburugu moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Oct 3 2023, 4:04 PM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:44 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

jsn.sherman claimed this task.Oct 6 2023, 12:54 AM
jsn.sherman changed the status of subtask T342057: SPIKE: Check if Vue Special:NewPagesFeed has feature parity with existing Special:NewPagesFeed [4hrs] from Open to In Progress.Oct 6 2023, 1:36 AM
• Samwalton9-WMF closed subtask T342057: SPIKE: Check if Vue Special:NewPagesFeed has feature parity with existing Special:NewPagesFeed [4hrs] as Resolved.Oct 10 2023, 4:06 PM
jsn.sherman changed the status of subtask T342323: Improve PageTriage module folder names from Open to In Progress.Oct 10 2023, 5:45 PM
jsn.sherman changed the status of subtask T342323: Improve PageTriage module folder names from In Progress to Stalled.Oct 11 2023, 5:08 PM
jsn.sherman changed the status of subtask T342323: Improve PageTriage module folder names from Stalled to In Progress.Oct 16 2023, 5:37 PM
jsn.sherman moved this task from In Progress to Done on the Moderator-Tools-Team (Kanban) board.Oct 17 2023, 7:06 PM
jsn.sherman moved this task from Priority technical debt to Waiting for enwiki deploy on the PageTriage board.
Aklapper removed a project: PageTriage.Oct 17 2023, 9:07 PM
Aklapper edited projects, added PageTriage; removed Growth-Team.Oct 17 2023, 9:12 PM
• Samwalton9-WMF closed this task as Resolved.Oct 20 2023, 9:55 AM
• Samwalton9-WMF closed subtask T342435: mwe-vue-pt-info-pane has too much padding as Resolved.
CCiufo-WMF awarded a token.Oct 20 2023, 1:42 PM
MPGuy2824 changed the status of subtask T342323: Improve PageTriage module folder names from In Progress to Open.Jan 26 2024, 5:59 AM
Novem_Linguae closed subtask T342323: Improve PageTriage module folder names as Resolved.Feb 20 2024, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL