Page MenuHomePhabricator

Add [[User:DannyS712/VueNPP.js]] to PageTriage repo
Closed, ResolvedPublicSpike

Description

  • set up whatever scaffolding is needed to get .vue files working in this repo
  • convert https://en.wikipedia.org/wiki/User:DannyS712/VueNPP.js to files in this repo.
    • It probably needs to be broken into multiple files, e.g. ListItemComponent.vue, ControlSectionComponent.vue, DateControlSectionComponent.vue, LabeledInputComponent.vue, FeedControlMenuComponent.vue, StatsBarComponent.vue, LoadMoreBarComponent.vue, FeedContentsComponent.vue, etc.
    • Don't replace the old Special:NewPagesFeed yet. We should keep the Vue Special:NewPagesFeed on a hidden page and do some testing and updating first.

This ticket will potentially kick off our rewrite of the front end of PageTriage in Vue.js

If someone experienced like @DannyS712 can do the initial scaffolding and conversion, then perhaps other devs can use that as a model and rewrite the rest of the repo (i.e. the Page Curation toolbar)

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedSamwalton9-WMF
ResolvedSamwalton9-WMF
ResolvedBUG REPORTjsn.sherman
ResolvedSpikejsn.sherman
DuplicateNone
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTScardenasmolinar
ResolvedSpikejsn.sherman
ResolvedMPGuy2824
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTjsn.sherman
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTScardenasmolinar
ResolvedBUG REPORTjsn.sherman
ResolvedBUG REPORTjsn.sherman
ResolvedBUG REPORTjsn.sherman
ResolvedBUG REPORTjsn.sherman
ResolvedBUG REPORTjsn.sherman
ResolvedScardenasmolinar
ResolvedSpikeScardenasmolinar

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Consider changing the shade of purple in the new autopatrol icon (to dark purple or pink). Looks blue to me (same shade as blue icon) reading it on my phone.

Besides this, everything that's available looks good to me! Do we want to test currently-missing features like AfC and ORES in Patch Demo too?

I've done a fair bit of work on those features locally, but they aren't visible here. I think I have a few more AfC things I can check with what I have in my local environment. I realize that my patchdemo doesn't even have ores installed, so I'll try adding that into the next one and see if we can expose those features.

Article state icons changed. May want to use the old icons so that we aren't drastically changing the UI.
...
Consider changing the shade of purple in the new autopatrol icon (to dark purple or pink). Looks blue to me (same shade as blue icon) reading it on my phone.

On the icons: I agree that I haven't quite hit the nail on the head.

This was my first pass at shopping this icon set:
https://doc.wikimedia.org/codex/latest/icons/all-icons.html
and these color tokens:
https://doc.wikimedia.org/codex/latest/design-tokens/color.html

to get green and purple checkboxes. I just picked some to avoid analysis paralysis, but I think I'm abusing the color tokens. I'm going to ask the design systems folks to have a look at the patch and hopefully give me some guidance.

We do have the option of merging the work so far and testing this in production, since it's hidden behind a URL parameter.

I think we should have another round of code review after I do some housekeeping on the patch today.

jsn.sherman renamed this task from Investigate/Explore adding [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs] to Add [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs].Jun 21 2023, 8:14 PM
jsn.sherman removed a project: Spike.
Samwalton9-WMF renamed this task from Add [[User:DannyS712/VueNPP.js]] to PageTriage repo [24hrs] to Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.Jun 26 2023, 11:50 AM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/71229c585d/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/de342df89e/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/59f8fcf2ed/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/25f8800126/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5d46410e00/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/37a6b4906a/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0a17327c10/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5e4faee07d/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1ffd09e98d/w/

Change 910519 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add [[User:DannyS712/VueNPP.js]] to PageTriage

https://gerrit.wikimedia.org/r/910519

Is this ready to close as resolved? I think we have some other tracking tickets we could use for tracking when we've finished the Vue Special:NewPagesFeed conversion. The scope of this ticket, "Add [[User:DannyS712/VueNPP.js]] to PageTriage repo", is completed.

I think we have some other tracking tickets we could use for tracking when we've finished the Vue Special:NewPagesFeed conversion.

We'd like to track the feed specific tasks to get to that point. Those other tracker tasks are subtasks that aren't directly scoped to the new pages feed module. Moderator tools needs a tracking ticket for feed specific tasks given the number of separate projects we work on.

We need to track

  • new pages feed module tasks (which I parked here, though probably the rename task doesn't belong)
  • the minimal curation toolbar container tasks scoped to the toolbar module
  • the cross cutting tasks between those two modules
  • the actual deployment steps to take after all of the above are completed

I know the page triage vue migration column is where you are tracking this work, but that doesn't provide us with a graph for the relationship between the tasks, which is a feature I depend on to understand how we're doing on various projects.

In the process, I sort of hijacked this task. I probably should have either updated the description or simply created another task.

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/77f9921a5d/w/

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.