Page MenuHomePhabricator
Create Task
Maniphest T343128

Footer should not have top shadow if it is not floating
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Footer has top shadow

image.png (281×2 px, 39 KB)

What should have happened instead?:

  • Footer does not have top shadow

image.png (240×2 px, 17 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Refactor IntersectionObserver for footer shadowmediawiki/extensions/PageTriagemaster+23 -25
[Example] Observe results list instead of mw footer for list stats nav shadowmediawiki/extensions/PageTriagemaster+23 -32
Fix footer shadowmediawiki/extensions/PageTriagemaster+50 -12
Example followup to: Fix footer shadowmediawiki/extensions/PageTriagemaster+30 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Jul 31 2023, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2023, 1:17 PM
Novem_Linguae added a parent task: T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.Jul 31 2023, 1:17 PM
Novem_Linguae moved this task from Backlog to Vue migration bugs on the PageTriage board.
• Samwalton9-WMF added a project: Moderator-Tools-Team (Kanban).Aug 1 2023, 9:15 AM
jsn.sherman added a parent task: T343329: Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience.Aug 2 2023, 1:31 PM
jsn.sherman removed a parent task: T343329: Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience.Aug 4 2023, 6:32 PM
Scardenasmolinar changed the task status from Open to In Progress.Aug 11 2023, 11:59 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Aug 16 2023, 5:12 PM

Change 949559 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] [WIP]Fix footer shadow

https://gerrit.wikimedia.org/r/949559

gerritbot added a project: Patch-For-Review.Aug 16 2023, 5:12 PM
gerritbot added a comment.Aug 17 2023, 5:54 PM

Change 950001 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Example followup to: Fix footer shadow

https://gerrit.wikimedia.org/r/950001

Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Aug 18 2023, 12:03 AM
Scardenasmolinar moved this task from Vue migration bugs to Code Review on the PageTriage board.
gerritbot added a comment.Aug 18 2023, 4:49 PM

Change 950001 abandoned by Jsn.sherman:

[mediawiki/extensions/PageTriage@master] Example followup to: Fix footer shadow

Reason:

https://gerrit.wikimedia.org/r/950001

gerritbot added a comment.Aug 19 2023, 5:15 AM

Change 949559 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix footer shadow

https://gerrit.wikimedia.org/r/949559

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2023, 5:30 AM
jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Aug 19 2023, 11:48 AM
jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
Novem_Linguae added a comment.Aug 29 2023, 3:05 PM

May need more work. The shadow correctly disappears when you switch filters from a list with a lot of items to a list with zero items, but when you scroll up, the shadow prematurely comes back.

image.png (355×1 px, 60 KB)

Novem_Linguae moved this task from Waiting for enwiki deploy to Vue migration bugs on the PageTriage board.Aug 29 2023, 3:06 PM
• Samwalton9-WMF removed Scardenasmolinar as the assignee of this task.Aug 29 2023, 4:10 PM
• Samwalton9-WMF moved this task from Done to Ready on the Moderator-Tools-Team (Kanban) board.
• Samwalton9-WMF added a subscriber: Scardenasmolinar.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 9:01 PM
Scardenasmolinar claimed this task.Aug 31 2023, 2:07 AM
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Sep 5 2023, 6:20 PM

Change 954978 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Add guard clause for shadow footer edge case

https://gerrit.wikimedia.org/r/954978

gerritbot added a project: Patch-For-Review.Sep 5 2023, 6:20 PM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Sep 5 2023, 11:44 PM
Scardenasmolinar moved this task from Vue migration bugs to Code Review on the PageTriage board.
gerritbot added a comment.Sep 6 2023, 2:57 PM

Change 955348 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] [Example] Observe results list instead of mw footer for list stats nav shadow

https://gerrit.wikimedia.org/r/955348

jsn.sherman moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Sep 6 2023, 3:44 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Sep 9 2023, 3:40 AM
gerritbot added a comment.Sep 11 2023, 2:02 PM

Change 955348 abandoned by Jsn.sherman:

[mediawiki/extensions/PageTriage@master] [Example] Observe results list instead of mw footer for list stats nav shadow

Reason:

https://gerrit.wikimedia.org/r/955348

jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Sep 11 2023, 2:06 PM
jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Sep 11 2023, 2:20 PM

Change 954978 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Refactor IntersectionObserver for footer shadow

https://gerrit.wikimedia.org/r/954978

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2023, 2:29 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 11 2023, 3:00 PM
• Samwalton9-WMF closed this task as Resolved.Sep 15 2023, 9:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL