| Novem_Linguae | |
| Jul 21 2023, 2:05 PM |
| F38216579: image.png | |
| Oct 12 2023, 4:26 PM |
| F37640844: image.png | |
| Aug 29 2023, 2:55 PM |
| F37400647: Screenshot 2023-08-11 at 17.37.52.png | |
| Aug 11 2023, 11:42 PM |
| F37400642: Screenshot 2023-08-11 at 14.21.34.png | |
| Aug 11 2023, 11:42 PM |
| F37149540: image.png | |
| Jul 25 2023, 4:27 PM |
| F37149542: image.png | |
| Jul 25 2023, 4:27 PM |
| F37145566: image.png | |
| Jul 21 2023, 2:05 PM |
Reported by @Hey_man_im_josh on Discord
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T335074 Rewrite PageTriage front-end in Vue.js | |||
| Resolved | Samwalton9-WMF | T334506 Improve Javascript testing coverage in PageTriage | |||
| Resolved | Samwalton9-WMF | T343329 Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience | |||
| Resolved | BUG REPORT | jsn.sherman | T342434 Special:NewPagesFeed and Page Curation toolbar must share and persist state | ||
| Resolved | Spike | jsn.sherman | T324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo | ||
| Resolved | BUG REPORT | jsn.sherman | T342435 mwe-vue-pt-info-pane has too much padding |
I definitely think an easy win here that reduces padding while improving the visual design is to align the icon, title, and timestamp on at least approximately the same line.
I think this would look better something like this, with the icon, title, and timestamp in-line:
Old
New
Change 948190 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/PageTriage@master] Change padding from NPF list items
I have changed the padding so that the list items are more compact. Let me know if you need me to change anything.
Before
After
Change 948190 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Change padding from NPF list items
I think this would look better something like this, with the icon, title, and timestamp in-line:
Old
New
This ticket might need some more work. The "in-line" idea mentioned here has not been implemented yet, and I agree that this would both solve padding issues and improve the look of the Vue New Pages Feed.
Given the minor change being requested I think we'll move this to our backlog for now rather than block deployment of the new UI. Patches welcome!
Relatedly, I'm somewhat interested in seeing if we can use flexbox/display: grid to mock these features without resorting to the table based layout that is currently used. That (primarily display: grid) might give us a lot more control over positioning and layouting than we currently have. (I might take a look at this later)
@MPGuy2824 has done some work on the Special:NewPagesFeed mwe-vue-pt-info-pane and may have some thoughts about flex vs grid vs tables.
I somehow missed this. Anyway, I used display: table and float in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/859971, when i was updating the UI code. I think i remember trying flexbox, but not being able to get it to work. If Sohom is able to get the look we want in flexbox or display:grid, then all power to him.
Change 964038 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):
[mediawiki/extensions/PageTriage@master] Special:NewPagesFeed Change spacing of list items
Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b3069fa516/w
Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/82622eceda/wiki/Special:NewPagesFeed?pagetriage_ui=new&pagetriage_tb=new
Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d434b100b5/wiki/Special:NewPagesFeed?pagetriage_ui=new
Okay, I think I have this in a pretty nice place; I've checked with multiple skins, in ltr and rtl locales, with ores enabled and disabled.
Change 964038 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Special:NewPagesFeed Change spacing of list items
Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:
Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:
Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted: