Page MenuHomePhabricator

Username input in Codex version of Special:NewPagesFeed doesn't retain focus, can't be typed in
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It's almost impossible to type into the text box, because it loses focus as soon as you release the mouse. The radio button next to it is focused but not selected. (I tested with Chrome, it's possible that this behaves differently in other browsers.)

What should have happened instead?:
I should be able to type into the text box, and the radio button should be selected when I click into the text box

Other information (browser name/version, screenshots, etc.):
This is probably happening because the text input is inside the checkbox's label. Taking it out of the label may help. (I'm unsure if this is a bug in Codex, or just something that browsers do when you put an input inside a label.

Event Timeline

Confirming I can reproduce this, thanks!

jsn.sherman changed the task status from Open to In Progress.Aug 2 2023, 11:29 PM
jsn.sherman claimed this task.
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 944998 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] New Pages Feed: fix username input focus

https://gerrit.wikimedia.org/r/944998

At first glance, I thought I had done something silly with circular state updates, but I actually did something silly with form markup, just as @Catrope suggested.

Change 944998 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] New Pages Feed: fix username input focus

https://gerrit.wikimedia.org/r/944998

Change 945030 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] New Pages Feed: adjust username radio label selector

https://gerrit.wikimedia.org/r/945030

Change 945030 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] New Pages Feed: adjust username radio label selector

https://gerrit.wikimedia.org/r/945030

Change 951550 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Remove margin from username input

https://gerrit.wikimedia.org/r/951550

I noticed that this still has a dangling margin problem for the username input:
I just did a quick patch that changes this:

image.png (118×220 px, 19 KB)

to this:
image.png (387×716 px, 67 KB)

It's still not perfect, but I think it's a big improvement.

Change 951550 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Remove margin from username input

https://gerrit.wikimedia.org/r/951550

Novem_Linguae subscribed.

The "able to type into text box" part of this is solved. The "radio button should be selected" part is covered in T345154: In Vue.js NewPagesFeed, selecting Username filter text box should also select the radio button. Closing.