Page MenuHomePhabricator
Create Task
Maniphest T342489

RecentChanges missing arrow to expand collapsed entries on Timeless
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Fomafix
Authored By
Ciencia_Al_Poder
Jul 22 2023, 4:29 PM
Tags
Referenced Files
F37327091: watchlist_bug_2023-08-06_collapsed_after_review.PNG
Aug 6 2023, 11:51 AM
F37327057: watchlist_bug_2023-08-06_uncollapsed.PNG
Aug 6 2023, 11:51 AM
F37327064: watchlist_bug_2023-08-06_collapsed.PNG
Aug 6 2023, 11:51 AM
Subscribers
Ciencia_Al_Poder
Danbloch
Izno
matmarex
Sojourner_in_the_earth
Trappist_the_monk

Description

Steps to replicate the issue (include links if applicable):

  • Open a new private browser tab
  • Go to Special:RecentChanges on mediawiki.org (with enhanced=1, and useskin=timeless)

What happens?:

For a fraction of a second, related entries in the Recent Changes list are collapsed, and arrow links to uncollapse them are visible. However, it rapidly uncollapses everything and the arrows disappear

What should have happened instead?:

Recent Changes should maintain the related lists collapsed until the user uncollapses them. This works on other skins, just not in Timeless. See Special:RecentChanges on Vector 2022 or Monobook

Software version 1.41.0-wmf.18

This was working a week ago, however I was unable to test during this week. Probably a regression from 1.41.0-wmf.18

See also:

Details

SubjectRepoBranchLines +/-
Use any element in CSS selector of enhanced changes listmediawiki/coremaster+4 -4
Revert "Restrict the table hack from T269912 to mw-parser-output"mediawiki/skins/Timelessmaster+1 -1
Revert "Restrict the table hack from T269912 to mw-parser-output"mediawiki/skins/Splashmaster+1 -1
Restrict the table hack from T269912 to mw-parser-outputmediawiki/skins/Splashmaster+1 -1
Restrict the table hack from T269912 to mw-parser-outputmediawiki/skins/Timelessmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Jul 22 2023, 4:29 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 22 2023, 4:29 PM
Sojourner_in_the_earth subscribed.EditedJul 23 2023, 6:27 AM

This bug has also been reported by several editors at en.wiki WP:VPT#Watchlist bug? It seems like it isn't specific to Timeless, it's also occuring for some people in Vector 2010 and Monobook. I wonder if it only occurs in whatever one's default skin was at the time of the update?

gerritbot added a comment.Jul 23 2023, 11:32 AM

Change 940496 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Repair collapsing on enhanced changes list

https://gerrit.wikimedia.org/r/940496

gerritbot added a project: Patch-For-Review.Jul 23 2023, 11:32 AM
Fomafix claimed this task.Jul 23 2023, 11:33 AM
Danbloch subscribed.Jul 23 2023, 12:28 PM

Note that WP:VPT#Watchlist bug? also includes another bug: Expand/collapse arrow markers are always gray; never green as they should be when there are unvisited changes hidden inside the collapsed watchlist entry. If you want to keep these separate I reported this as T342445, which was redirected to VPT.

gerritbot added a comment.Jul 23 2023, 7:11 PM

Change 940504 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Timeless@master] Include the checkbox on wrapping the enhanced changes list

https://gerrit.wikimedia.org/r/940504

gerritbot added a comment.Jul 27 2023, 3:26 PM

Change 940504 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Restrict the table hack from T269912 to mw-parser-output

https://gerrit.wikimedia.org/r/940504

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 27 2023, 4:00 PM
gerritbot added a comment.Jul 27 2023, 7:11 PM

Change 942493 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Splash@master] Restrict the table hack from T269912 to mw-parser-output

https://gerrit.wikimedia.org/r/942493

Fomafix added a project: Splash.Jul 27 2023, 7:12 PM
gerritbot added a comment.Jul 27 2023, 9:45 PM

Change 942493 merged by jenkins-bot:

[mediawiki/skins/Splash@master] Restrict the table hack from T269912 to mw-parser-output

https://gerrit.wikimedia.org/r/942493

matmarex closed this task as Resolved.Jul 28 2023, 12:24 AM
matmarex subscribed.

Seems to be working correctly now at https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?enhanced=1&useskin=timeless. The changes will be deployed to Wikimedia wikis next week per the usual schedule (unless someone backports them).

Izno subscribed.Jul 28 2023, 1:50 AM
In T342489#9048799, @gerritbot wrote:

Change 940504 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Restrict the table hack from T269912 to mw-parser-output

https://gerrit.wikimedia.org/r/940504

As someone who uses Timeless on small screens, this is a pretty significant negative change to watchlist behavior. Did you test small resolutions here?

Fomafix reopened this task as Open.Jul 30 2023, 6:31 PM

As someone who uses Timeless on small screens, this is a pretty significant negative change to watchlist behavior. Did you test small resolutions here?

This is a good argument. I revert the change and provide a different solution.

gerritbot added a comment.Jul 30 2023, 6:31 PM

Change 942813 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Use any element in CSS selector of enhanced changes list

https://gerrit.wikimedia.org/r/942813

gerritbot added a comment.Jul 30 2023, 6:32 PM

Change 942814 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Timeless@master] Revert "Restrict the table hack from T269912 to mw-parser-output"

https://gerrit.wikimedia.org/r/942814

gerritbot added a comment.Jul 30 2023, 6:32 PM

Change 942815 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Splash@master] Revert "Restrict the table hack from T269912 to mw-parser-output"

https://gerrit.wikimedia.org/r/942815

gerritbot added a comment.Jul 31 2023, 9:12 AM

Change 942813 merged by jenkins-bot:

[mediawiki/core@master] Use any element in CSS selector of enhanced changes list

https://gerrit.wikimedia.org/r/942813

gerritbot added a comment.Jul 31 2023, 9:12 AM

Change 942814 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Revert "Restrict the table hack from T269912 to mw-parser-output"

https://gerrit.wikimedia.org/r/942814

gerritbot added a comment.Jul 31 2023, 9:12 AM

Change 942815 merged by jenkins-bot:

[mediawiki/skins/Splash@master] Revert "Restrict the table hack from T269912 to mw-parser-output"

https://gerrit.wikimedia.org/r/942815

matmarex closed this task as Resolved.Jul 31 2023, 9:36 AM

Thank you for double-checking and for finding a better approach!

Trappist_the_monk reopened this task as Open.Aug 3 2023, 9:49 PM
Trappist_the_monk subscribed.

This is only partially resolved. Before today's update, the collapsed and uncollapsed 'arrow-like' markers were always gray in color whether they had been visited or not. After today's update, unvisited collapsed watchlist items now have a green dot marker (should be a green right-pointing-arrow-like marker). Clicking the dot of an expandable watchlist item, expands the list but the marker does not change to a down-pointing-arrow-like marker. Once all of the unvisited entries in an expanded watchlist item have been visited and the watchlist refreshed (F5), the marker changes to a gray-arrow-like marker.

vector; win 10; chrome
preferences:

Fomafix added a comment.Aug 6 2023, 7:29 AM

@Trappist_the_monk Is this the problem described in T342445: Watchlist isn't showing unread triangle (multiple change) markers in green?

Trappist_the_monk added a comment.Aug 6 2023, 11:51 AM

No. In this image, the watchlist item for Wikipedia:Village pump (technical)‎‎ should be a green right-pointing arrow, not a green dot. The marker should be distinguishable from the green dot attached to watchlist item HMCS Bras d'Or (FHE 400)‎

watchlist_bug_2023-08-06_collapsed.PNG (78×1 px, 13 KB)

In this image, the watchlist item for Wikipedia:Village pump (technical)‎‎ should be a green down-pointing arrow, not a green dot.
watchlist_bug_2023-08-06_uncollapsed.PNG (440×1 px, 86 KB)

After watchlist item for Wikipedia:Village pump (technical)‎‎ has been reviewed, the marker becomes a gray arrow; this is correct.
watchlist_bug_2023-08-06_collapsed_after_review.PNG (100×1 px, 17 KB)

Clicking the gray right-pointing arrow to expand the Wikipedia:Village pump (technical)‎‎ watchlist item, correctly causes the right-pointing arrow to change to a down-pointing arrow as it should do.

Fomafix added a comment.Aug 6 2023, 8:15 PM

The green markers are generated by the gadget https://en.wikipedia.org/wiki/MediaWiki:Gadget-WatchlistGreenIndicators.css and not by the skin Timeless. Therefor the change described in T342445#9037143 should adapt the gadget to the new HTML code.

Trappist_the_monk added a comment.Aug 6 2023, 9:39 PM

I added that css to my common.css and now I have correctly colored and functioning watchlist markers. Please update the gadget css or if you cannot, add an interface-protected edit request to the gadget css talk page.

Fomafix closed this task as Resolved.Aug 8 2023, 6:26 PM

The issues on skins Timeless and Splash are solved. The issue with the green markers is tracked in T342445.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL