Page MenuHomePhabricator

Align WikiLambda's PHP code for canonicalise/normalise with function-schemata's JS code, so they don't disagree
Open, MediumPublic

Description

Description

Steps to reproduce:

Identified by @William_Avery in the course of working on T294826, we don't round-trip some valid inputs, including {"Z1K1":"Z39","Z39K1":"K1"}

Observed behavior:

  • Input and canonicalised-normalised-input differ

Expected behavior (Acceptance criteria):

  • {"Z1K1":"Z39","Z39K1":"K1"} -> <normal form> -> {"Z1K1":"Z39","Z39K1":"K1"}
  • Others?

Completion checklist

Event Timeline

Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF changed the task status from Open to In Progress.Jul 31 2023, 3:09 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

Change 944258 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Test canonicalize using function-schemata test cases; address Quotes and Function calls.

https://gerrit.wikimedia.org/r/944258

Jdforrester-WMF changed the task status from In Progress to Open.Jan 22 2024, 8:08 PM