jquery.textSelection :)

@TheDJ it's already using the textSelection API, but Edit Recovery's change handler is never called when CodeMirror is active. It looks like CodeMirror only actually updates (with codeMirror.save()) the underlying textarea on window.beforeunload, and even then it does it with textarea.value rather than textSelection.

One way to do it might be to add a hook in edit.js where we're adding event handlers, so that CM can add itself using its own change event. We probably want a hook there anyway.

Change 942782 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] EditRecovery: add editRecovery.loadEnd JS hook

https://gerrit.wikimedia.org/r/942782

Change 942783 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CodeMirror@master] Use editRecovery.loadEnd JS hook to add change handler

https://gerrit.wikimedia.org/r/942783

The above patches are ready for review.

Change 942782 merged by jenkins-bot:

[mediawiki/core@master] EditRecovery: add editRecovery.loadEnd JS hook

https://gerrit.wikimedia.org/r/942782

Change 942783 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Use editRecovery.loadEnd JS hook to add change handler

https://gerrit.wikimedia.org/r/942783

Confirmed working on the beta cluster too :-)

@Samwilson @TheresNoTime I changed the highlighted word "cute" to "adorable". I went to a new article and closed the tab and it still has the word I changed it to along with an entry for the IndexedDB. As for the IndexedDB entry, is there something I can see that I changed it too like how I changed "cute" to "adorable" or does it just show an entry that it's saved?

In T342882#9097132, @GMikesell-WMF wrote:

@Samwilson @TheresNoTime I changed the highlighted word "cute" to "adorable". I went to a new article and closed the tab and it still has the word I changed it to along with an entry for the IndexedDB. As for the IndexedDB entry, is there something I can see that I changed it too like how I changed "cute" to "adorable" or does it just show an entry that it's saved?

I've found Firefox to be better for this. You can right click the indexeddb field you are interested in and "Copy".

@Samwilson Edits are recovered and an IndexDB is created. Moving this to Done. Thanks for your work!

Status: ✅ PASS
Environment: Prod
OS: macOS Ventura, Windows 11
Browser: Chrome 116, Firefox 115, Safari 16.6, Edge 115
Device: MBP
Emulated Device:: BrowserStack for Windows
Test Link:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Bear&action=edit

Cleared out DB with each test. Speeds with No Throttle, fast and slow 3G

Chrome	Safari	Firefox	Edge

Disabling Syntax