LogicException: Domain '' is not recognized.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

service.version: 1.41.0-wmf.19
trace.id: ba5a6e0b-ce9e-463e-92c2-4f25d170fbc9
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   LogicException: Domain '' is not recognized.

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.19/includes/jobqueue/JobQueueGroup.php(136)
#0 /srv/mediawiki/php-1.41.0-wmf.19/extensions/TranslationNotifications/includes/Jobs/TranslationNotificationsSubmitJob.php(219): JobQueueGroup->push(array)
#1 /srv/mediawiki/php-1.41.0-wmf.19/extensions/EventBus/includes/JobExecutor.php(78): MediaWiki\Extension\TranslationNotifications\Jobs\TranslationNotificationsSubmitJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#3 {main}

Impact

Notes

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	Handle null target wiki id present in some user preferences	mediawiki/extensions/TranslationNotifications	master	+26 -34
	Do not add jobs with empty target wiki id to the job queue	mediawiki/extensions/TranslationNotifications	master	+34 -3

Customize query in gerrit

Related Objects

Mentioned In: T345347: Write a script to check the validity of subscriber data
T343876: loginwiki: Failed creating job (MassMessageJob) from description

Event Timeline

Krinkle created this task.Jul 27 2023, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2023, 3:35 PM

Krinkle added a project: Language-Team.Jul 27 2023, 3:36 PM

Krinkle moved this task from Untriaged to Jul 2023 on the Wikimedia-production-error board.

The code appears to be trying to call JobQueueGroupFactory::makeJobQueueGroup with an empty string: https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-1-7.0.0-1-2023.07.27?id=H8zXl4kBuj8l-JjZ1E0a

This request originated on Meta-Wiki. On Meta-Wiki I see that there are 185 users who have subscribed to receive notifications on talk page on another wiki, but only 174 out of these have the destination wiki specified. I found this by looking at the user_properties table for user_property of translationnotifications-cmethod-talkpage and translationnotifications-cmethod-talkpage-elsewhere-loc

abi_ triaged this task as Medium priority.Jul 28 2023, 10:16 AM

abi_ edited projects, added Language-Team (Language-2023-July-September); removed Language-Team.

abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-July-September) board.

Change 942650 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/TranslationNotifications@master] Do not add jobs with empty target wiki id to the job queue

https://gerrit.wikimedia.org/r/942650

gerritbot added a project: Patch-For-Review.Jul 28 2023, 1:00 PM

Aklapper edited projects, added TranslationNotifications; removed MediaWiki-extensions-Translate.Jul 29 2023, 3:32 AM

Tacsipacsi subscribed.Jul 30 2023, 1:48 PM

Nikerabbit assigned this task to abi_.Jul 31 2023, 8:47 AM

Nikerabbit added projects: Localization Infrastructure FY2023-24, Unplanned-Sprint-Work.

Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.

Change 942650 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Do not add jobs with empty target wiki id to the job queue

https://gerrit.wikimedia.org/r/942650

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 3:12 PM

abi_ moved this task from In Progress to Check after deployment on the Language-Team (Language-2023-July-September) board.Aug 4 2023, 8:23 AM

No notifications sent from Meta since 1.41.0-wmf.20; 2023-08-01 rolled out. I'll wait another week before sending out a notification myself.

I'm still noticing this issue occurring: https://logstash.wikimedia.org/goto/10fc5eec6b2cf01a964ca41b87dba654; 4 times in the last 9 days.

thcipriani merged a task: T343876: loginwiki: Failed creating job (MassMessageJob) from description.Aug 10 2023, 3:19 PM

thcipriani mentioned this in T343876: loginwiki: Failed creating job (MassMessageJob) from description.

Change 949524 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/TranslationNotifications@master] Handle null target wiki id present in some user preferences

https://gerrit.wikimedia.org/r/949524

gerritbot added a project: Patch-For-Review.Aug 16 2023, 1:56 PM

Change 949524 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Handle null target wiki id present in some user preferences

https://gerrit.wikimedia.org/r/949524

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 11:10 AM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-July-September) board.Aug 26 2023, 3:42 PM

No longer seeing this error with an empty domain. 0 occurrences 21st August.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 29 2023, 11:01 PM

Will the invalid preferences be followed up on? With empty wikis being logged, this will cause continuous log spam.

In T342903#9132193, @Tacsipacsi wrote:

Will the invalid preferences be followed up on? With empty wikis being logged, this will cause continuous log spam.

Yes, there is a plan to address invalid preferences which include empty wikis and wikis that don't have the MassMessage extension and hence can't receive messages via TranslationNotifications. I'll create a task separately for that.

abi_ mentioned this in T345347: Write a script to check the validity of subscriber data.Aug 31 2023, 1:00 PM

LogicException: Domain '' is not recognized.Closed, ResolvedPublicPRODUCTION ERRORActions