Remove fixed width handling for cached HTML
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 8 2023, 6:08 PM

Description

In T341641 we switched Vector over to the new client preferences system. For backwards compatibility we

By current projections, the new code is in. production from 17th August, so we should aim to remove this at 31st August but ideally 7th September.

TODO

Remove FIXMEs introduced in T341641
Include code that removes the old cookie. This should exist for at least a month

QA

Confirm no Pixel related UI regressions
Exploratory testing: As an anonymous user, disable/enable fixed width across various pages confirming that it works consistently.

sign off

Create a ticket for removing the code that handles the old cookie removal.

QA Results - Prod

AC	Status	Details
1	✅	T343843#9154308
2	✅	T343843#9154308

Details

Other Assignee: • Mabualruz

	Subject	Repo	Branch	Lines +/-
	Remove limited width cached HTML handling	mediawiki/skins/Vector	master	+9 -57

Customize query in gerrit

Related Objects

Mentioned In: T341641: Migrate Vector's limited width to new client preference API
Mentioned Here: T343849: Action::getPageTitle(), SpecialPage::getDescription(), some other methods should return a Message in all cases
T341641: Migrate Vector's limited width to new client preference API

Event Timeline

Jdlrobson created this task.Aug 8 2023, 6:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2023, 6:08 PM

Jdlrobson triaged this task as Medium priority.Aug 8 2023, 6:08 PM

Change 946985 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove limited width cached HTML handling

https://gerrit.wikimedia.org/r/946985

gerritbot added a project: Patch-For-Review.Aug 8 2023, 6:09 PM

Jdlrobson mentioned this in T341641: Migrate Vector's limited width to new client preference API.Aug 8 2023, 6:09 PM

Change 947895 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: deprecate OutputPage::setPageTitle() with Message argument

https://gerrit.wikimedia.org/r/947895

Change 947896 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: remove Message argument to OutputPage::setPageTitle(), deprecated in 1.41

https://gerrit.wikimedia.org/r/947896

Change 947927 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add OutputPage::prepareErrorPageMsg() to replace ::prepareErrorPage()

https://gerrit.wikimedia.org/r/947927

Sorry for the phab spam, the above patches belonged with T343849.

I'd like Mo to take care of this task when he gets back. Please see email.

ovasileva set the point value for this task to 2.Aug 24 2023, 5:23 PM

Change 946985 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove limited width cached HTML handling

https://gerrit.wikimedia.org/r/946985

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 28 2023, 5:26 PM

ovasileva changed the point value for this task from 2 to 1.Aug 28 2023, 5:29 PM

• Mabualruz moved this task from Ready for Development to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 29 2023, 2:43 PM

• Mabualruz updated the task description. (Show Details)Aug 29 2023, 3:33 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 4:01 AM

Jdlrobson assigned this task to Edtadros.Sep 5 2023, 4:44 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Jdlrobson moved this task from Ready for Signoff to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Jdrewniak moved this task from QA to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Sep 5 2023, 4:46 PM

Jdlrobson edited projects, added MW-1.41-notes (1.41.0-wmf.24; 2023-08-29); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 5 2023, 4:49 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Confirm no Pixel related UI regressions
Confirmed on Sept 5, and Sept 8.

✅ AC2: Exploratory testing: As an anonymous user, disable/enable fixed width across various pages confirming that it works consistently.
Verified, articles, search, talk, history, log in, create account, main page, edit, visual editor, user contributions, and file upload in Chrome, Safari, and Firefox.

Edtadros closed this task as Resolved.Sep 9 2023, 8:17 PM

Edtadros updated the task description. (Show Details)

Remove fixed width handling for cached HTMLClosed, ResolvedPublic1 Estimated Story PointsActions