Page MenuHomePhabricator

Clarify 2017 wikitext editor's Beta Feature status
Closed, ResolvedPublic

Description

I've been thinking about moving the 2017 wikitext editor out of Beta Features (while working on T335056), and I discovered that we've already accidentally done it in June, and no one noticed! In en.wp Special:Preferences you'll now find it under "Editing → Use the wikitext mode inside the visual editor", instead of under "Beta features". This hasn't caused anyone's default editor to change because in both modes the same internal preference is used (which is either very lucky, or great engineering :) ). The cause is change 927189, where apparently everyone misread the WMF config – because there's a one-letter difference between the variable that toggles the beta feature mode ($wg...), and the variable that toggles the default value of the checkbox ($wmg...) (not great engineering).

After consulting with @ppelberg, it seems that it was a happy accident and we'd like to keep it configured that way.

To do:

Event Timeline

Change 949588 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Clarify 2017 wikitext editor's Beta Feature status

https://gerrit.wikimedia.org/r/949588

Change 949588 merged by jenkins-bot:

[operations/mediawiki-config@master] Clarify 2017 wikitext editor's Beta Feature status

https://gerrit.wikimedia.org/r/949588

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:03:51Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:05:34Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codf

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:19:35Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]] (duration: 15m 43s)