Decommission the EchoMail and EchoInteraction instruments
Closed, ResolvedPublic
Actions

Description

According to the EventLogging Schema Audit spreadsheet, the EchoMail and EchoInteraction schemas were migrated to the Event Platform. When reviewing uses of the deprecated EventLogging::logEvent() method, however, I double-checked with the Growth team who all confirmed that the instruments could be decommissioned.

TODO

Remove all code that logs EchoMail and EchoInteraction events
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/949049/
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceEchoConnector/+/949048/
Mark the legacy EchoMail and EchoInteraction schemas as inactive
- https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AEchoMail&diff=25538079&oldid=13302833
- https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AEchoInteraction&diff=25538082&oldid=13304266
Remove the EchoMail and EchoInteraction event sanitisation allowlist entries
- https://gerrit.wikimedia.org/r/950183

Details

Subject	Repo	Branch	Lines +/-
Remove EchoMail and EchoInteraction event streams	operations/mediawiki-config	master	+0 -24
Disable EchoMail and EchoInteraction instruments	operations/mediawiki-config	master	+0 -5
Remove Echo* sanitisation allowlist entries	analytics/refinery	master	+0 -17
Decommission Echo* instruments	mediawiki/extensions/Echo	master	+0 -385
Remove MWEchoEventLogging::logSchemaEchoMail() calls	mediawiki/extensions/BlueSpiceEchoConnector	REL1_39-4.3.x	+0 -4
Remove MWEchoEventLogging::logSchemaEchoMail() calls	mediawiki/extensions/BlueSpiceEchoConnector	REL1_39	+0 -4
Remove MWEchoEventLogging::logSchemaEchoMail() calls	mediawiki/extensions/BlueSpiceEchoConnector	master	+0 -4
[Java] Remove refs to EchoMail and EchoInteraction	mediawiki/libs/metrics-platform	master	+0 -64

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Ottomata	T185233 Modern Event Platform
Open	Ottomata	T238230 Decommission EventLogging backend components by migrating to MEP
Declined	None	T259734 BUOD-KR1-Q4+: Certify that analytics schema and instruments have been upgraded to use the MEP system (clearing the legacy system for sunsetting)
Open	None	T259163 Migrate legacy metawiki schemas to Event Platform
Resolved	Ottomata	T282131 Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned
Resolved	phuedx	T344167 Decommission the EchoMail and EchoInteraction instruments

Event Timeline

phuedx created this task.Aug 14 2023, 3:17 PM

Restricted Application added projects: Growth-Team, Data-Engineering. · View Herald TranscriptAug 14 2023, 3:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Moving to Triaged on our end, but feel free to ping us if there's something we need to take an action on.

Change 949048 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/BlueSpiceEchoConnector@master] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/949048

Change 949049 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/Echo@master] Decommission Echo* instruments

https://gerrit.wikimedia.org/r/949049

Change 949050 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [Java] Remove refs to EchoMail and EchoInteraction

https://gerrit.wikimedia.org/r/949050

phuedx updated the task description. (Show Details)Aug 15 2023, 2:01 PM

Change 949050 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [Java] Remove refs to EchoMail and EchoInteraction

https://gerrit.wikimedia.org/r/949050

Change 950180 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Disable EchoMail and EchoInteraction instruments

https://gerrit.wikimedia.org/r/950180

Change 950183 had a related patch set uploaded (by Phuedx; author: Phuedx):

[analytics/refinery@master] Remove Echo* sanitisation allowlist entries

https://gerrit.wikimedia.org/r/950183

phuedx updated the task description. (Show Details)Aug 18 2023, 3:15 PM

@Mglaser @Osnard @ItSpiderman: You were added as reviewers for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceEchoConnector/+/949048 automatically. I'd like to understand how BlueSpice is using the instrument as I think these are the only instruments that I've decommissioned that are being used elsewhere. As you can see, I've submitted all of the patches required to both disable and remove the instruments. I can just as easily abandon the patches that remove the instruments or go through the formal deprecation process, if you'd prefer.

Thank you very much for reaching out to us. The provided patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceEchoConnector/+/949048) looks good. We are not really using those instruments.

Change 949048 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceEchoConnector@master] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/949048

Change 952428 had a related patch set uploaded (by Robert Vogel; author: Phuedx):

[mediawiki/extensions/BlueSpiceEchoConnector@REL1_39] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/952428

Change 952428 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceEchoConnector@REL1_39] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/952428

Change 952429 had a related patch set uploaded (by Robert Vogel; author: Phuedx):

[mediawiki/extensions/BlueSpiceEchoConnector@REL1_39-4.3.x] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/952429

Change 952429 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceEchoConnector@REL1_39-4.3.x] Remove MWEchoEventLogging::logSchemaEchoMail() calls

https://gerrit.wikimedia.org/r/952429

Osnard mentioned this in rEBTYbf9175cad457: Remove MWEchoEventLogging::logSchemaEchoMail() calls.Aug 25 2023, 1:22 PM

Osnard mentioned this in rEBTY7f75db24f72d: Remove MWEchoEventLogging::logSchemaEchoMail() calls.

Osnard mentioned this in rEBTYc3a358e54dfd: Remove MWEchoEventLogging::logSchemaEchoMail() calls.

Change 949049 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Decommission Echo* instruments

https://gerrit.wikimedia.org/r/949049

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 6:01 AM

phuedx updated the task description. (Show Details)Aug 30 2023, 8:40 AM

phuedx updated the task description. (Show Details)Aug 30 2023, 8:49 AM

phuedx updated the task description. (Show Details)

phuedx updated the task description. (Show Details)Aug 30 2023, 9:07 AM

Request the deletion of any previously logged data, if necessary

Any previously–logged, unsantised data will be deleted after 90 days.

Change 950183 merged by Mforns:

[analytics/refinery@master] Remove Echo* sanitisation allowlist entries

https://gerrit.wikimedia.org/r/950183

Being bold.

Change 950180 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable EchoMail and EchoInteraction instruments

https://gerrit.wikimedia.org/r/950180

Mentioned in SAL (#wikimedia-operations) [2023-09-05T13:02:43Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:950180|Disable EchoMail and EchoInteraction instruments (T344167)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-05T13:04:18Z] <taavi@deploy1002> taavi and phuedx: Backport for [[gerrit:950180|Disable EchoMail and EchoInteraction instruments (T344167)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 1:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-05T13:12:57Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:950180|Disable EchoMail and EchoInteraction instruments (T344167)]] (duration: 10m 14s)

Samwalton9-WMF mentioned this in T347060: Investigate old Echo EventLogging data for TheWikipediaLibrary notification.Sep 21 2023, 2:09 PM

Change 975394 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Remove EchoMail and EchoInteraction event streams

https://gerrit.wikimedia.org/r/975394

gerritbot added a project: Patch-For-Review.Nov 18 2023, 10:37 AM

Change 975394 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove EchoMail and EchoInteraction event streams

https://gerrit.wikimedia.org/r/975394

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:09:06Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:975394|Remove EchoMail and EchoInteraction event streams (T344167)]]

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:10:30Z] <lucaswerkmeister-wmde@deploy2002> phuedx and lucaswerkmeister-wmde: Backport for [[gerrit:975394|Remove EchoMail and EchoInteraction event streams (T344167)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:19:12Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:975394|Remove EchoMail and EchoInteraction event streams (T344167)]] (duration: 10m 05s)

Decommission the EchoMail and EchoInteraction instrumentsClosed, ResolvedPublicActions