Make Metrics Platform Client record agent context attributes by default
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Aug 15 2023, 2:37 PM

Description

Ronseal.

AC

Determine which agent context attributes should be recorded by default
Make all of the clients record them by default
- PHP
- Java
- JS Done™ (see https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/blob/main/js/src/ContextController.js#L32)

Notes

While investigating this task, I noticed that the JS MPC records the following context attributes by default:
1. agent_client_platform
2. agent_client_platform_family

Related Objects
Search...

Status	Assigned	Task
Resolved	cjming	T344254 Make Metrics Platform Client record agent context attributes by default
Declined	phuedx	T343828 Update agent schema/fragment
Open	None	T311629 Change agent_client_platform_family context attribute values

Event Timeline

phuedx created this task.Aug 15 2023, 2:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2023, 2:37 PM

phuedx updated the task description. (Show Details)Aug 15 2023, 2:37 PM

phuedx updated the task description. (Show Details)

phuedx added subtasks: T343828: Update agent schema/fragment, T311629: Change agent_client_platform_family context attribute values.

phuedx mentioned this in T343331: Audit existing schemas to identify Core Interactions.Aug 16 2023, 10:35 AM

phuedx closed subtask T343828: Update agent schema/fragment as Declined.Aug 22 2023, 7:11 PM

phuedx added a project: Data Products.Sep 14 2023, 12:24 PM

phuedx moved this task from Incoming to Sprint 01 on the Data Products board.

phuedx edited projects, added Data Products (Sprint 01); removed Data Products.

VirginiaPoundstone set the point value for this task to 3.Sep 14 2023, 1:31 PM

cjming claimed this task.Oct 2 2023, 11:10 PM

cjming moved this task from Sprint Backlog to In Process on the Data Products (Sprint 01) board.

cjming moved this task from Sprint 01 to Sprint 02 on the Data Products board.Oct 3 2023, 1:38 PM

cjming edited projects, added Data Products (Sprint 02); removed Data Products (Sprint 01).

cjming moved this task from Sprint 02 to Sprint 01 on the Data Products board.

cjming edited projects, added Data Products (Sprint 01); removed Data Products (Sprint 02).

cjming moved this task from Sprint 01 to Sprint 02 on the Data Products board.Oct 3 2023, 1:43 PM

cjming edited projects, added Data Products (Sprint 02); removed Data Products (Sprint 01).

phuedx moved this task from Sprint Backlog to In Process on the Data Products (Sprint 02) board.Oct 3 2023, 1:43 PM

@phuedx is this resolved if we make the agent data object required in https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/952252/19/jsonschema/fragment/analytics/metrics_platform/common/current.yaml ?

@cjming: Does the Java client library always submit information about the agent regardless of stream configuration? If so, then only the PHP client library needs to be updated (see https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/blob/main/php/src/ContextController.php vs https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/blob/main/js/src/ContextController.js#L32).

phuedx updated the task description. (Show Details)Oct 10 2023, 8:32 AM

phuedx updated the task description. (Show Details)

cjming moved this task from In Process to Sprint Backlog on the Data Products (Sprint 02) board.Oct 11 2023, 2:27 PM

cjming moved this task from Sprint Backlog to In Process on the Data Products (Sprint 02) board.Oct 17 2023, 5:00 AM

cjming moved this task from In Process to Sprint Backlog on the Data Products (Sprint 02) board.

WDoranWMF triaged this task as Medium priority.Oct 17 2023, 12:23 PM

cjming moved this task from Sprint Backlog to In Process on the Data Products (Sprint 02) board.Oct 18 2023, 6:51 PM

In T344254#9237713, @phuedx wrote:

@cjming: Does the Java client library always submit information about the agent regardless of stream configuration?

Somehow I missed this -- it does not so I hope it's ok I snuck it into the current MR that's under review:
https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/6#note_56371