Top align buttons (expand/collapse and ellipsis) within mobile headings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Esanders
	Aug 21 2023, 4:50 PM

Description

When scanning titles your eye starts in the top left, which is the natural place for the expand action to go. Similarly the ellipsis should be top aligned on the right hand side.

Before	After

This is also how we align the subscribe button on desktop:

And how buttons are aligned on mobile apps:

Talk page	Article

(iOS is the same)

Details

	Subject	Repo	Branch	Lines +/-
	Use top alignment for buttons on mobile talk pages	mediawiki/extensions/DiscussionTools	master	+9 -5

Customize query in gerrit

Related Objects

Mentioned In: T351044: DiscussionTools: Expand section arrow is misplaced on mobile
Mentioned Here: T351044: DiscussionTools: Expand section arrow is misplaced on mobile

Event Timeline

• Esanders created this task.Aug 21 2023, 4:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2023, 4:50 PM

• Esanders added a subscriber: nayoub.Aug 21 2023, 4:50 PM

ppelberg added projects: Design, Editing-team.Aug 24 2023, 3:07 PM

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Great point, thank you @Esanders – I agree with the new alignment you're proposing.

Change 952257 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Use top alignment for buttons on mobile talk pages

https://gerrit.wikimedia.org/r/952257

gerritbot added a project: Patch-For-Review.Aug 24 2023, 4:59 PM

Change 952257 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use top alignment for buttons on mobile talk pages

https://gerrit.wikimedia.org/r/952257

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2023, 9:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 3 2023, 10:00 PM

• Esanders edited projects, added Editing-team (Kanban Board); removed Editing-team.Nov 4 2023, 11:41 AM

• Esanders moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

• Esanders added a project: Editing QA.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 5 2023, 12:35 AM

Ryasmeen edited projects, added Verified; removed Editing QA.

There's a new bug that I think might be related to this change? From a user-report at Enwiki:

Are my [expand / collapse][chevrons / carets] supposed to be misaligned with the section headings now on Minerva? (Android + Firefox, duplicated in Chrome). Just wondering if this is intentional.

Screenshot: