Page MenuHomePhabricator

Unable to inspect Global rename script log entries on enwiki
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Log entries are not shown and instead the error that "Global rename script does not exist." is shown

What should have happened instead?:
Log entries should be shown as entries are shown via the API.

Software version (skip for WMF-hosted wikis like Wikipedia):
English Wikipedia

Other information (browser name/version, screenshots, etc.):
As this can be used as the performer when running fixStuckGlobalRename.php script or as part of LocalRenameJob::getRenameUser. This therefore means that it is stopping me from being able to debug T343983 effectively, as I cannot verify if the performer of the un-stuck renames was this system user.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 951177 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Create the 'Global rename script' system user when needed

https://gerrit.wikimedia.org/r/951177

Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)

Indirectly broken by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/934458 with the addition of 'exists' => true.
There are log entries also under non-existing user names: When rename get broken, user merges, very old entries, system users, after deletion via maintenance script.
As the logs are a history, there should be a listing even for non existing values, a error for invalid values is okay.
It would be okay to say the user does not exists, like done on Special:Contributions, but when there is a actor id the query should be done.

Change 951177 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Create the 'Global rename script' system user when needed

https://gerrit.wikimedia.org/r/951177

This patch will avoid the issue for any future uses of the fixStuckGlobalRename.php script, but we'll need to do something to fix the existing log entries. I think we just need to run User::newSystemUser( 'Global rename script' ) on every wiki, and that will create the user and magically assign the log entries to it. There doesn't seem to be a maintenance script that allows doing this, so I guess I'll need to write one (or maybe add an option to fixStuckGlobalRename.php).

Indirectly broken by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/934458 with the addition of 'exists' => true.
There are log entries also under non-existing user names: When rename get broken, user merges, very old entries, system users, after deletion via maintenance script.
As the logs are a history, there should be a listing even for non existing values, a error for invalid values is okay.
It would be okay to say the user does not exists, like done on Special:Contributions, but when there is a actor id the query should be done.

I filed this as T344773 – it's worth fixing, but I think we should also fix the missing 'Global rename script' system user, which will resolve the problem as well.

Change 951963 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Add option to just create the 'Global rename script' system user

https://gerrit.wikimedia.org/r/951963

Change 952132 had a related patch set uploaded (by Krinkle; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.23] Add option to just create the 'Global rename script' system user

https://gerrit.wikimedia.org/r/952132

Change 952132 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.23] Add option to just create the 'Global rename script' system user

https://gerrit.wikimedia.org/r/952132

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:45:47Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:47:14Z] <thcipriani@deploy1002> thcipriani and jdrewniak and krinkle: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:58:19Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]] (duration: 12m 31s)

@Krinkle suggested not merging the change into master, but only the current WMF branch, and running the script, since we'll only need to do it once. This is now done (https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=2104245). I can view the list at https://en.wikipedia.org/wiki/Special:Log/Global_rename_script.

Change 951963 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/CentralAuth@master] Add option to just create the 'Global rename script' system user

Reason:

Script already ran, no longer needed

https://gerrit.wikimedia.org/r/951963