MinervaNeue: Watchstar missing for anonymous users
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	Jdrewniak
	Aug 23 2023, 10:26 PM

Description

The MinervaNeue skin displays a watchstar for anonymous users, which when clicked, presents a modal encouraging users to create an account or login.
Since Mediawiki wmf/1.41.0-wmf.23 (Tuesday, August 22) the watchstar no longer appears.
e.g. on beta

Screenshot 2023-08-23 at 6.19.32 PM.png (1×2 px, 369 KB)

vs enwiki

Screenshot 2023-08-23 at 6.19.50 PM.png (1×2 px, 327 KB)

This appears to be introduced by the following commit (Since the watchstar does appear when on the prior commit):
watchlist: Prepare for IP Masking

This may be related, or a follow-up to T330518.

A/C

Environment: mobile web, minerva skin

As an anonymous user, verify that the watchstar is visible on article pages. Clicking the watchstar should reveal a modal from the bottom of the page encouraging users to sign up.
As a logged in user, verify that the watchstar still works: When clicked, it should add a page to the watchlist (either permanently or temporarily), and clicked again, it should remove the page from the watchlist.

QA Results - Beta

AC	Status	Details
1	✅	T344870#9124399
2	✅	T344870#9124399

QA Results - Prod

AC	Status	Details
1	✅	T344870#9151439
2	✅	T344870#9151439

Details

	Subject	Repo	Branch	Lines +/-
	watchlist: Don't assume only named users have watchlist access	mediawiki/skins/MinervaNeue	wmf/1.41.0-wmf.23	+17 -8
	watchlist: Don't assume only named users have watchlist access	mediawiki/skins/MinervaNeue	master	+17 -8

Customize query in gerrit

Related Objects

Mentioned In: T344925: MinervaNeue incorrectly passes data-mw=interface to watchstar even when it is not used for action=watch requests
T344632: Unable to inspect Global rename script log entries on enwiki
Mentioned Here: T344632: Unable to inspect Global rename script log entries on enwiki
T344925: MinervaNeue incorrectly passes data-mw=interface to watchstar even when it is not used for action=watch requests
T330518: [IP masking] The watchstar shows in the Minerva skin

Event Timeline

Jdrewniak created this task.Aug 23 2023, 10:26 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 23 2023, 10:26 PM

Change 952120 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/skins/MinervaNeue@master] watchlist: Do not assume users have to be named to have access to watchlist

https://gerrit.wikimedia.org/r/952120

gerritbot added a project: Patch-For-Review.Aug 24 2023, 8:48 AM

This happened, because MinervaNeue (incorrectly) assumed all users have the viewmywatchlist and editmywatchlist permissions, but only named users have access to watchlist. Core changed that assumption in the commit you linked, which broke Minerva. I uploaded a patch to fix this -- please test as needed.

My patch should fix the reported issue. I discovered an alternate one and filled as T344925. Patch TBD.

ovasileva triaged this task as High priority.Aug 24 2023, 2:44 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Jdrewniak claimed this task.Aug 24 2023, 3:01 PM

Jdrewniak moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Jdrewniak moved this task from Web Team FY2023-24 Q1 Sprint 5 to Web Team FY2023-24 Q1 Sprint 4 on the Web-Team-Backlog board.

Jdrewniak edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5).

Jdrewniak moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

Change 952120 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] watchlist: Don't assume only named users have watchlist access

https://gerrit.wikimedia.org/r/952120

Change 952130 had a related patch set uploaded (by Jdrewniak; author: Urbanecm):

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.23] watchlist: Don't assume only named users have watchlist access

https://gerrit.wikimedia.org/r/952130

ovasileva set the point value for this task to 2.Aug 24 2023, 4:47 PM

Change 952130 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.23] watchlist: Don't assume only named users have watchlist access

https://gerrit.wikimedia.org/r/952130

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2023, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:45:47Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:47:14Z] <thcipriani@deploy1002> thcipriani and jdrewniak and krinkle: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (

Mentioned in SAL (#wikimedia-operations) [2023-08-24T20:58:19Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:952132|Add option to just create the 'Global rename script' system user (T344632)]], [[gerrit:952130|watchlist: Don't assume only named users have watchlist access (T344870)]] (duration: 12m 31s)

Jdrewniak reassigned this task from Jdrewniak to Edtadros.Aug 25 2023, 2:21 PM

Jdrewniak updated the task description. (Show Details)

Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: As an anonymous user, verify that the watchstar is visible on article pages. Clicking the watchstar should reveal a modal from the bottom of the page encouraging users to sign up.

Screen Recording 2023-08-28 at 9.53.07 AM.mov.gif (770×1 px, 842 KB)

✅ AC2: As a logged in user, verify that the watchstar still works: When clicked, it should add a page to the watchlist (either permanently or temporarily), and clicked again, it should remove the page from the watchlist.

Screen Recording 2023-08-28 at 9.53.51 AM.mov.gif (770×1 px, 695 KB)

Edtadros updated the task description. (Show Details)Aug 28 2023, 4:56 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 2:02 AM

Urbanecm_WMF mentioned this in T344925: MinervaNeue incorrectly passes data-mw=interface to watchstar even when it is not used for action=watch requests.Aug 30 2023, 7:12 PM

Looks good

Jdlrobson assigned this task to Edtadros.Sep 5 2023, 5:40 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: As an anonymous user, verify that the watchstar is visible on article pages. Clicking the watchstar should reveal a modal from the bottom of the page encouraging users to sign up.

Edtadros updated the task description. (Show Details)Sep 8 2023, 1:06 AM

	F37638863: Screen Recording 2023-08-28 at 9.53.51 AM.mov.gif
	Aug 28 2023, 4:55 PM

	F37638861: Screen Recording 2023-08-28 at 9.53.07 AM.mov.gif
	Aug 28 2023, 4:55 PM

	F37623841: Screenshot 2023-08-23 at 6.19.50 PM.png
	Aug 23 2023, 10:26 PM

	F37623839: Screenshot 2023-08-23 at 6.19.32 PM.png
	Aug 23 2023, 10:26 PM

MinervaNeue: Watchstar missing for anonymous usersClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

A/C

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

MinervaNeue: Watchstar missing for anonymous users
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions