Page MenuHomePhabricator
Create Task
Maniphest T345306

undo and thank buttons unstyled on history page
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
None
Authored By
Edu
Aug 30 2023, 11:00 PM
Tags
Referenced Files
F37722406: screenshot 34.png
Sep 14 2023, 4:33 PM
F37677052: screenshot 25.png
Sep 9 2023, 12:32 AM
F37649363: Screenshot_20230902-213325.jpg
Sep 3 2023, 12:38 AM
F37649295: Polish_20230902_200306049.jpg
Sep 3 2023, 12:38 AM
Unknown Object (File)
Aug 31 2023, 1:39 AM
F37643803: Screenshot_20230830-223042.jpg
Aug 31 2023, 1:39 AM
F37643559: Screenshot_20230830-195459.jpg
Aug 30 2023, 11:00 PM
Subscribers
Aklapper
bwang
Edtadros
Edu
Jdlrobson
• Mabualruz
Masumrezarock100

Description

Steps to replicate the issue (include links if applicable):

  • Access the mobile version of Wikipedia; log in
  • Open the menu, click "settings", enable "advanced mode"
  • Go to any page and view the history

What happens?:

  • The "undo" and "thanks" buttons lost their previous style. Currently they have a gray background, with no border.

Polish_20230902_200306049.jpg (960×540 px, 148 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T345306#9153920
2✅T345306#9153920

QA Results - Prod

ACStatusDetails
1✅T345306#9167515
2✅T345306#9167515

Details

SubjectRepoBranchLines +/-
Restore mw-ui-button styles to history page buttonsmediawiki/skins/MinervaNeuemaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Edu created this task.Aug 30 2023, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2023, 11:00 PM
Edu updated the task description. (Show Details)Aug 30 2023, 11:04 PM
Edu renamed this task from mobile version side menu lost style to undo and thank buttons, links and menu with broken styles on mobile version .Aug 31 2023, 1:39 AM
Edu triaged this task as Medium priority.
Edu updated the task description. (Show Details)
Aklapper changed the task status from Open to Stalled.Sep 1 2023, 9:22 AM

Please provide all required information. I don't know how to be able to see what you are seeing, for example there are three buttons at the bottom.

Edu updated the task description. (Show Details)Sep 3 2023, 12:38 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptSep 3 2023, 12:38 AM
Edu added a comment.Sep 3 2023, 12:39 AM

@Aklapper I updated the description. Is it better understandable now?

Edu attached a referenced file: F37649295: Polish_20230902_200306049.jpg. (Show Details)Sep 3 2023, 12:40 AM
Aklapper changed the task status from Stalled to Open.Sep 3 2023, 9:44 AM
Aklapper raised the priority of this task from Medium to Needs Triage.
Jdlrobson added a project: Web-Team-Backlog.Sep 5 2023, 3:28 PM
Jdlrobson subscribed.

There appears to be three bugs here.

  1. T345483
    1. I was also able to replicate the unstyled menu issue but now it has resolved itself so I think this was a caching issue. Are you still able to replicate this?
  1. I'll use this ticket for the unstyled buttons on the history page
ovasileva triaged this task as High priority.Sep 5 2023, 5:08 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog.
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5).
Jdlrobson renamed this task from undo and thank buttons, links and menu with broken styles on mobile version to undo and thank buttons unstyled on history page.Sep 5 2023, 5:12 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.

@bwang to provide context

ovasileva set the point value for this task to 1.Sep 5 2023, 5:23 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog.
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.
bwang added a comment.Sep 5 2023, 5:48 PM

We decided the short term fix for this task was to partially revert the changes described here, basically adding back the core button mixins. This should restore the original styles to these buttons

bwang mentioned this in T345768: Remove skin specific history page styles for Minerva.Sep 6 2023, 6:43 PM
bwang claimed this task.Sep 6 2023, 9:42 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Sep 6 2023, 10:11 PM
bwang removed bwang as the assignee of this task.Sep 7 2023, 4:55 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.
gerritbot added a comment.Sep 7 2023, 4:55 PM

Change 955812 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Restore mw-ui-button styles to history page buttons

https://gerrit.wikimedia.org/r/955812

gerritbot added a project: Patch-For-Review.Sep 7 2023, 4:55 PM
Jdlrobson assigned this task to Edtadros.Sep 7 2023, 5:54 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.
gerritbot added a comment.Sep 7 2023, 6:16 PM

Change 955812 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore mw-ui-button styles to history page buttons

https://gerrit.wikimedia.org/r/955812

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2023, 6:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 7 2023, 7:00 PM
Edtadros removed Edtadros as the assignee of this task.Sep 9 2023, 12:32 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Access the mobile version of Wikipedia; log in
Open the menu, click "settings", enable "advanced mode"
Go to any page and view the history
✅ AC1: Notification should show a red circle.
✅ AC2: Thank and Undo buttons on history page should have a border.

screenshot 25.png (918×419 px, 94 KB)

Edtadros updated the task description. (Show Details)Sep 9 2023, 12:33 AM
• Mabualruz claimed this task.Sep 10 2023, 3:38 PM

LGTM I will move it to QA Prod

• Mabualruz removed • Mabualruz as the assignee of this task.Sep 10 2023, 3:38 PM
• Mabualruz moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.
• Mabualruz subscribed.
Jdlrobson assigned this task to Edtadros.Sep 12 2023, 4:01 PM
Edtadros closed this task as Resolved.Sep 14 2023, 4:33 PM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Access the mobile version of Wikipedia; log in
Open the menu, click "settings", enable "advanced mode"
Go to any page and view the history
✅ AC1: Notification should show a red circle.
✅ AC2: Thank and Undo buttons on history page should have a border.

screenshot 34.png (806×427 px, 80 KB)

Edtadros updated the task description. (Show Details)Sep 14 2023, 4:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL