Page MenuHomePhabricator

SX: Confirmation step should be displayed when continuing in-progress page translations
Open, In Progress, MediumPublic

Description

Currently when a draft page translation (either lead section translation or page translation created in CX) is selected inside the dashboard or the article search screens, the user is navigated directly to the "Pick a sentence" step.

However, it would be preferable to display the confirmation step first, so that the user can select their preferred target language. This ticket proposes that the confirmation step should be displayed with the below adjustments:

Standard Confirmation step for new articlesProposed Confirmation step for new articles when there is a translation for them
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&from=en&pag.png (568×320 px, 186 KB)
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&from=en (1).png (568×320 px, 186 KB)

Scenario to test:

  1. Visit Section Translation application
  2. Open the in-progress list and select a page translation - that is either lead section translation or page translation created in CX - to continue. (You may need to create one such draft translation if there is none in your "in-progress" list.)
  3. The confirmation step appears, with a "Continue translation" button present
  4. Clicking on the "Continue translation" button navigates the user to the "Pick a sentence" step
  5. Changing the target language lets the user to create a new translation as usual.

Event Timeline

ngkountas triaged this task as Medium priority.Aug 31 2023, 10:12 AM
ngkountas added a project: SectionTranslation.

@Pginer-WMF regarding this task, I was wondering what should be the behaviour when the language pair of the draft translation is different from the current language pair of the application! Should we just redirect to the target wiki when the draft translation target language is different from the current wiki language? What should be the case for different source language?

@Pginer-WMF regarding this task, I was wondering what should be the behaviour when the language pair of the draft translation is different from the current language pair of the application! Should we just redirect to the target wiki when the draft translation target language is different from the current wiki language? What should be the case for different source language?

The translation editor is expected to always be accessed for the target wiki (so that it is able to publish contents there).
At the confirmation step users should be able to change the language pair for the new translation. Once they proceed, a redirect will led them to the target wiki. We can decide which is the best point to do the redirect. I think that ideally it should happen with the transition to the editor. That is, users could go through the pick a section process in the initial wiki and get redirected as they reach the editor. But we can explore other points if they are more viable technically.

Regarding the source language, it is not expected to affect the redirect, just affect the source where contents are loaded from.

Hope this helps to clarify, but feel free to share further questions if needed.

@Pginer-WMF Currently, for production wikis, the target language inside the language selectors, is always the language of the current wiki. If the target language changes (for production wikis), the user is redirected to the new target wiki. Inside the confirmation step there is a language selector. If we want to redirect to the confirmation step when clicking on a draft translation, and if the draft translation has a different target language, which target language should we display inside the language selector? The language of the draft translation or the current wiki language? If we need to display the language of the draft translation, we would need to change the way we are treating language selectors and the selected language pair. This is feasible, but definitely not a minor task. Do you want me to investigate this option?

Change 1013244 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX SectionSuggestion: Add isListable property and use it where needed

https://gerrit.wikimedia.org/r/1013244

Change 1012992 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Use URL params for language pair and page title

https://gerrit.wikimedia.org/r/1012992

Change #1012992 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Use URL params for language pair and page title

https://gerrit.wikimedia.org/r/1012992

Change #1013370 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Add useTargetPageExists composable

https://gerrit.wikimedia.org/r/1013370

Change #1014697 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Display confirmation step when continuing a draft translation

https://gerrit.wikimedia.org/r/1014697

Change #1013244 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX SectionSuggestion: Add isListable property and use it where needed

https://gerrit.wikimedia.org/r/1013244

Change #1013370 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add useLanguageTitleGroup composable

https://gerrit.wikimedia.org/r/1013370

Change #1015979 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979

Change #1014697 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Display confirmation step when continuing a draft translation

https://gerrit.wikimedia.org/r/1014697

Change #1015979 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979