Page MenuHomePhabricator
Create Task
Maniphest T345569

Notification that a temporary account has been created appears when already logged-in and creating a page with DiscussionTools
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to https://translatewiki.net/ and log in
  • Go to a talk page that doesn't exist yet
  • Start and post a new topic using DiscussionTools ("Add topic" button)
    • (bonus points if you tag that page with the {{delete}} template after you've tested)

What happens?:

  • A notification appears saying that a temporary user account has been created for me, even though I am already logged in with my regular account (see screenshot)

Screenshot_20230904_160507.png (401×661 px, 32 KB)

What should have happened instead?:

  • No such notification should appear.

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.41.0-alpha

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Fix temp user popup appearing on every new page creationmediawiki/extensions/DiscussionToolswmf/1.41.0-wmf.25+5 -4
Fix temp user popup appearing on every new page creationmediawiki/extensions/DiscussionToolsmaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

jhsoby created this task.Sep 4 2023, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2023, 2:11 PM
jhsoby updated the task description. (Show Details)Sep 4 2023, 2:12 PM
MarcoAurelio subscribed.Sep 4 2023, 2:17 PM

I can reproduce the reported bug as well:

imagen.png (302×1 px, 57 KB)

jhsoby added a subscriber: matmarex.Sep 4 2023, 2:30 PM

@matmarex Maybe this is related to T344879 somehow?

matmarex claimed this task.Sep 4 2023, 3:04 PM

Oops, probably.

gerritbot added a comment.Sep 4 2023, 3:17 PM

Change 954706 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix temp user popup appearing on every new page creation

https://gerrit.wikimedia.org/r/954706

gerritbot added a project: Patch-For-Review.Sep 4 2023, 3:17 PM
matmarex added a project: Editing-team (Kanban Board).Sep 4 2023, 3:18 PM
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex added a parent task: T343727: 1.41.0-wmf.25 deployment blockers.

(wmf.25 is not deployed to any Wikimedia wikis yet)

RhinosF1 subscribed.Sep 5 2023, 8:56 AM
gerritbot added a comment.Sep 5 2023, 2:12 PM

Change 954706 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix temp user popup appearing on every new page creation

https://gerrit.wikimedia.org/r/954706

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 2:29 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 5 2023, 3:00 PM
jeena subscribed.Sep 5 2023, 5:39 PM

I think this needs to be backported since the branch commit for wmf.25 already happened before merge

gerritbot added a comment.Sep 5 2023, 7:22 PM

Change 954943 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.25] Fix temp user popup appearing on every new page creation

https://gerrit.wikimedia.org/r/954943

gerritbot added a project: Patch-For-Review.Sep 5 2023, 7:22 PM
gerritbot added a comment.Sep 5 2023, 8:19 PM

Change 954943 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.25] Fix temp user popup appearing on every new page creation

https://gerrit.wikimedia.org/r/954943

Stashbot added a comment.Sep 5 2023, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:20:28Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:954943|Fix temp user popup appearing on every new page creation (T345569)]]

Stashbot added a comment.Sep 5 2023, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:22:01Z] <cjming@deploy1002> cjming and matmarex: Backport for [[gerrit:954943|Fix temp user popup appearing on every new page creation (T345569)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 8:30 PM
Stashbot added a comment.Sep 5 2023, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:32:06Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:954943|Fix temp user popup appearing on every new page creation (T345569)]] (duration: 11m 37s)

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 5 2023, 8:47 PM
matmarex added a project: Editing QA.
matmarex removed a parent task: T343727: 1.41.0-wmf.25 deployment blockers.

Should be resolved now. Thanks for the report @jhsoby!

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 5 2023, 9:00 PM
jhsoby added a comment.Sep 5 2023, 10:41 PM

No probs. Thank you for the quick fix, @matmarex!

EAkinloose removed a project: Editing QA.Oct 30 2023, 8:57 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex added a project: Verified.Nov 27 2023, 7:40 PM
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL