It should be possible to enable font size through a URL
Closed, DeclinedPublic2 Estimated Story Points
Actions

Assigned To

None

Authored By

	Jdlrobson
	Oct 2 2023, 6:56 PM

Description

Currently it is not possible to force on certain features on via a query string. This got broken when we expanded our feature management to support beta features. In particular this impacts fontsize and pinning functionality.

For example:
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=3 should provide large font size but doesn't - it provides whatever the user specified.

https://en.wikipedia.org/wiki/Spain?vectorpagetoolspinned=1 in an incognito window should show the page tools pinned but doesn't.

QA

Check all the following URLs work for both anons and logged in

QA Results - Beta

AC	Status	Details
1	❌	T347900#9270529
2	❌	T347900#9270529

Details

	Subject	Repo	Branch	Lines +/-
	Allow user preferences to be overriden by query string parameter	mediawiki/skins/Vector	master	+119 -25

Customize query in gerrit

Related Objects

Mentioned In: T357329: Vector query string is not behaving as expected
T345664: How should client preferences work for logged in users?
T348357: Verify 1.42.0-wmf.1 deployment
Mentioned Here: T346954: Font size should support multiple font size
T317900: [PageTools] Make the new main menu pinnable
T318002: Refactor Table of Contents styles

Event Timeline

Jdlrobson created this task.Oct 2 2023, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2023, 6:56 PM

Change 962666 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Allow user preferences to be overriden by query string parameter

https://gerrit.wikimedia.org/r/962666

gerritbot added a project: Patch-For-Review.Oct 2 2023, 6:56 PM

ovasileva triaged this task as High priority.Oct 9 2023, 9:53 AM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.

ovasileva lowered the priority of this task from High to Medium.Oct 10 2023, 5:25 PM

ovasileva set the point value for this task to 2.

Jdlrobson updated the task description. (Show Details)Oct 10 2023, 5:28 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 6:42 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 8:26 PM

Jdrewniak assigned this task to • Mabualruz.Oct 12 2023, 4:53 PM

• Mabualruz removed • Mabualruz as the assignee of this task.Oct 13 2023, 5:19 PM

• Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.

• Mabualruz subscribed.

Change 962666 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Allow user preferences to be overriden by query string parameter

https://gerrit.wikimedia.org/r/962666

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 13 2023, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2023, 6:11 PM

Jdlrobson assigned this task to Edtadros.Oct 13 2023, 6:41 PM

Jdlrobson updated the task description. (Show Details)Oct 19 2023, 8:34 PM

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

❌ AC1: Anon

✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=0	per T317900 the main menu is unpinned when it is in the hidden in the hamburger menu
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=1	per T317900 the main menu is pinned when it is in the sidebar
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=0	per T318002#9197113 unpinned is in a drop down...so this is ok.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=1	per T318002#9197113 unpinned is in a drop down, I expected this to place the page tools in the sidebar.
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=0
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=1
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=0	see below
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=1	the query param seems to change the icon in the lower left but doesn't impact the limited/full width of the text
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=0	per T318002#9197113 unpinned is not in the sidebar. I'm not sure this is doing anything.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=1	per T318002#9197113 unpinned is in the sidebar. I'm not sure this is doing anything.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=0	This may work, but since the others didn't to be safe I'm marking this as a fail.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=1	Font size is unchanged.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=2	Font size is unchanged.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=3	Font size is unchanged.

❌ AC2: Logged In

✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=0	per T317900 the main menu is unpinned when it is in the hidden in the hamburger menu
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=1	per T317900 the main menu is pinned when it is in the sidebar
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=0	per T318002#9197113 unpinned is in a drop down.
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=1	per T318002#9197113 unpinned is in a drop down.
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=0
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=0	see below
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=1
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=0	per T318002#9197113 unpinned is not in the sidebar. see below
✅	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=1	per T318002#9197113 unpinned is in the sidebar.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=0	Not sure if this is a pass or not. It's the only one that changes the font size. But one would expect it to do nothing. See below.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=1	Not sure if this is a pass or not. I'm not sure if it is making the font larger than vectorcustomfontsize=0 or it's doing nothing. See below.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=2	See below.
❌	https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=3

Edtadros updated the task description. (Show Details)Oct 22 2023, 2:16 AM

Edtadros mentioned this in T348357: Verify 1.42.0-wmf.1 deployment.Oct 22 2023, 8:18 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 23 2023, 5:19 PM

@ovasileva we decided not to carry this over, as it seems to have been caused by the client preferences work. It would be good to sync with MediaWiki platform team before committing to this work. We'll also want to rewrite this task with the following in mind:

@Mabualruz it looks like the font size was broken by I6afa39624c3cadd31632d63a36b919d641983ae6 (T346954)
@Edtadros limited width looks like a pass to me. (Can you double check that)
Sticky header, page tools, doesn't look like it has been written to work with anonymous users (these are logged in only features). So these might be expected behaviour and we'll want to descope it.
Table of contents does work for anonymous users so I'd expect that to work.

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2).Oct 23 2023, 5:53 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Oct 26 2023, 5:38 PM

Jdlrobson mentioned this in T345664: How should client preferences work for logged in users?.Oct 27 2023, 8:52 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 2 2023, 5:51 PM

Jdlrobson moved this task from Incoming to typography/darkmode on the Desktop Improvements (Vector 2022) board.Nov 3 2023, 7:09 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4).Nov 20 2023, 6:38 PM

Jdlrobson moved this task from Incoming to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:03 PM

Jdlrobson moved this task from Doing to Incoming on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:06 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q2 Sprint 5).Dec 4 2023, 8:46 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:21 AM

Moving to sprint 2. @Jdlrobson - could you update the task description with the current state of this ticket and the general case for query string parameters?

Jdlrobson updated the task description. (Show Details)Jan 4 2024, 4:42 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 2).Jan 29 2024, 7:02 PM

Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.Feb 1 2024, 7:21 PM

We may need this to test Vector's night mode

So far we've not hit this with night mode so I think we can punt this to when we need it and lower priority.

Jdlrobson moved this task from Backlog to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 9 2024, 6:31 PM

bwang mentioned this in T357329: Vector query string is not behaving as expected.Feb 12 2024, 6:49 PM

Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 5 on the Web-Team-Backlog board.Feb 12 2024, 9:17 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)Feb 14 2024, 4:38 PM

Change 1003463 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: FeatureVariants

https://gerrit.wikimedia.org/r/1003463

gerritbot added a project: Patch-For-Review.Feb 14 2024, 4:38 PM

Jdlrobson renamed this task from It should be possible to enable font size and typography prototype overlay through a URL to It should be possible to enable font size through a URL.Feb 14 2024, 5:10 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Feb 29 2024, 7:28 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 7 2024, 7:22 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 6).Mar 19 2024, 9:31 PM

Doesn't seem like we'll need this right now.

	F39378870: screenshot 101.2.gif
	Oct 22 2023, 2:15 AM

It should be possible to enable font size through a URLClosed, DeclinedPublic2 Estimated Story PointsActions