Page MenuHomePhabricator

It should be possible to enable font size through a URL
Open, MediumPublic2 Estimated Story Points

Description

Currently it is not possible to force on certain features on via a query string. This got broken when we expanded our feature management to support beta features. In particular this impacts fontsize and pinning functionality.

For example:
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=3 should provide large font size but doesn't - it provides whatever the user specified.

https://en.wikipedia.org/wiki/Spain?vectorpagetoolspinned=1 in an incognito window should show the page tools pinned but doesn't.

QA

Check all the following URLs work for both anons and logged in

https://en.wikipedia.org/wiki/Spain?vectornightmode=0
https://en.wikipedia.org/wiki/Spain?vectornightmode=1
https://en.wikipedia.org/wiki/Spain?vectornightmode=2
https://en.wikipedia.org/wiki/Spain?vectorclientpreferences=0
https://en.wikipedia.org/wiki/Spain?vectorclientpreferences=1
https://en.wikipedia.org/wiki/Spain?vectorlanguageinheader=0
https://en.wikipedia.org/wiki/Spain?vectorlanguageinheader=1
https://en.wikipedia.org/wiki/Spain?vectormainmenupinned=0
https://en.wikipedia.org/wiki/Spain?vectormainmenupinned=1
https://en.wikipedia.org/wiki/Spain?vectorpagetoolspinned=0
https://en.wikipedia.org/wiki/Spain?vectorpagetoolspinned=1
https://en.wikipedia.org/wiki/Spain?vectorstickyheader=0
https://en.wikipedia.org/wiki/Spain?vectorstickyheader=1
https://en.wikipedia.org/wiki/Spain?vectorlimitedwidth=0
https://en.wikipedia.org/wiki/Spain?vectorlimitedwidth=1
https://en.wikipedia.org/wiki/Spain?vectortocpinned=0
https://en.wikipedia.org/wiki/Spain?vectortocpinned=1
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=0
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=1
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=2
https://en.wikipedia.org/wiki/Spain?vectorcustomfontsize=3

QA Results - Beta

ACStatusDetails
1T347900#9270529
2T347900#9270529

Event Timeline

Change 962666 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Allow user preferences to be overriden by query string parameter

https://gerrit.wikimedia.org/r/962666

ovasileva lowered the priority of this task from High to Medium.Oct 10 2023, 5:25 PM
ovasileva set the point value for this task to 2.

Change 962666 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Allow user preferences to be overriden by query string parameter

https://gerrit.wikimedia.org/r/962666

Edtadros removed Edtadros as the assignee of this task.EditedOct 22 2023, 2:15 AM
Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps
❌ AC1: Anon
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=0
screenshot 147.png (943×1 px, 243 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=1
screenshot 148.png (943×1 px, 244 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=0
screenshot 149.png (943×1 px, 243 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=1
screenshot 150.png (943×1 px, 266 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=0
screenshot 151.png (943×1 px, 243 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=1
screenshot 152.png (943×1 px, 236 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=0
screenshot 153.png (943×1 px, 241 KB)
screenshot 163.png (932×1 px, 279 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=1
screenshot 154.png (943×1 px, 250 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=0 per T317900 the main menu is unpinned when it is in the hidden in the hamburger menu
screenshot 77.mov.gif (942×1 px, 880 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=1 per T317900 the main menu is pinned when it is in the sidebar
screenshot 78.mov.gif (942×1 px, 961 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=0per T318002#9197113 unpinned is in a drop down...so this is ok.
screenshot 77.mov.gif (720×1 px, 794 KB)
screenshot 78.mov.gif (720×1 px, 769 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=1per T318002#9197113 unpinned is in a drop down, I expected this to place the page tools in the sidebar.
screenshot 79.mov.gif (720×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=0
screenshot 80.mov.gif (720×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=1
screenshot 81.mov.gif (720×1 px, 3 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=0see below
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=1the query param seems to change the icon in the lower left but doesn't impact the limited/full width of the text
screenshot 84.mov.gif (720×2 px, 3 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=0 per T318002#9197113 unpinned is not in the sidebar. I'm not sure this is doing anything.
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=1 per T318002#9197113 unpinned is in the sidebar. I'm not sure this is doing anything.
screenshot 86.mov.gif (696×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=0This may work, but since the others didn't to be safe I'm marking this as a fail.
screenshot 87.mov.gif (696×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=1Font size is unchanged.
screenshot 88.mov.gif (696×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=2Font size is unchanged.
screenshot 89.mov.gif (696×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=3Font size is unchanged.
screenshot 90.mov.gif (696×1 px, 1 MB)
❌ AC2: Logged In
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=0
screenshot 155.png (697×1 px, 213 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=1
screenshot 156.png (697×1 px, 212 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=0
screenshot 157.png (697×1 px, 213 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortypographysurvey=1
screenshot 158.png (697×1 px, 233 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=0
screenshot 159.png (697×1 px, 210 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorclientpreferences=1
screenshot 160.png (697×1 px, 204 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=0
screenshot 161.png (932×1 px, 297 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlanguageinheader=1
screenshot 162.png (932×1 px, 308 KB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=0 per T317900 the main menu is unpinned when it is in the hidden in the hamburger menu
screenshot 91.mov.gif (930×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectormainmenupinned=1 per T317900 the main menu is pinned when it is in the sidebar
screenshot 92.mov.gif (930×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=0per T318002#9197113 unpinned is in a drop down.
screenshot 93.mov.gif (930×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorpagetoolspinned=1per T318002#9197113 unpinned is in a drop down.
screenshot 94.mov.gif (930×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=0
screenshot 95.mov.gif (930×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorstickyheader=1
screenshot 96.mov.gif (930×1 px, 1 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=0see below
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorlimitedwidth=1
screenshot 98.mov.gif (626×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=0 per T318002#9197113 unpinned is not in the sidebar. see below
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectortocpinned=1 per T318002#9197113 unpinned is in the sidebar.
screenshot 99.mov.gif (974×1 px, 3 MB)
screenshot 100.mov.gif (974×1 px, 2 MB)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=0Not sure if this is a pass or not. It's the only one that changes the font size. But one would expect it to do nothing. See below.
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=1Not sure if this is a pass or not. I'm not sure if it is making the font larger than vectorcustomfontsize=0 or it's doing nothing. See below.
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=2See below.
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorcustomfontsize=3
screenshot 101.2.gif (635×1 px, 3 MB)

@ovasileva we decided not to carry this over, as it seems to have been caused by the client preferences work. It would be good to sync with MediaWiki platform team before committing to this work. We'll also want to rewrite this task with the following in mind:

  • @Mabualruz it looks like the font size was broken by I6afa39624c3cadd31632d63a36b919d641983ae6 (T346954)
  • @Edtadros limited width looks like a pass to me. (Can you double check that)
  • Sticky header, page tools, doesn't look like it has been written to work with anonymous users (these are logged in only features). So these might be expected behaviour and we'll want to descope it.
  • Table of contents does work for anonymous users so I'd expect that to work.

Moving to sprint 2. @Jdlrobson - could you update the task description with the current state of this ticket and the general case for query string parameters?

Jdlrobson raised the priority of this task from Medium to High.Fri, Feb 2, 8:30 PM

We may need this to test Vector's night mode

Jdlrobson lowered the priority of this task from High to Medium.Thu, Feb 8, 12:33 AM

So far we've not hit this with night mode so I think we can punt this to when we need it and lower priority.

Change 1003463 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: FeatureVariants

https://gerrit.wikimedia.org/r/1003463

Jdlrobson renamed this task from It should be possible to enable font size and typography prototype overlay through a URL to It should be possible to enable font size through a URL.Wed, Feb 14, 5:10 PM