| DVrandecic | |
| Oct 4 2023, 6:18 PM |
| F56120266: Screenshot 2024-07-01 at 13.23.12.png | |
| Mon, Jul 1, 11:25 AM |
| F56116386: CleanShot 2024-07-01 at 11.10.14@2x.png | |
| Mon, Jul 1, 9:13 AM |
| F56116406: CleanShot 2024-07-01 at 11.09.29@2x.png | |
| Mon, Jul 1, 9:13 AM |
| Restricted File | |
| Mon, Jul 1, 8:55 AM |
| F56115758: Screenshot from 2024-07-01 10-41-44.png | |
| Mon, Jul 1, 8:43 AM |
| F43319417: image.png | |
| Mar 25 2024, 11:29 AM |
| F43318472: image.png | |
| Mar 25 2024, 11:29 AM |
I first have to tab to the Publish button, or click on the Publish button.
Pressing return should trigger the Publish action.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| PublishDialog.vue: Publication modal should publish on Ctr/Cmdl+Enter | mediawiki/extensions/WikiLambda | master | +168 -2 |
agreed! as discussed during triage let's build on top of what we have in VE.
given that we use the codex field component in the publish dialog, we can use the status prop to display a warning message. why warning? because we'll "block" the editors' action (pressing return/enter), so we'll then explicit what to do to proceed.
for apple machines the copy could be "You can press ⌘↵ to publish your changes."
for non-apple machines, the copy could be "You can press Ctrl↵ to publish your changes"
we could style the hotkey/shortcut with <kbd>. the styles that i used are the following codex tokens:
a figma file is also available at this URL https://www.figma.com/file/IzHf9jo46suf7RvSySVMzK/Untitled?type=design&node-id=12%3A658&mode=design&t=h79gj0kkUu5mEkXm-1
Change #1050290 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] PublishDialog.vue: Publication modal should publish on Ctr/Cmdl+Enter
Current patch looks great. Only needs a couple of style improvements:
Change #1050290 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] PublishDialog.vue: Publication modal should publish on Ctr/Cmdl+Enter
looks good to me too! only one last minor note. if an editor has the input tools active, they are displayed right under the input text field
but if the warning message is being displayed, they are displayed detached from the text field (sort of floating)
Yeah that will happen with anything appended in that page. thats due to probably how that widget positions itself; if you wait a bit you see it re-evaluates its position after x secs again.
the positioning is not something I can change I think.
Only way would be making the text 'position absolute'. but I don't know if thats desirable since thats a hack because the library of the input tools should actually be fixed... Or is there an event they have I can fire to make them re-adjust positioning?
If we make it absolute, the text is going to go outside the DOM-flow and wont take up space and be like this:
understood, thanks @DSmit-WMF! given that this is a (hopefully) small edge case, i'd say we leave this as is. no need to change things to be positioned absolutely. thank you!