Page MenuHomePhabricator
Create Task
Maniphest T349635

Special:NewPagesFeed broken on beta cluster testwiki
Open, MediumPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (675×1 px, 124 KB)

returns

{
    "error": {
        "code": "internal_api_error_InvalidArgumentException",
        "info": "[ZTfS3q58IA6sSvugq-vbKAAAABY] Exception caught: No model available for [articlequality]",
        "errorclass": "InvalidArgumentException",
        "trace": "InvalidArgumentException at /srv/mediawiki/php-master/extensions/ORES/includes/Storage/SqlModelLookup.php(42)\nfrom /srv/mediawiki/php-master/extensions/ORES/includes/Storage/SqlModelLookup.php(42)\n#0 /srv/mediawiki/php-master/extensions/ORES/includes/Services/PopulatedSqlModelLookup.php(114): ORES\\Storage\\SqlModelLookup->getModelId(string)\n#1 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(218): ORES\\Services\\PopulatedSqlModelLookup->getModelId(string)\n#2 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(181): MediaWiki\\Extension\\PageTriage\\OresMetadata->getORESScores(string, array)\n#3 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(96): MediaWiki\\Extension\\PageTriage\\OresMetadata->fetchScores(array)\n#4 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(110): MediaWiki\\Extension\\PageTriage\\OresMetadata->__construct(ORES\\Storage\\ThresholdLookup, ORES\\Services\\PopulatedSqlModelLookup, array, DerivativeContext, array)\n#5 /srv/mediawiki/php-master/extensions/PageTriage/includes/Api/ApiPageTriageList.php(87): MediaWiki\\Extension\\PageTriage\\OresMetadata::newFromGlobalState(DerivativeContext, array)\n#6 /srv/mediawiki/php-master/includes/api/ApiMain.php(1931): MediaWiki\\Extension\\PageTriage\\Api\\ApiPageTriageList->execute()\n#7 /srv/mediawiki/php-master/includes/api/ApiMain.php(908): ApiMain->executeAction()\n#8 /srv/mediawiki/php-master/includes/api/ApiMain.php(879): ApiMain->executeActionWithErrorHandling()\n#9 /srv/mediawiki/php-master/api.php(95): ApiMain->execute()\n#10 /srv/mediawiki/php-master/api.php(48): wfApiMain()\n#11 /srv/mediawiki/w/api.php(3): require(string)\n#12 {main}"
    },
    "servedby": "deployment-mediawiki11"
}

What should have happened instead?:

  • no "An error occurred while loading the interface from the API. Please try reloading the page." message

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
[BETA CLUSTER] testwiki: Disable PageTriage's extended featuresoperations/mediawiki-configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Oct 24 2023, 3:16 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptOct 24 2023, 3:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Soda subscribed.Oct 24 2023, 3:39 PM

Based on a look at /wmf-config/InitialiseSettings-labs.php:1453-1473

'wgOresModels' => [
			'default' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'types' => [ 1 ] ],
			],
			'enwiki' => [
				'damaging' => [ 'enabled' => true, 'excludeBots' => true ],
				'goodfaith' => [ 'enabled' => true, 'excludeBots' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'types' => [ 1 ], 'excludeBots' => true, 'cleanParent' => true ],
			],
			'wikidatawiki' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'itemquality' => [ 'enabled' => true, 'namespaces' => [ 0 ], 'cleanParent' => true ],
			],
		],

there is no model defined for beta testwiki. Did the feed work before this ?

TheresNoTime subscribed.EditedOct 24 2023, 3:53 PM

hate to be that person, but is there a reason why y'all can't just use https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed for testing?

jsn.sherman added a comment.EditedOct 24 2023, 3:57 PM
In T349635#9276952, @TheresNoTime wrote:

hate to be that person, but is there a reason why y'all can't just use https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed for testing?

+1
As I mentioned indirectly in T331595#9276326, I think the solution is to disable the extended features in test wiki on beta

jsn.sherman added a comment.Oct 24 2023, 4:57 PM
In T349635#9276879, @Soda wrote:

Based on a look at /wmf-config/InitialiseSettings-labs.php:1453-1473

'wgOresModels' => [
			'default' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'types' => [ 1 ] ],
			],
			'enwiki' => [
				'damaging' => [ 'enabled' => true, 'excludeBots' => true ],
				'goodfaith' => [ 'enabled' => true, 'excludeBots' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'types' => [ 1 ], 'excludeBots' => true, 'cleanParent' => true ],
			],
			'wikidatawiki' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'itemquality' => [ 'enabled' => true, 'namespaces' => [ 0 ], 'cleanParent' => true ],
			],
		],

there is no model defined for beta testwiki. Did the feed work before this ?

I don't see how it could have; my guess is that it got enabled for something specific in the past and then left and forgotten after its purpose was served. We could look through the git blame to verify, or we could just disable it if nobody on the project is using it.

Soda added a comment.Oct 24 2023, 9:23 PM
In T349635#9277187, @jsn.sherman wrote:
In T349635#9276879, @Soda wrote:

Based on a look at /wmf-config/InitialiseSettings-labs.php:1453-1473

'wgOresModels' => [
			'default' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => false, 'namespaces' => [ 0 ], 'types' => [ 1 ] ],
			],
			'enwiki' => [
				'damaging' => [ 'enabled' => true, 'excludeBots' => true ],
				'goodfaith' => [ 'enabled' => true, 'excludeBots' => true ],
				'reverted' => [ 'enabled' => false ],
				'articlequality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'cleanParent' => true ],
				'draftquality' => [ 'enabled' => true, 'namespaces' => [ 0, 118 ], 'types' => [ 1 ], 'excludeBots' => true, 'cleanParent' => true ],
			],
			'wikidatawiki' => [
				'damaging' => [ 'enabled' => true ],
				'goodfaith' => [ 'enabled' => true ],
				'reverted' => [ 'enabled' => false ],
				'itemquality' => [ 'enabled' => true, 'namespaces' => [ 0 ], 'cleanParent' => true ],
			],
		],

there is no model defined for beta testwiki. Did the feed work before this ?

I don't see how it could have; my guess is that it got enabled for something specific in the past and then left and forgotten after its purpose was served. We could look through the git blame to verify, or we could just disable it if nobody on the project is using it.

I agree it might be easier to disable this feature on test wiki

klausman moved this task from Unsorted to Ready To Go on the Machine-Learning-Team board.Nov 14 2023, 3:51 PM
gerritbot added a comment.Nov 17 2023, 3:24 AM

Change 975107 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[operations/mediawiki-config@master] Disable PageTriage's extended features on beta testwiki

https://gerrit.wikimedia.org/r/975107

gerritbot added a project: Patch-For-Review.Nov 17 2023, 3:24 AM
MPGuy2824 claimed this task.Nov 17 2023, 3:26 AM
MPGuy2824 moved this task from Backlog to Code Review on the PageTriage board.
gerritbot added a comment.Dec 1 2023, 2:43 PM

Change 975107 merged by jenkins-bot:

[operations/mediawiki-config@master] [BETA CLUSTER] testwiki: Disable PageTriage's extended features

https://gerrit.wikimedia.org/r/975107

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2023, 3:10 PM
isarantopoulos triaged this task as Medium priority.Dec 7 2023, 8:53 AM
Scardenasmolinar moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Dec 8 2023, 4:30 AM
MPGuy2824 added a comment.Jan 14 2024, 7:56 AM
In T349635#9276970, @jsn.sherman wrote:

As I mentioned indirectly in T331595#9276326, I think the solution is to disable the extended features in test wiki on beta

@jsn.sherman this hasn't fixed the problem.

MPGuy2824 removed MPGuy2824 as the assignee of this task.Jan 20 2024, 4:34 AM
MPGuy2824 moved this task from Waiting for enwiki deploy to Backlog on the PageTriage board.
MPGuy2824 subscribed.
isarantopoulos moved this task from Ready To Go to Watching on the Machine-Learning-Team board.Jul 9 2024, 3:12 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptJul 9 2024, 3:12 PM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Aug 13 2024, 11:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits