Page MenuHomePhabricator
Create Task
Maniphest T351138

Some articles with gallery fail to start for translation
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Visit Special:ContentTranslation in Serbian Wikipedia
  • Change source wiki/language to Croatian (hr)
  • Choose the article Kapuljača to translate

What happens?:
Content translation opens and loads, with the error:

image.png (1×1 px, 129 KB)

What should have happened instead?:
It shouldn't throw any error, but to allow me to translate.

Software version (skip for WMF-hosted wikis like Wikipedia):
Serbian Wikipedia, which is having 1.42.0-wmf.4 (de18cff) at this moment, ContentTranslation - 17376f4

Other information (browser name/version, screenshots, etc.):

  • Microsoft Edge 119.0.2151.58 64-bit
  • Windows 11

I've had no luck translating that article for a couple of months now, I'm getting superstitious.
It was just loading forever earlier when I was trying, now it's throwing an error at least.

The browser console is showing me only: mw.cx.init.Translation.js:234 [CX] Translation initialization failed.
(you can actually see it in the screenshot)

EDIT: Error from local testing:

TypeError: img is null
    toDataElement ve.dm.MWGalleryImageNode.js:81
    createDataElements ve.dm.Converter.js:548

Details

SubjectRepoBranchLines +/-
Update cxserver to 2023-12-04-083437-productionoperations/deployment-chartsmaster+6 -7
Use MediaWiki REST API endpoint instead of RESTbasemediawiki/services/cxservermaster+14 -29
Customize query in gerrit

Related Objects

Event Timeline

Kizule created this task.Nov 13 2023, 11:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2023, 11:31 PM
Kizule updated the task description. (Show Details)Nov 13 2023, 11:35 PM
ngkountas subscribed.Nov 14 2023, 8:01 AM

This issue is related to some image gallery node that exists inside the source article. Apparently, there are some issues with image galleries. This isn't in the Content Translation side, so we'll have to investigate if the issue lies in the cxserver or the visual editor.

Kizule added a comment.Nov 15 2023, 9:26 AM

Oh, it's probably because of <gallery></gallery> tags, I had trouble with it in section translation while trying to translate a section from enwiki to srwiki. So, the issue is with that specific tag.

Kizule added a comment.Nov 15 2023, 9:27 AM
In T351138#9333293, @Kizule wrote:

Oh, it's probably because of <gallery></gallery> tags, I had trouble with it in section translation while trying to translate a section from enwiki to srwiki. So, the issue is with that specific tag.

Oh, that part about section translation is actually T275495: Support for galleries in Section translation.

gerritbot added a comment.Nov 16 2023, 10:20 AM

Change 974943 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] MWGallery: Support the new HTML format as per MW Dom Spec 2.7.0

https://gerrit.wikimedia.org/r/974943

gerritbot added a project: Patch-For-Review.Nov 16 2023, 10:20 AM
• santhosh renamed this task from Cx-init-critical-error in Serbian Wikipedia to Gallery adaptation fails with updated MW Dom Spec.Nov 16 2023, 10:21 AM
• santhosh claimed this task.
• santhosh triaged this task as Medium priority.
• santhosh updated the task description. (Show Details)
Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Nov 20 2023, 11:14 AM
Pginer-WMF added a project: Language-Team (Language-2023-October-December).
KartikMistry moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-October-December) board.Nov 21 2023, 4:37 AM
Nikerabbit changed the task status from Open to In Progress.Nov 23 2023, 8:47 AM
Nikerabbit edited projects, added CX-cxserver; removed ContentTranslation.Nov 23 2023, 2:38 PM
ngkountas renamed this task from Gallery adaptation fails with updated MW Dom Spec to Some articles with gallery fail to start for translation .Nov 24 2023, 2:22 PM
ngkountas claimed this task.
ngkountas updated the task description. (Show Details)
ngkountas added a subscriber: • santhosh.
Kizule mentioned this in T275495: Support for galleries in Section translation.Nov 24 2023, 2:42 PM
ngkountas added a comment.Nov 24 2023, 3:08 PM

It turns out that this issue is caused because the image elements (<img>) inside galleries are expected to have the .mw-file-element class, inside the toDataElement of ve.dm.MWGalleryImageNode class. This class is part of VisualEditor extension. This expectation exists because since MW Dom Spec 2.7.1 these image elements should have this class (T314097).

Now, the cxserver currently uses under the hood the RESTBase API to fetch the page content which uses MW Dom Spec 2.6.0 (request: https://hr.wikipedia.org/api/rest_v1/page/html/Kapulja%C4%8Da). The content from these responses do not include the expected .mw-file-element classes, leading to an unhandled JS error.

On the bright side, once this patch is merged, the cxserver will start using the MediaWiki REST API instead, which uses MW Dom Spec 2.8.0 (request: https://hr.wikipedia.org/w/rest.php/v1/page/Kapulja%C4%8Da/html) and the issue will be resolved.

gerritbot added a comment.Nov 24 2023, 3:09 PM

Change 976152 had a related patch set uploaded (by Nik Gkountas; author: Santhosh):

[mediawiki/services/cxserver@master] Use MediaWiki REST API endpoint instead of RESTbase

https://gerrit.wikimedia.org/r/976152

Kizule added a comment.Nov 24 2023, 3:11 PM
In T351138#9356732, @ngkountas wrote:

It turns out that this issue is caused because the image elements (<img>) inside galleries are expected to have the .mw-file-element class, inside the toDataElement of ve.dm.MWGalleryImageNode class. This class is part of VisualEditor extension. This expectation exists because since MW Dom Spec 2.7.1 these image elements should have this class (T314097).

Now, the cxserver currently uses under the hood the RESTBase API to fetch the page content which uses MW Dom Spec 2.6.0 (request: https://hr.wikipedia.org/api/rest_v1/page/html/Kapulja%C4%8Da). The content from these responses do not include the expected .mw-file-element classes, leading to an unhandled JS error.

On the bright side, once this patch is merged, the cxserver will start using the MediaWiki REST API instead, which uses MW Dom Spec 2.8.0 (request: https://hr.wikipedia.org/w/rest.php/v1/page/Kapulja%C4%8Da/html) and the issue will be resolved.

🎆🎆🎆

gerritbot added a comment.Nov 28 2023, 5:15 AM

Change 976152 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Use MediaWiki REST API endpoint instead of RESTbase

https://gerrit.wikimedia.org/r/976152

gerritbot added a comment.Nov 28 2023, 7:24 AM

Change 977983 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2023-11-28-064518-production

https://gerrit.wikimedia.org/r/977983

ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-October-December) board.Nov 28 2023, 8:59 AM
ngkountas added a comment.Jan 8 2024, 9:14 AM

The above fix has now been deployed and the issue is fixed on production.

ngkountas moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.Jan 8 2024, 9:14 AM
Pginer-WMF closed this task as Resolved.Jan 8 2024, 9:48 AM
gerritbot added a comment.Feb 15 2024, 5:04 AM

Change 977983 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2023-12-04-083437-production

https://gerrit.wikimedia.org/r/977983

Stashbot added a comment.Feb 15 2024, 5:43 AM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T05:43:22Z] <kart_> Update cxserver to 2023-12-04-083437-production (T344982, T338432, T351138)

Stashbot mentioned this in T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.Feb 15 2024, 5:43 AM
Stashbot mentioned this in T338432: Prepare the cxserver for usage without RESTbase.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL