Page MenuHomePhabricator

Cannot use argument reference to typed list in composition
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
DVrandecic
Nov 14 2023, 11:20 PM
Referenced Files
F41650872: Screen Shot 2024-01-04 at 11.56.21 AM.png
Jan 4 2024, 8:21 PM
F41650870: Screen Shot 2024-01-04 at 12.18.46 PM.png
Jan 4 2024, 8:21 PM
F41550752: image.png
Dec 1 2023, 10:54 AM
F41550738: image.png
Dec 1 2023, 10:54 AM
F41550736: image.png
Dec 1 2023, 10:54 AM
F41550734: image.png
Dec 1 2023, 10:54 AM
F41550731: image.png
Dec 1 2023, 10:54 AM
F41506207: argument-reference-list.png
Nov 14 2023, 11:20 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
I am now in a state where I cannot choose the argument reference as value for the function call.

argument-reference-list.png (763×1 px, 98 KB)

What should have happened instead?:
I should be able to choose the argument reference as a value for the function call.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 975807 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] generic types

https://gerrit.wikimedia.org/r/975807

Jdforrester-WMF changed the task status from Open to In Progress.Nov 21 2023, 3:47 PM
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.

Change 977097 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] back to modeselektor

https://gerrit.wikimedia.org/r/977097

after a few iterations we landed on a proposal that re-introduces the mode selector in order to let editors change the mode (argument reference, function call, literal, or reference) of a key.

image.png (2×5 px, 386 KB)

every key for which the mode can be changed will display a contextual menu, via the cdxIconEllipsis icon that on tap or click will display the different modes available. this will only be accessible in "Edit source" mode. "Read" mode remains invaried.

image.png (2×3 px, 211 KB)

image.png (2×3 px, 228 KB)

image.png (2×3 px, 244 KB)

the contextual menu will also be used to delete keys that can be deleted, for instance a list item of a typed list.

image.png (1×1 px, 96 KB)

as always, specs are available on figma https://www.figma.com/file/U5FxVRMNU82qhrYmyJ3aBH/T345540-Typed-lists-cannot-be-changed-back?type=design&node-id=0%3A1&mode=dev

Change 977097 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add ModeSelector component and remove special ZObjectType terminal selector

https://gerrit.wikimedia.org/r/977097

Etonkovidova subscribed.

Checked on wikifunctions wmf.10 - works as expected:

Screen Shot 2024-01-04 at 12.18.46 PM.png (1×2 px, 204 KB)
Screen Shot 2024-01-04 at 11.56.21 AM.png (1×1 px, 151 KB)