InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jeena
	Nov 16 2023, 8:08 PM

Description

Error

service.version: 1.42.0-wmf.5
trace.id: 062dde40-1e5f-4eda-971f-02f1dbcae477
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.5/includes/parser/ParserOutput.php(1143)
#0 /srv/mediawiki/php-1.42.0-wmf.5/extensions/DiscussionTools/includes/CommentFormatter.php(365): ParserOutput->setJsConfigVar(string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.5/extensions/DiscussionTools/includes/CommentFormatter.php(66): MediaWiki\Extension\DiscussionTools\CommentFormatter::addDiscussionToolsInternal(string, ParserOutput, MediaWiki\Title\Title)
#2 /srv/mediawiki/php-1.42.0-wmf.5/extensions/DiscussionTools/includes/Hooks/ParserHooks.php(69): MediaWiki\Extension\DiscussionTools\CommentFormatter::addDiscussionTools(string, ParserOutput, MediaWiki\Title\Title)
#3 /srv/mediawiki/php-1.42.0-wmf.5/extensions/DiscussionTools/includes/Hooks/ParserHooks.php(102): MediaWiki\Extension\DiscussionTools\Hooks\ParserHooks->transformHtml(ParserOutput, string, MediaWiki\Title\Title, boolean)
#4 /srv/mediawiki/php-1.42.0-wmf.5/includes/HookContainer/HookContainer.php(161): MediaWiki\Extension\DiscussionTools\Hooks\ParserHooks->onParserOutputPostCacheTransform(ParserOutput, string, array)
#5 /srv/mediawiki/php-1.42.0-wmf.5/includes/HookContainer/HookRunner.php(3027): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#6 /srv/mediawiki/php-1.42.0-wmf.5/includes/ParserOutputTransform/DefaultOutputTransform.php(119): MediaWiki\HookContainer\HookRunner->onParserOutputPostCacheTransform(ParserOutput, string, array)
#7 /srv/mediawiki/php-1.42.0-wmf.5/includes/parser/ParserOutput.php(447): Mediawiki\ParserOutputTransform\DefaultOutputTransform->transform(ParserOutput, array)
#8 /srv/mediawiki/php-1.42.0-wmf.5/includes/Output/OutputPage.php(2391): ParserOutput->getText(array)
#9 /srv/mediawiki/php-1.42.0-wmf.5/includes/Output/OutputPage.php(2435): MediaWiki\Output\OutputPage->getParserOutputText(ParserOutput, array)
#10 /srv/mediawiki/php-1.42.0-wmf.5/includes/page/Article.php(849): MediaWiki\Output\OutputPage->addParserOutput(ParserOutput, array)
#11 /srv/mediawiki/php-1.42.0-wmf.5/includes/page/Article.php(663): Article->doOutputFromParserCache(ParserOutput, MediaWiki\Output\OutputPage, array)
#12 /srv/mediawiki/php-1.42.0-wmf.5/includes/page/Article.php(559): Article->generateContentOutput(MediaWiki\User\User, ParserOptions, integer, MediaWiki\Output\OutputPage, array)
#13 /srv/mediawiki/php-1.42.0-wmf.5/includes/actions/ViewAction.php(78): Article->view()
#14 /srv/mediawiki/php-1.42.0-wmf.5/includes/MediaWiki.php(583): ViewAction->show()
#15 /srv/mediawiki/php-1.42.0-wmf.5/includes/MediaWiki.php(363): MediaWiki->performAction(Article, MediaWiki\Title\Title)
#16 /srv/mediawiki/php-1.42.0-wmf.5/includes/MediaWiki.php(960): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.42.0-wmf.5/includes/MediaWiki.php(613): MediaWiki->main()
#18 /srv/mediawiki/php-1.42.0-wmf.5/index.php(50): MediaWiki->run()
#19 /srv/mediawiki/php-1.42.0-wmf.5/index.php(46): wfIndexMain()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}

Impact

100 errors in 30 min

Notes

Details

Request URL: https://en.wikipedia.org/wiki/Talk:Thomas%20D.%20Rice?useparsoid=*&useskin=*&useskinversion=*

Subject	Repo	Branch	Lines +/-
Work around Parsoid's messy handling of some extensions	mediawiki/extensions/DiscussionTools	wmf/1.42.0-wmf.7	+4 -1
Work around Parsoid's messy handling of some extensions	mediawiki/extensions/DiscussionTools	master	+4 -1
ParserOutputPostCacheTransform: Don't reprocess content	mediawiki/extensions/DiscussionTools	master	+6 -0
ParserOutputPostCacheTransform: Don't reprocess content	mediawiki/extensions/DiscussionTools	wmf/1.42.0-wmf.5	+6 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Resolved		Sbailey	T348260 Allow individual user opt in to Parsoid read views for discussion tools
Resolved		ssastry	T341010 DiscussionTools doesn't recognize talk threads with Parsoid HTML
Resolved	PRODUCTION ERROR	ssastry	T351461 InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads

Event Timeline

jeena created this task.Nov 16 2023, 8:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2023, 8:08 PM

These errors are from a visual diffing test run I kicked off about 45 mins back or so. DiscussionTools with Parsoid isn't used anywhere else right now. But, this gives me a clue for some diffs I was noticing in the test run. So, I'll fix this and hopefully that will fix the diffs too!

ssastry added a parent task: T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.Nov 16 2023, 8:36 PM

matmarex subscribed.Nov 16 2023, 8:46 PM

Change 975364 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/DiscussionTools@master] WIP: ParserOutputPostCacheTransform: Don't reprocess content

https://gerrit.wikimedia.org/r/975364

gerritbot added a project: Patch-For-Review.Nov 17 2023, 9:32 PM

MSantos added a project: Essential-Work.Nov 20 2023, 2:01 PM

Change 975364 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ParserOutputPostCacheTransform: Don't reprocess content

https://gerrit.wikimedia.org/r/975364

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 21 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 4:10 PM

Change 976330 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.5] ParserOutputPostCacheTransform: Don't reprocess content

https://gerrit.wikimedia.org/r/976330

gerritbot added a project: Patch-For-Review.Nov 21 2023, 8:13 PM

Change 976330 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.5] ParserOutputPostCacheTransform: Don't reprocess content

https://gerrit.wikimedia.org/r/976330

Mentioned in SAL (#wikimedia-operations) [2023-11-21T21:29:58Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:976330|ParserOutputPostCacheTransform: Don't reprocess content (T351461)]]

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-21T21:31:18Z] <catrope@deploy2002> ssastry and catrope: Backport for [[gerrit:976330|ParserOutputPostCacheTransform: Don't reprocess content (T351461)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.5; 2023-11-14); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 21 2023, 10:00 PM

Turns out this is a different manifestation of T303015#7770480 with the ParserAfterTidy hook that triggers the DiscussionTools extension's CommentFormatter which sets the JS config var in question whenever Parsoid's pipeline processes a <templatestyles> tag (or some other extension tag that Parsoid calls core to handle). This information is accumulated and propagated to the final top level parse of the page and stored in ParserCache. Now, when Parsoid tries to get DT rendered, ParserOutput finds that the wgDiscussionToolsPageThreads has been set and barfs as above.

The problem is the same as identified in T303015#7770480 - Parsoid/PHP processes the extension tag as a "top level doc" to mimic Parsoid/JS behavior where it called the MW API.

To let us continue our testing, a temporary hack is to simply use addJsConfigVars in DT which silently overwrites any previous value for a config var (or if we want to be careful, provide an unsetJsConfigVar method in ParserOutput that DT can call for Parsoid HTML before setting it).

But, we should probably revisit the 'parseExtTagAsTopLevelDoc' implementation in Parser.php -- maybe we don't need to run the two hooks (ParserAfterParse and ParserAfterTidy) for every extension anymore! Since any extension that relies on those hooks will need a Parsoid-equivalent implementation to work properly with Parsoid, that implementation will process the full top-level doc anyway. But, this is a potentially intrusive change and something we should carefully audit before rolling out.

Change 977310 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/DiscussionTools@master] Work around Parsoid's messy handling of some extensions

https://gerrit.wikimedia.org/r/977310

gerritbot added a project: Patch-For-Review.Nov 27 2023, 4:05 AM

Change 978067 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.7] Work around Parsoid's messy handling of some extensions

https://gerrit.wikimedia.org/r/978067

Change 977310 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Work around Parsoid's messy handling of some extensions

https://gerrit.wikimedia.org/r/977310

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 28 2023, 9:00 PM

Change 978067 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.7] Work around Parsoid's messy handling of some extensions

https://gerrit.wikimedia.org/r/978067

Mentioned in SAL (#wikimedia-operations) [2023-11-28T21:59:26Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:978072|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978071|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978067|Work around Parsoid's messy handling of some extensions (T351461)]]

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 28 2023, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T22:01:04Z] <urbanecm@deploy2002> urbanecm and ssastry and jdlrobson: Backport for [[gerrit:978072|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978071|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978067|Work around Parsoid's messy handling of some extensions (T351461)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 10:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T22:12:29Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:978072|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978071|Fixes: Duplicate events for radio buttons (T352075)]], [[gerrit:978067|Work around Parsoid's messy handling of some extensions (T351461)]] (duration: 13m 02s)

ssastry mentioned this in T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.Nov 30 2023, 1:49 AM

ssastry closed this task as Resolved.Nov 30 2023, 2:37 PM

InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreadsClosed, ResolvedPublicPRODUCTION ERRORActions