Page MenuHomePhabricator

Avoid "New translation" button to stretch
Closed, ResolvedPublic

Assigned To
Authored By
Pginer-WMF
Nov 21 2023, 3:11 PM

Description

The "New translation" option currently becomes wider in some screen sizes:

MobileTablet VerticalTablet HorizontalDesktop
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn(Wiki Mobile) (1).png (568×320 px, 46 KB)
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&from=en&to=.png (1×768 px, 158 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn(Wiki Tablet) (1).png (767×1 px, 103 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn(Wiki Desktop).png (900×1 px, 163 KB)

This task proposes for the button not to go wider than what the button label requires. Based on the specs from the responsive adjustments (T319181), the mockups below show the expected layout for the button:

MobileTablet VerticalTablet HorizontalDesktop
Mobile.png (896×320 px, 89 KB)
TabletV.png (784×768 px, 88 KB)
TabletH.png (768×1 px, 75 KB)
Desktop - Suggestions.png (900×1 px, 115 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.

Change #1070872 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Avoid "New Translation" button to stretch

https://gerrit.wikimedia.org/r/1070872

This comment was removed by hueitan.

Change #1070872 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Avoid "New Translation" button to stretch

https://gerrit.wikimedia.org/r/1070872

Change #1072700 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240913

https://gerrit.wikimedia.org/r/1072700

Change #1072700 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240913

https://gerrit.wikimedia.org/r/1072700

After the fix the current placement and dimensions of the button are aligned with the expected ones. Thanks for adjusting it!

MobileTablet VerticalTablet HorizontalDesktop
Current
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&active-list=suggestions&from=en&to=bn(Wiki Mobile) (1).png (568×320 px, 48 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&active-list=suggestions&from=en&to=bn(Wiki Tablet).png (1×768 px, 163 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&active-list=suggestions&from=en&to=bn(Wiki Tablet) (1).png (768×1 px, 120 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&active-list=suggestions&from=en&to=bn(Wiki Desktop).png (900×1 px, 184 KB)
Expected
Mobile.png (896×320 px, 89 KB)
TabletV.png (784×768 px, 88 KB)
TabletH.png (768×1 px, 75 KB)
Desktop - Suggestions.png (900×1 px, 115 KB)