Page MenuHomePhabricator

mobile diff doesn't support switching between Visual and WikiText diffs
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

Expected result:
Buttons are available to switch between visual and wikitext diffs (as was the case until recently).

Actual result:
No buttons are available. I'm stuck with whatever mode the diff is in, which appears to be the mode of the last diff I did on my laptop.

Event Timeline

Screenshot_20231124-174857.png (2×1 px, 203 KB)

Buttons should appear between "1987." and "Short description..."

Change 979148 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Show diff switcher on narrow screens

https://gerrit.wikimedia.org/r/979148

We understand the set of factors causing the transient state you're experiencing @Danbloch (thank you for reporting this, btw!) as the following:

  1. Diff preferences are based on accounts. Meaning, a preference set on desktop will be reflected on mobile and vice versa
  2. There is [currently] no visual and wikitext switcher shown at narrow screen widths

The above can result in someone viewing a visual diff on desktop, view a diff on mobile, seeing said "diff" being presented in the visual mode without a way to switch to wikitext.

There seem to be at least four paths forward:

  1. Force the view back to wikitext at smaller widths
  2. Support visual diff on mobile better by changing layout
  3. Split the preference between desktop and mobile
  4. show switcher, leave "broken" layout when sidebar is visible

...we're going to start with "4." If/when we come to learn this approach is more confusing than it is helpful, we'll revisit the options "1.", "2." and "3."

Change 979148 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Show diff switcher on narrow screens

https://gerrit.wikimedia.org/r/979148

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.