Page MenuHomePhabricator
Create Task
Maniphest T351954

Autopatrolled users should be able to unpatrol their own articles
Closed, ResolvedPublicFeature
Actions

Description

Requested by @TechnoSquirrel69 at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Observations

Feature summary (what you would like to be able to do and where):

  • Autopatrolled users should be able to unpatrol their own articles.
  • Suggest doing this by adding an "Add to the New Pages Feed" link to the left "tools" menu, similar to how articles that have been reviewed for more than 30 days also get this link. This lets us reuse the i18n message, and avoids having to display the NPP toolbar (since the autopatrolled user might not be an NPP)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

  • Autopatrolled users that aren't NPPs that don't feel 100% sure about the notability of an article
  • Autopatrolled users that are AFC reviewers and aren't NPPs that don't feel 100% sure about the notability of a draft they're accepting

Benefits (why should this be implemented?):

  • Second set of eyes on questionable articles

Details

SubjectRepoBranchLines +/-
Allow autopatrolled users to unreview their own pagesmediawiki/extensions/PageTriagemaster+227 -63
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Nov 25 2023, 5:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2023, 5:10 PM
Novem_Linguae moved this task from Backlog to Priority small features on the PageTriage board.Nov 25 2023, 6:11 PM
Soda subscribed.Nov 25 2023, 7:52 PM

Autopatrolled users should be able to unpatrol their own articles.

This won't be true for AFC drafts, it will be somebody else's article (atleast from PageTriage's POV) :(

I feel like this would need wider community consensus before being implemented since implementing this will basically require giving autopatrolled users the ability to unpatrol basically any page in the NPP queue (or atleast all article that have previously moved from draftspace into the NPP queue).

Novem_Linguae added a comment.Nov 25 2023, 11:18 PM

Good point. I didn't think of that. At a minimum that complicates the logic (we would have to store who did a move that created an autopatrolled status), or we'd need to reduce the scope of this ticket to just own articles.

I agree that a non-npp being able to unpatrol everything and anything is too much power.

TechnoSquirrel69 added a comment.Nov 25 2023, 11:32 PM

That's a bummer. I suppose this would mean the feature wouldn't be applicable to AfC reviews, but maybe it would still be beneficial to allow editors to unpatrol "their own" articles for other circumstances. As Novem Linguae mentioned at WT:AFC, this smaller change may be uncontroversial enough to not require a community discussion.

Soda added a comment.Nov 26 2023, 1:25 AM
In T351954#9357481, @TechnoSquirrel69 wrote:

That's a bummer. I suppose this would mean the feature wouldn't be applicable to AfC reviews, but maybe it would still be beneficial to allow editors to unpatrol "their own" articles for other circumstances. As Novem Linguae mentioned at WT:AFC, this smaller change may be uncontroversial enough to not require a community discussion.

Unreviewing ones own article seems like it should be fine :)

gerritbot added a comment.Nov 26 2023, 11:08 AM

Change 977284 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Allow autopatrolled users to unreview their own pages

https://gerrit.wikimedia.org/r/977284

gerritbot added a project: Patch-For-Review.Nov 26 2023, 11:08 AM
MPGuy2824 changed the task status from Open to In Progress.Dec 1 2023, 3:25 AM
MPGuy2824 assigned this task to Soda.
MPGuy2824 moved this task from Priority small features to Code Review on the PageTriage board.
Scardenasmolinar added a project: Moderator-Tools-Team (Kanban).Dec 8 2023, 3:27 AM
Scardenasmolinar moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
PatchDemoBot added a comment.Dec 12 2023, 5:45 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ce52fe915a/w

Scardenasmolinar moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Dec 12 2023, 6:21 PM
Scardenasmolinar subscribed.

I set up a Patch Demo, and get this error whenever I click on the Add to the New Pages Feed link

Screenshot 2023-12-12 at 12.17.13.png (118×1 px, 72 KB)

HouseBlaster edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Dec 14 2023, 11:35 PM
PatchDemoBot added a comment.Dec 16 2023, 8:54 PM

Test wiki created on Patch demo by Sohom Datta using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/4b5bcbc889/w

Samwalton9-WMF moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Dec 19 2023, 5:12 PM
jsn.sherman moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jan 30 2024, 5:16 PM
Novem_Linguae moved this task from Code Review to Priority small features on the PageTriage board.Feb 14 2024, 1:59 AM
Novem_Linguae moved this task from Priority small features to Priority big features on the PageTriage board.
PatchDemoBot added a comment.Mar 27 2024, 5:20 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ce52fe915a/w/

Samwalton9-WMF moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Mar 28 2024, 3:39 PM
PatchDemoBot added a comment.Fri, Mar 29, 12:20 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7120a34470/w

PatchDemoBot added a comment.Fri, Mar 29, 12:25 AM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7120a34470/w/

gerritbot added a comment.Fri, Mar 29, 12:48 AM

Change #977284 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Allow autopatrolled users to unreview their own pages

https://gerrit.wikimedia.org/r/977284

Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Fri, Mar 29, 12:49 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Fri, Mar 29, 1:00 AM
Novem_Linguae closed this task as Resolved.Sun, Apr 7, 7:54 PM
PatchDemoBot added a comment.Tue, Apr 23, 4:34 PM

Test wiki on Patch demo by Sohom Datta using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/4b5bcbc889/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL