Page MenuHomePhabricator
Create Task
Maniphest T35226

prop=imageinfo: give empty tag for files without metadata
Open, LowestPublic
Actions

Description

For files without metadata the api shows:

<imageinfo>
  <ii metadata="" />
</imageinfo>

It is possible to change this to

<imageinfo>
  <ii>
    <metadata />
  </ii>
</imageinfo>

Or an other style? The current is wrong and bad to detect.

Thanks.

Version: 1.20.x
Severity: normal
URL: http://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&titles=File%3AThe%20Sundeck%20On%20L'art%20de%20Vivre%20Hotel%20Barge.jpg%7CFile%3APoweredby%20mediawiki%2088x31.png&iiprop=metadata

Details

Reference
bz33226

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFeatureNoneT40891 MediaWiki API 2.0 (tracking)
 OpenNoneT35226 prop=imageinfo: give empty tag for files without metadata
 OpenNoneT89971 ApiQueryImageInfo is crufty, needs rewrite
 OpenNoneT132947 Make it possible for extensions to add additional info to the fileinfo/imageinfo response.
 DeclinedNoneT134641 Make TextHandler use the timedtext videoinfo api for remoteDB sources
 InvalidNoneT187759 API is returning 500 status code
 OpenNoneT201205 Bad metadata for a single file errors out the complete imageinfo prop request
 InvalidNoneT235011 API query times out
 OpenBUG REPORTNoneT311633 Unable to get imageinfo only for the latest revision
 OpenNoneT67251 Query-continue for imageinfo returns timestamp which is ambiguous if multiple files were uploaded within the same second under the same file name
 OpenNoneT67264 File storage uses (title,timestamp) as a unique key, but this is not unique
 OpenLadsgroupT28741 Migrate file tables to a modern layout (image/oldimage; file/filerevision; add primary keys)
 ResolvedKrinkleT589 RFC: image and oldimage tables
 ResolvedLadsgroupT368113 Design and merge the new tables of file tables
 ResolvedmfornsT389800 Update Commons Impact Metrics to account for new File table
 ResolvedLadsgroupT383093 Set beta cluster to write both in file schema and thoroughly test it
 ResolvedLadsgroupT383491 Deploy new file tables in production
 ResolvedLadsgroupT383492 Write the migration script
 ResolvedZabeT383496 Add support for reading new file schema into MediaWiki
 ResolvedDreamy_JazzT383555 Add support for reading new file schema in MediaModeration
 ResolvedLadsgroupT384481 Set new file tables to write both in production
 ResolvedLadsgroupT385167 Run data migration script for file migration
 DuplicateNoneT386133 Update Data Pipelines with new image table schema
 ResolvedZabeT412164 Set beta cluster to read new in file schema and thoroughly test it
 OpenLadsgroupT415330 Add support for stop writing to the old file db schema
 OpenZabeT416548 Start reading from file table on wmf production
 OpenPRODUCTION ERRORNoneT418007 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'Savannah_River_(26769689014).jpg' for key 'file_name'Function: MediaWiki\FileRepo\File\LocalFile::acquireFileIdFromNameQuery: INSERT INTO `file` (file_name,file_lates
 ResolvedPRODUCTION ERRORZabeT418327 PHP Deprecated: Caller from MediaWiki\Exception\MWExceptionHandler::rollbackPrimaryChanges ignored an error originally raised from MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\ImageListPager): [1054] Unk
 ResolvedPRODUCTION ERRORZabeT419062 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'img_timestamp' in 'WHERE'Function: MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\NewFilesPager)Query: SELECT /*! STRAIGHT_JOIN */ file_name AS
 ResolvedPRODUCTION ERRORZabeT422946 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
 ResolvedSecurityZabeT423654 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
 ResolvedBUG REPORTLadsgroupT423978 Special:Mediastatistics is being weird and not grouping similar file types together
 OpenZabeT425191 Drop old image tables from wikireplicas
 ResolvedZabeT426804 filerevision view should not filter out deleted file revisions
 StalledZabeT428970 Stop writing to the old file db schema
 ResolvedBUG REPORTManvikesarwani09T429720 Files on Betacommons can be moved once, then never again

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:09 AM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz33226.
• bzimport added a subscriber: Unknown Object (MLST).
duplicatebug created this task.Dec 17 2011, 8:43 PM
gerritbot added a comment.Mar 2 2014, 7:32 PM

Change 116291 had a related patch set uploaded by Umherirrender:
return array on prop=imageinfo for empty metadata

https://gerrit.wikimedia.org/r/116291

gerritbot added a comment.Mar 13 2014, 6:37 PM

Change 116291 abandoned by Umherirrender:
return array on prop=imageinfo for empty metadata

Reason:
Backward compatibility issue

https://gerrit.wikimedia.org/r/116291

Umherirrender added a comment.Mar 13 2014, 6:41 PM

Seems to be unfixable without versioned api (see blocking bug 38891), setting Importance to Lowest to avoid a WONTFIX.

duplicatebug added a project: Future-Release.Dec 13 2014, 4:34 PM
duplicatebug set Security to None.
duplicatebug unsubscribed.
Anomie added a subtask: T89971: ApiQueryImageInfo is crufty, needs rewrite.Feb 20 2015, 5:56 PM
Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.
• Phabricator_maintenance removed a project: Future-Release.Aug 12 2016, 4:54 PM
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.
Umherirrender unsubscribed.Feb 27 2021, 10:24 PM
Pppery added a project: MediaWiki-File-management.Dec 26 2024, 7:12 PM
Maintenance_bot added a project: Commons.Dec 26 2024, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits