| bwang | |
| Nov 30 2023, 6:28 PM |
| F41617826: screenshot 204.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41617825: screenshot 203.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41617829: screenshot 205.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41617712: screenshot 200.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41617711: screenshot 202.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41617710: screenshot 201.mov.gif | |
| Dec 22 2023, 12:34 AM |
| F41549218: Screenshot 2023-11-30 at 12.20.50 PM.png | |
| Nov 30 2023, 6:28 PM |
| F41549216: Screenshot 2023-11-30 at 12.20.12 PM.png | |
| Nov 30 2023, 6:28 PM |
Vector 2022 has scrollable indicators on sticky pinnable elements
After changes in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/976861, which were necessary to support the pinned client prefs menu, the scrolling indicators broke on non Zebra.
Missing scroll indicator on the TOC
Change 979391 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix nonzebra sticky container scrolling behavior and scrollable indicator
This is not a cache problem so backport can happen later. Might be obsoleted by Zebra deploy.
Change 979391 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix nonzebra sticky container scrolling behavior and scrollable indicator
Change 980467 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):
[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] Fix nonzebra sticky container scrolling behavior and scrollable indicator
Change 980467 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] Fix nonzebra sticky container scrolling behavior and scrollable indicator
Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:27:42Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]]
Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:30:00Z] <jforrester@deploy2002> jdlrobson and jforrester and jdrewniak: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:40:32Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] (duration: 12m 50s)
Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
❌ AC1: Verify scroll indicator on the TOC
The scroll indicator works, but if you look at the screen shots you will see that sometimes the scroll bar only activates after more than one TOC item.
❌ AC2: Verify scroll indicator with client prefs
I'm not sure how this is supposed to work. when the Main Menu an TOC are both in the sidebar, the main menu doesn't have a scroll bar, but the TOC will. On the right side, when the tools menu and client prefs are in the sidebar, they both have one scroll bar, as though they are the same. Some clarification on how they should work when there are multiple menus pinned to the same side is needed.
Left side behavior:
Right side behavior:
@Edtadros i believe both of these are passes. in AC1 the scroll bars are supposed to only show up when the contents are overflowing/cut off.
In AC2, page tools and client prefs will share the same scroll bar because they are both sticky when you scroll down, meaning they need to be in the same container. This is different than the main menu and toc because the main menu is not sticky