Page MenuHomePhabricator
Create Task
Maniphest T347712

[Zebra] remove feature flag & merge Zebra into default styles
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

After the Zebra module has been refactored T347638 and tested T347711 we can remove the module entirely and merge the affected files into the default Vector 2022 CSS module. This step is changes many files and should be reviewed carefully. It requires selectors on the HTML element to be updated, i.e. removing & from &.vector-feature-toc-pinned-enabled. We also should carefully review the mixins and variables after the merge.

Prerequisites

T353008 is done.

TODO

  • Decide whether it is useful/less risky to backport a change to enable Zebra everywhere in production prior to the wmf.9 train deployment to catch bugs earlier in the sprint.
  • Move the styles
  • Update skin.json so Zebra is the default value.

Details

Other Assignee
Jdrewniak
SubjectRepoBranchLines +/-
[Zebra] Remove !importantmediawiki/skins/Vectormaster+1 -3
[Zebra] Merge skins.vector.zebra.styles module into skins.vector.stylesmediawiki/skins/Vectormaster+267 -1 K
Zebra remove feature flagmediawiki/skins/Vectormaster+50 -90
Zebra: reflect default configurationmediawiki/skins/Vectormaster+3 -3
[WIP] Merge Zebra module CSS into skins.vector.stylesmediawiki/skins/Vectormaster+292 -1 K
[Zebra] Make .vector-column-start cache compatiblemediawiki/skins/Vectorwmf/1.42.0-wmf.7+6 -12
[Zebra] Make .vector-column-start cache compatiblemediawiki/skins/Vectormaster+6 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdrewniak added a parent task: T347713: [min-epic] Incorporate Zebra refactor into default Vector 2022 styles.Sep 29 2023, 2:08 PM
Jdlrobson moved this task from Incoming to Web Team FY2023-24 Q2 Sprint 1 on the Web-Team-Backlog board.Oct 6 2023, 8:56 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog.
ovasileva triaged this task as High priority.Oct 11 2023, 3:37 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 19 2023, 5:51 PM
ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 23 2023, 3:09 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2).Oct 23 2023, 3:23 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 2 2023, 12:09 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 6 2023, 6:40 PM
Jdlrobson subscribed.

Moved to sprint 4 as this is blocked on testing performed in T347711

Jdlrobson set the point value for this task to 3.Nov 9 2023, 6:21 PM

Estimated by Jon, Kim, Mo: per Kim Pixel will catch a lot of the issues here but we may need to make some manual fixes as we do this.

Jdlrobson mentioned this in T348341: ToC should not auto-scroll when scrolling the top.Nov 9 2023, 6:32 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 15 2023, 6:18 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 15 2023, 6:23 PM
Jdlrobson updated the task description. (Show Details)Nov 16 2023, 6:32 PM
• Mabualruz claimed this task.Nov 21 2023, 6:13 AM
• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
ovasileva moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 21 2023, 9:05 AM
Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 21 2023, 5:42 PM
gerritbot added a comment.Nov 21 2023, 7:33 PM

Change 976306 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [WIP] Merge Zebra module CSS into skins.vector.styles

https://gerrit.wikimedia.org/r/976306

gerritbot added a project: Patch-For-Review.Nov 21 2023, 7:33 PM
gerritbot added a comment.Nov 21 2023, 8:56 PM

Change 975932 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Zebra remove feature flag

https://gerrit.wikimedia.org/r/975932

gerritbot added a comment.Nov 21 2023, 9:05 PM

Change 975933 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Zebra merge Zebra into default styles

https://gerrit.wikimedia.org/r/975933

• Mabualruz moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 21 2023, 9:06 PM
Jdlrobson changed the task status from Open to Stalled.Nov 21 2023, 11:09 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4).

Per standup we'll look to do this next sprint given recent bugs to reduce risk given the planned deployment (please do not merge this until then)

gerritbot added a comment.Nov 22 2023, 2:50 PM

Change 976708 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Zebra prepare for HTML Cache issue

https://gerrit.wikimedia.org/r/976708

• Mabualruz added a comment.Nov 22 2023, 4:47 PM

We need to merge 1 patch for this task asap, so we can mitigate html caching issues https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/976708/

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 10:07 AM
Jdlrobson changed the task status from Stalled to Open.Nov 30 2023, 6:26 PM
Jdlrobson updated the task description. (Show Details)Nov 30 2023, 6:28 PM
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 8:47 PM
gerritbot added a comment.Dec 4 2023, 11:17 PM

Change 976708 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/976708

Jdlrobson added a comment.Dec 4 2023, 11:39 PM

"Decide whether it is useful/less risky to backport a change to enable Zebra everywhere in production prior to the wmf.9 train deployment to catch bugs earlier in the sprint."

I think we decided to backport this tomorrow?

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 11:39 PM
gerritbot added a comment.Dec 5 2023, 5:47 PM

Change 979704 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/979704

Jdlrobson reassigned this task from • Mabualruz to KSarabia-WMF.Dec 5 2023, 5:47 PM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.
Jdlrobson added a subscriber: • Mabualruz.
This comment was removed by Jdlrobson.
Jdlrobson removed KSarabia-WMF as the assignee of this task.Dec 5 2023, 5:49 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.
Jdlrobson added a subscriber: KSarabia-WMF.
Jdlrobson assigned this task to • Mabualruz.Dec 5 2023, 5:52 PM
Jdlrobson updated Other Assignee, added: Jdrewniak.
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.

There are 2 patches that need to be merged one after the other. This will need to be merged before Monday (ideally Thursday at latest).

Mo will rebase this and move into code review.

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 5 2023, 7:59 PM
gerritbot added a comment.Dec 5 2023, 9:21 PM

Change 979704 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/979704

Stashbot mentioned this in T352464: Non zebra scrollable indicators on sticky pinnable elements (toc, page tools, client prefs) are broken.Dec 5 2023, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:27:42Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]]

Stashbot mentioned this in T351830: [Zebra] Make vector-column-start element cache compatible.Dec 5 2023, 9:27 PM
Stashbot added a comment.Dec 5 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:30:00Z] <jforrester@deploy2002> jdlrobson and jforrester and jdrewniak: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 5 2023, 9:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:40:32Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] (duration: 12m 50s)

Jdlrobson added a comment.Dec 6 2023, 12:25 AM

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/975933/ is ready for review.

gerritbot added a comment.Dec 6 2023, 4:52 PM

Change 976306 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] [WIP] Merge Zebra module CSS into skins.vector.styles

Reason:

Abandoned in favour of: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/975933

https://gerrit.wikimedia.org/r/976306

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 7 2023, 5:45 PM

Decide whether it is useful/less risky to backport a change to enable Zebra everywhere in production prior to the wmf.9 train deployment to catch bugs earlier in the sprint.

Given the recent bug reports, we should enable this by feature flag first, after we've addressed the bugs relating to the table of contents scrolling (T352930 and T352851)

Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 7 2023, 5:53 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q2 Sprint 5).
Jdlrobson updated the task description. (Show Details)
ovasileva closed subtask T351697: [Zebra] Fix ToC alignment and subsection toggle buttons being cut off as Resolved.Dec 12 2023, 10:04 AM
gerritbot added a comment.Dec 13 2023, 7:16 PM

Change 982904 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Zebra: reflect default configuration

https://gerrit.wikimedia.org/r/982904

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:22 AM
gerritbot added a comment.Jan 5 2024, 9:06 PM

Change 982904 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Zebra: reflect default configuration

Reason:

Flag will be removed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/975933

https://gerrit.wikimedia.org/r/982904

Jdlrobson mentioned this in T353071: Zebra causes 3kb CSS spike (@todo) and @wikimedia/codex and codex-styles AND codex-search-styles on page load (now fixed).Jan 5 2024, 9:17 PM
ovasileva added a project: Desktop Improvements (Vector 2022).Jan 8 2024, 9:39 AM
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
Jdlrobson moved this task from Ready for Development to Needs More Work on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 8 2024, 7:00 PM
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 9 2024, 2:53 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 9 2024, 5:14 PM
gerritbot added a comment.Jan 9 2024, 5:33 PM

Change 975933 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Merge skins.vector.zebra.styles module into skins.vector.styles

https://gerrit.wikimedia.org/r/975933

gerritbot added a comment.Jan 9 2024, 5:44 PM

Change 975932 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] Zebra remove feature flag

Reason:

covered by 975933

https://gerrit.wikimedia.org/r/975932

ovasileva claimed this task.Jan 9 2024, 5:46 PM
ovasileva moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.
ovasileva subscribed.

@ovasileva to do some testing of Zebra as part of sign-off

gerritbot added a comment.Jan 9 2024, 6:21 PM

Change 989172 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [Zebra] Remove !important

https://gerrit.wikimedia.org/r/989172

gerritbot added a comment.Jan 9 2024, 7:45 PM

Change 989172 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Remove !important

https://gerrit.wikimedia.org/r/989172

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 9 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 8:30 PM
Jdlrobson added a comment.EditedJan 11 2024, 5:36 PM

This will sit here until the train has finished running (next Thursday)

aliu subscribed.Jan 18 2024, 8:10 PM

The zebra feature flag seems removed now.

Jdlrobson closed this task as Resolved.Jan 19 2024, 12:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits